Skip to content

Fix GH-15752: finfo_file() - parameter validation error messages - #15755

Closed
DanielEScherzer wants to merge 1 commit into
php:PHP-8.2from
DanielEScherzer:finfo_file
Closed

Fix GH-15752: finfo_file() - parameter validation error messages#15755
DanielEScherzer wants to merge 1 commit into
php:PHP-8.2from
DanielEScherzer:finfo_file

Conversation

@DanielEScherzer

@DanielEScherzerDanielEScherzer commented Sep 4, 2024•
edited
Loading

Copy link
Copy Markdown
Member

Show the correct parameter names and numbers - the errors are caused by the
second parameter being empty or having null bytes, not the first.

@DanielEScherzerDanielEScherzer mentioned this pull request Sep 4, 2024
Closed
@DanielEScherzer

DanielEScherzer commented Sep 4, 2024

Copy link
Copy Markdown
MemberAuthor

Note that the merge to master will be complicated by #15489 - error function and output are different now

@devnexen

devnexen commented Sep 4, 2024

Copy link
Copy Markdown
Member

Note that the merge to master will be complicated by #15489 - error function and output are different now

Differences between master and release branches is a common occurence, nothing new ! lgtm once you fix the existing tests failures.

@DanielEScherzerDanielEScherzer changed the title Fix GH-15752: finfo_file() - parameter validation error messageFix GH-15752: finfo_file() - parameter validation error messagesSep 4, 2024
@DanielEScherzer

DanielEScherzer commented Sep 4, 2024

Copy link
Copy Markdown
MemberAuthor

Note that the merge to master will be complicated by #15489 - error function and output are different now

Differences between master and release branches is a common occurence, nothing new ! lgtm once you fix the existing tests failures.

Done - turns out there is an existing test that was just expecting the wrong thing, so I fixed that and dropped my new test

@DanielEScherzer
FixphpGH-15752:finfo_file()- parameter validation error messages
ed32452
Show the correct parameter names and numbers - the errors are caused by the
second parameter being empty or having null bytes, not the first.
devnexen
devnexen approved these changes Sep 5, 2024
View reviewed changes

@devnexendevnexen left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LCTM

devnexen pushed a commit that referenced this pull request Sep 5, 2024
@DanielEScherzer@devnexen
backportingGH-15755fix.
29f9f90
@DanielEScherzer
DanielEScherzer deleted the finfo_file branch September 5, 2024 01:05
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@devnexendevnexendevnexen approved these changes

Assignees

No one assigned

Labels

Extension: fileinfo

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielEScherzer@devnexen