ext/standard: validate mode in array_filter() by jorgsowa · Pull Request #15647 · php/php-src

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa · 2024-08-29T22:26:54Z

Validates mode in the function array_filter() and creates complementary ARRAY_FILTER_USE_VALUE without exposing it as a PHP constant.

bukka · 2024-09-02T10:13:17Z

I think this might be safer to go through deprecation first.

bukka · 2024-09-02T10:13:58Z

Technically it's a BC break as the invalid mode is currently ignored.

jorgsowa · 2024-09-02T16:09:26Z

Makes sense. I will wait for PHP 8.5. I was following a similar change with round() which didn't need RFC: #12252

cmb69 · 2024-10-30T13:52:20Z

A deprecation is certainly more user friendly, but requiring the RFC process for this appears to be overkill. After all, users are not supposed to pass nonsense to well documented functions.

bukka · 2024-11-02T13:12:51Z

Well just that something users are not supposed to do, does not mean that it's not a BC break. In my opinion it is a BC break and as such we should go through the deprecation. I agree that doing RFC is overkill but I don't think we need RFC if we get some sort of agreement.

iluuu1994 · 2025-03-10T23:26:47Z

@@ -6533,15 +6544,15 @@ PHP_FUNCTION(array_filter)

 	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
- if (use_type) {
+ if (mode) {


If you want to be explicit, you should use mode != ARRAY_FILTER_USE_VALUE, which should end up compiling to the same thing.

I also missed this, this is still unresolved.

iluuu1994

LGTM. I wouldn't object to this in a minor version, but @bukka should confirm whether he does. If so, you can just change the error to a deprecation. According to the policy:

https://github.com/php/policies/blob/main/release-process.rst#feature-selection-and-development

However, any change that breaks user-facing backward compatibility MUST go through the RFC process.

From a pedantic PoV, this is breaking. In that case, this would even need an entry in the deprecation RFC.

Girgias

Needs an UPGRADING entry but otherwise implementation looks good to me.

jorgsowa · 2026-01-20T22:55:00Z

Thank you for review. Entry added to UPGRADING.

jorgsowa · 2026-01-25T22:07:39Z

Could this PR be merged?

Girgias · 2026-01-26T16:02:44Z

Merged, as having it lie around isn't helpful. If someone complains this can always be revisited.

jorgsowa · 2026-01-26T17:28:19Z

Thank you @Girgias

…RRAY_FILTER_USE_VALUE` In phpGH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`.

…RRAY_FILTER_USE_VALUE` In GH-15647, the `array_filter` function was changed to throw a `ValueError` exception when the `$mode` parameter receives an invalid. Additionally, it declares a new `ARRAY_FILTER_USE_VALUE`, assigned (`int 1`) to it. This changes the default value of the `array_filter` function's `$mode` parameter to use the new constant, changing it from `int $mode = 0` to `int $mode = ARRAY_FILTER_USE_KEY)`. ClosesGH-21100.

jorgsowa requested a review from bukka as a code owner August 29, 2024 22:26

github-actionsBot added the Extension: standard label Aug 29, 2024

jorgsowa mentioned this pull request Oct 29, 2024
array_change_key_case(): Throw ValueError on invalid argument #15883
Merged

bukka mentioned this pull request Feb 24, 2025
ext/standard: pathinfo() check flags argument validity. #17859
Closed

iluuu1994 reviewed Mar 10, 2025
View reviewed changes

Comment threadext/standard/array.c Outdated

iluuu1994 reviewed Mar 10, 2025
View reviewed changes

jorgsowa force-pushed the check-mode-in-array-filter branch from 9245732 to 2111c36Compare January 15, 2026 18:04

github-actionsBot added the ABI break label Jan 15, 2026

iluuu1994 approved these changes Jan 15, 2026
View reviewed changes

Comment threadext/standard/array.c Outdated

Girgias reviewed Jan 19, 2026
View reviewed changes

Comment threadext/standard/php_array.h
Comment threadext/standard/array.c Outdated

jorgsowa requested a review from kocsismate as a code owner January 19, 2026 22:47

jorgsowa force-pushed the check-mode-in-array-filter branch 2 times, most recently from e780744 to cd686d9Compare January 19, 2026 22:53

Girgias approved these changes Jan 20, 2026
View reviewed changes

jorgsowa added 7 commits January 22, 2026 22:06

Validate mode in array_filter()
e0e6917

Added test for validation of mode in array_filter()
1555309

nit: reverted empty line
0ac07dc

added ARRAY_FILTER_USE_VALUE constant
e077311

improved error message
42ba2f1

added NEWS entry
9bd07e4

add entry to UPGRADING
6edc245

jorgsowa force-pushed the check-mode-in-array-filter branch from 4c2201a to 6edc245Compare January 22, 2026 21:08

Girgias merged commit 6d95a22 into php:masterJan 26, 2026
10 checks passed

Ayesh mentioned this pull request Jan 31, 2026
ext/standard: array_filter$mode param follow-up #21100
Closed

jorgsowa deleted the check-mode-in-array-filter branch July 10, 2026 14:29

jrfnl mentioned this pull request Aug 28, 2026
PHP 8.6 | array_filter() mode validation is non-strict + same for array_change_key_case() $case #23488
Closed