ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Girgias merged 7 commits into from
Jan 26, 2026
Merged

ext/standard: validate mode in array_filter() #15647

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e0e6917
Validate mode in array_filter()
jorgsowa Aug 29, 2024
1555309
Added test for validation of mode in array_filter()
jorgsowa Aug 29, 2024
0ac07dc
nit: reverted empty line
jorgsowa Jan 16, 2026
e077311
added ARRAY_FILTER_USE_VALUE constant
jorgsowa Jan 19, 2026
42ba2f1
improved error message
jorgsowa Jan 19, 2026
9bd07e4
added NEWS entry
jorgsowa Jan 19, 2026
6edc245
add entry to UPGRADING
jorgsowa Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions NEWS
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
. Fixed bug GH-19926 (reset internal pointer earlier while splicing array
while COW violation flag is still set). (alexandre-daubois)
. Invalid mode values now throw in array_filter() instead of being silently
defaulted to 0. (Jorg Sowa)

- Streams:
. Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down
4 changes: 4 additions & 0 deletions UPGRADING
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
. Invalid values now throw in Phar::mungServer() instead of being silently
ignored.

- Standard:
. Invalid mode values now throw in array_filter() instead of being silently
defaulted to 0.

========================================
2. New Features
========================================
Expand Down
14 changes: 12 additions & 2 deletions ext/standard/array.c
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
zval args[2];
zval retval;
bool have_callback = 0;
zend_long use_type = 0;
zend_long use_type = ARRAY_FILTER_USE_VALUE;
zend_string *string_key;
zend_fcall_info fci = empty_fcall_info;
zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
Z_PARAM_LONG(use_type)
ZEND_PARSE_PARAMETERS_END();

switch (use_type) {
case ARRAY_FILTER_USE_VALUE:
case ARRAY_FILTER_USE_BOTH:
case ARRAY_FILTER_USE_KEY:
break;
default:
zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
RETURN_THROWS();
}

if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
RETVAL_EMPTY_ARRAY();
return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
if (have_callback) {
if (use_type) {
if (use_type != ARRAY_FILTER_USE_VALUE) {
/* Set up the key */
if (!string_key) {
ZVAL_LONG(key, num_key);
Expand Down
5 changes: 5 additions & 0 deletions ext/standard/basic_functions.stub.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
*/
const COUNT_RECURSIVE = UNKNOWN;

/**
* @var int
* @cvalue ARRAY_FILTER_USE_VALUE
*/
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
* @var int
* @cvalue ARRAY_FILTER_USE_BOTH
Expand Down
3 changes: 2 additions & 1 deletion ext/standard/basic_functions_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions ext/standard/php_array.h
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE 0
Comment thread
Girgias marked this conversation as resolved.
#define ARRAY_FILTER_USE_BOTH 1
#define ARRAY_FILTER_USE_KEY 2

Expand Down
16 changes: 16 additions & 0 deletions ext/standard/tests/array/array_filter_invalid_mode.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Girgias
merged 7 commits into

from

Jan 26, 2026
 Merged


ext/standard: validate mode in array_filter()
#15647
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
e0e6917

Validate mode in array_filter()


jorgsowa Aug 29, 2024
1555309

Added test for validation of mode in array_filter()


jorgsowa Aug 29, 2024
0ac07dc

nit: reverted empty line


jorgsowa Jan 16, 2026
e077311

added ARRAY_FILTER_USE_VALUE constant


jorgsowa Jan 19, 2026
42ba2f1

improved error message


jorgsowa Jan 19, 2026
9bd07e4

added NEWS entry


jorgsowa Jan 19, 2026
6edc245

add entry to UPGRADING


jorgsowa Jan 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
NEWS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
 . Fixed bug GH-19926 (reset internal pointer earlier while splicing array
 while COW violation flag is still set). (alexandre-daubois)
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0. (Jorg Sowa)

- Streams:
 . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down

4 changes: 4 additions & 0 deletions
UPGRADING

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
 . Invalid values now throw in Phar::mungServer() instead of being silently
 ignored.

- Standard:
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0.

========================================
2. New Features
========================================
Expand Down

14 changes: 12 additions & 2 deletions
ext/standard/array.c

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
	zval args[2];
	zval retval;
	bool have_callback = 0;
	zend_long use_type = 0;
	zend_long use_type = ARRAY_FILTER_USE_VALUE;
	zend_string *string_key;
	zend_fcall_info fci = empty_fcall_info;
	zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
 Z_PARAM_LONG(use_type)
	ZEND_PARSE_PARAMETERS_END();

	switch (use_type) {
 case ARRAY_FILTER_USE_VALUE:
 case ARRAY_FILTER_USE_BOTH:
 case ARRAY_FILTER_USE_KEY:
 break;
 default:
 zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
 RETURN_THROWS();
	}

	if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
 RETVAL_EMPTY_ARRAY();
 return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
 if (use_type) {
 if (use_type != ARRAY_FILTER_USE_VALUE) {
 /* Set up the key */
 if (!string_key) {
 ZVAL_LONG(key, num_key);
Expand Down

5 changes: 5 additions & 0 deletions
ext/standard/basic_functions.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
 */
const COUNT_RECURSIVE = UNKNOWN;

/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_VALUE
 */
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_BOTH
Expand Down

3 changes: 2 additions & 1 deletion
ext/standard/basic_functions_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


1 change: 1 addition & 0 deletions
ext/standard/php_array.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE	0
Comment thread
Girgias marked this conversation as resolved.

#define ARRAY_FILTER_USE_BOTH	1
#define ARRAY_FILTER_USE_KEY	2

Expand Down

16 changes: 16 additions & 0 deletions
ext/standard/tests/array/array_filter_invalid_mode.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
 var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
 echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Girgias
merged 7 commits into

from

Jan 26, 2026
 Merged


ext/standard: validate mode in array_filter()
#15647
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
e0e6917

Validate mode in array_filter()


jorgsowa Aug 29, 2024
1555309

Added test for validation of mode in array_filter()


jorgsowa Aug 29, 2024
0ac07dc

nit: reverted empty line


jorgsowa Jan 16, 2026
e077311

added ARRAY_FILTER_USE_VALUE constant


jorgsowa Jan 19, 2026
42ba2f1

improved error message


jorgsowa Jan 19, 2026
9bd07e4

added NEWS entry


jorgsowa Jan 19, 2026
6edc245

add entry to UPGRADING


jorgsowa Jan 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
NEWS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
 . Fixed bug GH-19926 (reset internal pointer earlier while splicing array
 while COW violation flag is still set). (alexandre-daubois)
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0. (Jorg Sowa)

- Streams:
 . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down

4 changes: 4 additions & 0 deletions
UPGRADING

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
 . Invalid values now throw in Phar::mungServer() instead of being silently
 ignored.

- Standard:
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0.

========================================
2. New Features
========================================
Expand Down

14 changes: 12 additions & 2 deletions
ext/standard/array.c

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
	zval args[2];
	zval retval;
	bool have_callback = 0;
	zend_long use_type = 0;
	zend_long use_type = ARRAY_FILTER_USE_VALUE;
	zend_string *string_key;
	zend_fcall_info fci = empty_fcall_info;
	zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
 Z_PARAM_LONG(use_type)
	ZEND_PARSE_PARAMETERS_END();

	switch (use_type) {
 case ARRAY_FILTER_USE_VALUE:
 case ARRAY_FILTER_USE_BOTH:
 case ARRAY_FILTER_USE_KEY:
 break;
 default:
 zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
 RETURN_THROWS();
	}

	if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
 RETVAL_EMPTY_ARRAY();
 return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
 if (use_type) {
 if (use_type != ARRAY_FILTER_USE_VALUE) {
 /* Set up the key */
 if (!string_key) {
 ZVAL_LONG(key, num_key);
Expand Down

5 changes: 5 additions & 0 deletions
ext/standard/basic_functions.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
 */
const COUNT_RECURSIVE = UNKNOWN;

/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_VALUE
 */
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_BOTH
Expand Down

3 changes: 2 additions & 1 deletion
ext/standard/basic_functions_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


1 change: 1 addition & 0 deletions
ext/standard/php_array.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE	0
Comment thread
Girgias marked this conversation as resolved.

#define ARRAY_FILTER_USE_BOTH	1
#define ARRAY_FILTER_USE_KEY	2

Expand Down

16 changes: 16 additions & 0 deletions
ext/standard/tests/array/array_filter_invalid_mode.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
 var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
 echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Girgias
merged 7 commits into

from

Jan 26, 2026
 Merged


ext/standard: validate mode in array_filter()
#15647
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
e0e6917

Validate mode in array_filter()


jorgsowa Aug 29, 2024
1555309

Added test for validation of mode in array_filter()


jorgsowa Aug 29, 2024
0ac07dc

nit: reverted empty line


jorgsowa Jan 16, 2026
e077311

added ARRAY_FILTER_USE_VALUE constant


jorgsowa Jan 19, 2026
42ba2f1

improved error message


jorgsowa Jan 19, 2026
9bd07e4

added NEWS entry


jorgsowa Jan 19, 2026
6edc245

add entry to UPGRADING


jorgsowa Jan 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
NEWS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
 . Fixed bug GH-19926 (reset internal pointer earlier while splicing array
 while COW violation flag is still set). (alexandre-daubois)
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0. (Jorg Sowa)

- Streams:
 . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down

4 changes: 4 additions & 0 deletions
UPGRADING

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
 . Invalid values now throw in Phar::mungServer() instead of being silently
 ignored.

- Standard:
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0.

========================================
2. New Features
========================================
Expand Down

14 changes: 12 additions & 2 deletions
ext/standard/array.c

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
	zval args[2];
	zval retval;
	bool have_callback = 0;
	zend_long use_type = 0;
	zend_long use_type = ARRAY_FILTER_USE_VALUE;
	zend_string *string_key;
	zend_fcall_info fci = empty_fcall_info;
	zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
 Z_PARAM_LONG(use_type)
	ZEND_PARSE_PARAMETERS_END();

	switch (use_type) {
 case ARRAY_FILTER_USE_VALUE:
 case ARRAY_FILTER_USE_BOTH:
 case ARRAY_FILTER_USE_KEY:
 break;
 default:
 zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
 RETURN_THROWS();
	}

	if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
 RETVAL_EMPTY_ARRAY();
 return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
 if (use_type) {
 if (use_type != ARRAY_FILTER_USE_VALUE) {
 /* Set up the key */
 if (!string_key) {
 ZVAL_LONG(key, num_key);
Expand Down

5 changes: 5 additions & 0 deletions
ext/standard/basic_functions.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
 */
const COUNT_RECURSIVE = UNKNOWN;

/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_VALUE
 */
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_BOTH
Expand Down

3 changes: 2 additions & 1 deletion
ext/standard/basic_functions_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


1 change: 1 addition & 0 deletions
ext/standard/php_array.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE	0
Comment thread
Girgias marked this conversation as resolved.

#define ARRAY_FILTER_USE_BOTH	1
#define ARRAY_FILTER_USE_KEY	2

Expand Down

16 changes: 16 additions & 0 deletions
ext/standard/tests/array/array_filter_invalid_mode.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
 var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
 echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Girgias
merged 7 commits into

from

Jan 26, 2026
 Merged


ext/standard: validate mode in array_filter()
#15647
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
e0e6917

Validate mode in array_filter()


jorgsowa Aug 29, 2024
1555309

Added test for validation of mode in array_filter()


jorgsowa Aug 29, 2024
0ac07dc

nit: reverted empty line


jorgsowa Jan 16, 2026
e077311

added ARRAY_FILTER_USE_VALUE constant


jorgsowa Jan 19, 2026
42ba2f1

improved error message


jorgsowa Jan 19, 2026
9bd07e4

added NEWS entry


jorgsowa Jan 19, 2026
6edc245

add entry to UPGRADING


jorgsowa Jan 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
NEWS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
 . Fixed bug GH-19926 (reset internal pointer earlier while splicing array
 while COW violation flag is still set). (alexandre-daubois)
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0. (Jorg Sowa)

- Streams:
 . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down

4 changes: 4 additions & 0 deletions
UPGRADING

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
 . Invalid values now throw in Phar::mungServer() instead of being silently
 ignored.

- Standard:
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0.

========================================
2. New Features
========================================
Expand Down

14 changes: 12 additions & 2 deletions
ext/standard/array.c

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
	zval args[2];
	zval retval;
	bool have_callback = 0;
	zend_long use_type = 0;
	zend_long use_type = ARRAY_FILTER_USE_VALUE;
	zend_string *string_key;
	zend_fcall_info fci = empty_fcall_info;
	zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
 Z_PARAM_LONG(use_type)
	ZEND_PARSE_PARAMETERS_END();

	switch (use_type) {
 case ARRAY_FILTER_USE_VALUE:
 case ARRAY_FILTER_USE_BOTH:
 case ARRAY_FILTER_USE_KEY:
 break;
 default:
 zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
 RETURN_THROWS();
	}

	if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
 RETVAL_EMPTY_ARRAY();
 return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
 if (use_type) {
 if (use_type != ARRAY_FILTER_USE_VALUE) {
 /* Set up the key */
 if (!string_key) {
 ZVAL_LONG(key, num_key);
Expand Down

5 changes: 5 additions & 0 deletions
ext/standard/basic_functions.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
 */
const COUNT_RECURSIVE = UNKNOWN;

/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_VALUE
 */
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_BOTH
Expand Down

3 changes: 2 additions & 1 deletion
ext/standard/basic_functions_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


1 change: 1 addition & 0 deletions
ext/standard/php_array.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE	0
Comment thread
Girgias marked this conversation as resolved.

#define ARRAY_FILTER_USE_BOTH	1
#define ARRAY_FILTER_USE_KEY	2

Expand Down

16 changes: 16 additions & 0 deletions
ext/standard/tests/array/array_filter_invalid_mode.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
 var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
 echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Girgias
merged 7 commits into

from

Jan 26, 2026
 Merged


ext/standard: validate mode in array_filter()
#15647
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
e0e6917

Validate mode in array_filter()


jorgsowa Aug 29, 2024
1555309

Added test for validation of mode in array_filter()


jorgsowa Aug 29, 2024
0ac07dc

nit: reverted empty line


jorgsowa Jan 16, 2026
e077311

added ARRAY_FILTER_USE_VALUE constant


jorgsowa Jan 19, 2026
42ba2f1

improved error message


jorgsowa Jan 19, 2026
9bd07e4

added NEWS entry


jorgsowa Jan 19, 2026
6edc245

add entry to UPGRADING


jorgsowa Jan 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
NEWS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
 . Fixed bug GH-19926 (reset internal pointer earlier while splicing array
 while COW violation flag is still set). (alexandre-daubois)
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0. (Jorg Sowa)

- Streams:
 . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down

4 changes: 4 additions & 0 deletions
UPGRADING

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
 . Invalid values now throw in Phar::mungServer() instead of being silently
 ignored.

- Standard:
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0.

========================================
2. New Features
========================================
Expand Down

14 changes: 12 additions & 2 deletions
ext/standard/array.c

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
	zval args[2];
	zval retval;
	bool have_callback = 0;
	zend_long use_type = 0;
	zend_long use_type = ARRAY_FILTER_USE_VALUE;
	zend_string *string_key;
	zend_fcall_info fci = empty_fcall_info;
	zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
 Z_PARAM_LONG(use_type)
	ZEND_PARSE_PARAMETERS_END();

	switch (use_type) {
 case ARRAY_FILTER_USE_VALUE:
 case ARRAY_FILTER_USE_BOTH:
 case ARRAY_FILTER_USE_KEY:
 break;
 default:
 zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
 RETURN_THROWS();
	}

	if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
 RETVAL_EMPTY_ARRAY();
 return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
 if (use_type) {
 if (use_type != ARRAY_FILTER_USE_VALUE) {
 /* Set up the key */
 if (!string_key) {
 ZVAL_LONG(key, num_key);
Expand Down

5 changes: 5 additions & 0 deletions
ext/standard/basic_functions.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
 */
const COUNT_RECURSIVE = UNKNOWN;

/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_VALUE
 */
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_BOTH
Expand Down

3 changes: 2 additions & 1 deletion
ext/standard/basic_functions_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


1 change: 1 addition & 0 deletions
ext/standard/php_array.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE	0
Comment thread
Girgias marked this conversation as resolved.

#define ARRAY_FILTER_USE_BOTH	1
#define ARRAY_FILTER_USE_KEY	2

Expand Down

16 changes: 16 additions & 0 deletions
ext/standard/tests/array/array_filter_invalid_mode.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
 var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
 echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Girgias
merged 7 commits into

from

Jan 26, 2026
 Merged


ext/standard: validate mode in array_filter()
#15647
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
e0e6917

Validate mode in array_filter()


jorgsowa Aug 29, 2024
1555309

Added test for validation of mode in array_filter()


jorgsowa Aug 29, 2024
0ac07dc

nit: reverted empty line


jorgsowa Jan 16, 2026
e077311

added ARRAY_FILTER_USE_VALUE constant


jorgsowa Jan 19, 2026
42ba2f1

improved error message


jorgsowa Jan 19, 2026
9bd07e4

added NEWS entry


jorgsowa Jan 19, 2026
6edc245

add entry to UPGRADING


jorgsowa Jan 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
NEWS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
 . Fixed bug GH-19926 (reset internal pointer earlier while splicing array
 while COW violation flag is still set). (alexandre-daubois)
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0. (Jorg Sowa)

- Streams:
 . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down

4 changes: 4 additions & 0 deletions
UPGRADING

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
 . Invalid values now throw in Phar::mungServer() instead of being silently
 ignored.

- Standard:
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0.

========================================
2. New Features
========================================
Expand Down

14 changes: 12 additions & 2 deletions
ext/standard/array.c

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
	zval args[2];
	zval retval;
	bool have_callback = 0;
	zend_long use_type = 0;
	zend_long use_type = ARRAY_FILTER_USE_VALUE;
	zend_string *string_key;
	zend_fcall_info fci = empty_fcall_info;
	zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
 Z_PARAM_LONG(use_type)
	ZEND_PARSE_PARAMETERS_END();

	switch (use_type) {
 case ARRAY_FILTER_USE_VALUE:
 case ARRAY_FILTER_USE_BOTH:
 case ARRAY_FILTER_USE_KEY:
 break;
 default:
 zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
 RETURN_THROWS();
	}

	if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
 RETVAL_EMPTY_ARRAY();
 return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
 if (use_type) {
 if (use_type != ARRAY_FILTER_USE_VALUE) {
 /* Set up the key */
 if (!string_key) {
 ZVAL_LONG(key, num_key);
Expand Down

5 changes: 5 additions & 0 deletions
ext/standard/basic_functions.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
 */
const COUNT_RECURSIVE = UNKNOWN;

/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_VALUE
 */
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_BOTH
Expand Down

3 changes: 2 additions & 1 deletion
ext/standard/basic_functions_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


1 change: 1 addition & 0 deletions
ext/standard/php_array.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE	0
Comment thread
Girgias marked this conversation as resolved.

#define ARRAY_FILTER_USE_BOTH	1
#define ARRAY_FILTER_USE_KEY	2

Expand Down

16 changes: 16 additions & 0 deletions
ext/standard/tests/array/array_filter_invalid_mode.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
 var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
 echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading

, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
ext/standard: validate mode in array_filter()#15647

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

Girgias
merged 7 commits into

from

Jan 26, 2026
 Merged


ext/standard: validate mode in array_filter()
#15647
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


7 commits


Select commit
Hold shift + click to select a range
e0e6917

Validate mode in array_filter()


jorgsowa Aug 29, 2024
1555309

Added test for validation of mode in array_filter()


jorgsowa Aug 29, 2024
0ac07dc

nit: reverted empty line


jorgsowa Jan 16, 2026
e077311

added ARRAY_FILTER_USE_VALUE constant


jorgsowa Jan 19, 2026
42ba2f1

improved error message


jorgsowa Jan 19, 2026
9bd07e4

added NEWS entry


jorgsowa Jan 19, 2026
6edc245

add entry to UPGRADING


jorgsowa Jan 20, 2026

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


2 changes: 2 additions & 0 deletions
NEWS

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -99,6 +99,8 @@ PHP NEWS
- Standard:
 . Fixed bug GH-19926 (reset internal pointer earlier while splicing array
 while COW violation flag is still set). (alexandre-daubois)
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0. (Jorg Sowa)

- Streams:
 . Added so_keepalive, tcp_keepidle, tcp_keepintvl and tcp_keepcnt stream
Expand Down

4 changes: 4 additions & 0 deletions
UPGRADING

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -23,6 +23,10 @@ PHP 8.6 UPGRADE NOTES
 . Invalid values now throw in Phar::mungServer() instead of being silently
 ignored.

- Standard:
 . Invalid mode values now throw in array_filter() instead of being silently
 defaulted to 0.

========================================
2. New Features
========================================
Expand Down

14 changes: 12 additions & 2 deletions
ext/standard/array.c

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -6453,7 +6453,7 @@ PHP_FUNCTION(array_filter)
	zval args[2];
	zval retval;
	bool have_callback = 0;
	zend_long use_type = 0;
	zend_long use_type = ARRAY_FILTER_USE_VALUE;
	zend_string *string_key;
	zend_fcall_info fci = empty_fcall_info;
	zend_fcall_info_cache fci_cache;
Expand All@@ -6466,6 +6466,16 @@ PHP_FUNCTION(array_filter)
 Z_PARAM_LONG(use_type)
	ZEND_PARSE_PARAMETERS_END();

	switch (use_type) {
 case ARRAY_FILTER_USE_VALUE:
 case ARRAY_FILTER_USE_BOTH:
 case ARRAY_FILTER_USE_KEY:
 break;
 default:
 zend_argument_value_error(3, "must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH");
 RETURN_THROWS();
	}

	if (zend_hash_num_elements(Z_ARRVAL_P(array)) == 0) {
 RETVAL_EMPTY_ARRAY();
 return;
Expand All@@ -6486,7 +6496,7 @@ PHP_FUNCTION(array_filter)

	ZEND_HASH_FOREACH_KEY_VAL(Z_ARRVAL_P(array), num_key, string_key, operand) {
 if (have_callback) {
 if (use_type) {
 if (use_type != ARRAY_FILTER_USE_VALUE) {
 /* Set up the key */
 if (!string_key) {
 ZVAL_LONG(key, num_key);
Expand Down

5 changes: 5 additions & 0 deletions
ext/standard/basic_functions.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -109,6 +109,11 @@
 */
const COUNT_RECURSIVE = UNKNOWN;

/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_VALUE
 */
const ARRAY_FILTER_USE_VALUE = UNKNOWN;
/**
 * @var int
 * @cvalue ARRAY_FILTER_USE_BOTH
Expand Down

3 changes: 2 additions & 1 deletion
ext/standard/basic_functions_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


1 change: 1 addition & 0 deletions
ext/standard/php_array.h

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -59,6 +59,7 @@ PHPAPI bool php_array_pick_keys(php_random_algo_with_state engine, zval *input,
#define PHP_COUNT_NORMAL 0
#define PHP_COUNT_RECURSIVE 1

#define ARRAY_FILTER_USE_VALUE	0
Comment thread
Girgias marked this conversation as resolved.

#define ARRAY_FILTER_USE_BOTH	1
#define ARRAY_FILTER_USE_KEY	2

Expand Down

16 changes: 16 additions & 0 deletions
ext/standard/tests/array/array_filter_invalid_mode.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,16 @@
--TEST--
Test array_filter() function : usage variations - mode exception
--FILE--
<?php

try {
 var_dump(array_filter([], mode: 999));
} catch (Throwable $e) {
 echo $e::class . ': '.$e->getMessage(), "\n";
}

echo "Done"
?>
--EXPECT--
ValueError: array_filter(): Argument #3 ($mode) must be one of ARRAY_FILTER_USE_VALUE, ARRAY_FILTER_USE_KEY, or ARRAY_FILTER_USE_BOTH
Done
Loading