Uh oh!
There was an error while loading. Please reload this page.
RFC: Clone with v2 - #18747
Conversation
iluuu1994
left a comment
There was a problem hiding this comment.
Note that I did not (yet) carefully look at all tests.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
622bf8a to
b5644eeCompareUh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Found as part of the clone-with review in php#18747.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
ndossche
left a comment
There was a problem hiding this comment.
I like how it turned out to be quite simple. One remark.
Uh oh!
There was an error while loading. Please reload this page.
…jects_clone_members_ex()`
TimWolla
commented
Jul 17, 2025
Indeed. It's a net addition of 70 lines (excluding tests): Thanks for the reviews. I've now did the final rebase including the latest remarks and added NEWS / UPGRADING. Will merge when CI is green. |
RFC: https://wiki.php.net/rfc/clone_with_v2
see TimWolla#6 for a preliminary review.