Skip to content

RFC: Clone with v2 - #18747

Merged
TimWolla merged 9 commits into
php:masterfrom
TimWolla:clone-with
Jul 17, 2025
Merged

RFC: Clone with v2#18747
TimWolla merged 9 commits into
php:masterfrom
TimWolla:clone-with

Conversation

@TimWolla

Copy link
Copy Markdown
Member

RFC: https://wiki.php.net/rfc/clone_with_v2

see TimWolla#6 for a preliminary review.

@iluuu1994iluuu1994 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that I did not (yet) carefully look at all tests.

Comment threadZend/zend_object_handlers.c Outdated
Comment threadZend/zend_object_handlers.h Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/tests/clone/clone_with_003.phpt Outdated
@TimWolla
TimWollaforce-pushed the clone-with branch 2 times, most recently from 622bf8a to b5644eeCompareJuly 9, 2025 10:31
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated
TimWolla added a commit to TimWolla/php-src that referenced this pull request Jul 16, 2025
TimWolla added a commit that referenced this pull request Jul 16, 2025

@iluuu1994iluuu1994 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Tim 🙂

Comment threadZend/tests/clone/clone_with_003.phpt Outdated
Comment threadZend/zend_objects.c Outdated
Comment threadZend/zend_objects.c Outdated

@ndosschendossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how it turned out to be quite simple. One remark.

Comment threadZend/zend_objects.c Outdated
@TimWolla

Copy link
Copy Markdown
MemberAuthor

I like how it turned out to be quite simple.

Indeed. It's a net addition of 70 lines (excluding tests):

 NEWS | 3 +++
UPGRADING | 3 ++-
Zend/zend_builtin_functions.c | 16 ++++++++++++++--
Zend/zend_builtin_functions.stub.php | 2 +-
Zend/zend_builtin_functions_arginfo.h | Bin 15788 -> 15865 bytes
Zend/zend_iterators.c | 1 +
Zend/zend_object_handlers.c | 1 +
Zend/zend_object_handlers.h | 2 ++
Zend/zend_objects.c | 46 ++++++++++++++++++++++++++++++++++++++++++++++
Zend/zend_objects.h | 1 +
Zend/zend_vm_def.h | 3 ++-
Zend/zend_vm_execute.h | Bin 2280253 -> 2280621 bytes
ext/com_dotnet/com_handlers.c | 1 +
ext/com_dotnet/com_saproxy.c | 1 +
14 files changed, 75 insertions(+), 5 deletions(-)

Thanks for the reviews. I've now did the final rebase including the latest remarks and added NEWS / UPGRADING. Will merge when CI is green.

@TimWolla
TimWolla merged commit 7f4076b into php:masterJul 17, 2025
9 checks passed
@TimWolla
TimWolla deleted the clone-with branch July 17, 2025 19:13
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@TimWolla@iluuu1994@ndossche