Uh oh!
There was an error while loading. Please reload this page.
zend_objects: Remove unnecessary refcounting when calling __clone() - #19145
Merged
Conversation
Found as part of the clone-with review in php#18747.
Merged
iluuu1994
approved these changes
Jul 16, 2025
iluuu1994
left a comment
Member
There was a problem hiding this comment.
Assuming the caller of zend_objects_clone_members() holds a strong reference to new_object that cannot be invalidated by __clone is reasonable.
ndossche
approved these changes
Jul 16, 2025
ndossche
left a comment
Member
There was a problem hiding this comment.
Tried to cheat it, for example with creating self-references, but it seems fine.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found as part of the clone-with review in #18747.
Specifically: https://github.com/php/php-src/pull/18747/files#r2209484855