Skip to content

RFC: Turn clone() into a function - #18919

Merged
TimWolla merged 14 commits into
php:masterfrom
TimWolla:clone-function
Jun 24, 2025
Merged

RFC: Turn clone() into a function#18919
TimWolla merged 14 commits into
php:masterfrom
TimWolla:clone-function

Conversation

@TimWolla

@TimWollaTimWolla commented Jun 23, 2025

Copy link
Copy Markdown
Member

@TimWolla
TimWolla requested a review from ndosscheJune 23, 2025 11:49
@TimWolla
TimWolla removed the request for review from dstogovJune 23, 2025 12:00
@TimWolla
opcache: Use fully-qualified function names in func_info.phpt
f3462cc
This is necessary for `clone()` which does not currently accept a
parameter-less syntax, unless fully-qualified.
@TimWollaTimWolla mentioned this pull request Jun 23, 2025
Merged
nikic pushed a commit to nikic/PHP-Parser that referenced this pull request Jun 23, 2025
@TimWolla
Support declaring functions with name clone (#1090)
8ab65b4
For use in stubs.
see 9c7a3f8
see https://wiki.php.net/rfc/clone_with_v2
see php/php-src#18919
iluuu1994
iluuu1994 approved these changes Jun 23, 2025
View reviewed changes

@iluuu1994iluuu1994 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM in general

Comment threadZend/tests/clone/bug36071.phpt Outdated
Comment threadZend/tests/clone/bug42817.phpt Outdated
Comment threadZend/zend_builtin_functions.c
Comment threadZend/zend_builtin_functions.c
Comment threadZend/zend_compile.c
ndossche
ndossche requested changes Jun 24, 2025
View reviewed changes

@ndosschendossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my syntax remark. Otherwise seems fine mostly.

Comment threadZend/zend_builtin_functions.c Outdated
Comment threadZend/zend_language_parser.y
Comment threadZend/zend_vm_def.h
ndossche
ndossche approved these changes Jun 24, 2025
View reviewed changes

@ndosschendossche left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Questions were answered and follow ups were proposed, so this LGTM

@TimWolla
TimWolla merged commit ca49a7b into php:masterJun 24, 2025
@TimWolla
TimWolla deleted the clone-function branch June 24, 2025 18:14
This was referenced Jun 25, 2025
Merged
Merged
@aidvuaidvu mentioned this pull request Oct 16, 2025
Merged
aidvu added a commit to Automattic/apm-agent-php that referenced this pull request Oct 16, 2025
@aidvu
PHP 8.5 support#20
d6ac9c2
[exit](php/php-src#13483) and [clone](php/php-src#18919) are real functions now.
sdevtop100-dot added a commit to sdevtop100-dot/php-parser that referenced this pull request Feb 17, 2026
@sdevtop100-dot
Support declaring functions with name clone (#1090)
3e4552b
For use in stubs.
see 9c7a3f8d8fa392fadb65dbb4cab29d90ded6ae9e
see https://wiki.php.net/rfc/clone_with_v2
see php/php-src#18919
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ndosschendosschendossche approved these changes
@iluuu1994iluuu1994iluuu1994 approved these changes
@kocsismatekocsismateAwaiting requested review from kocsismatekocsismate is a code owner

Assignees

No one assigned

Labels

ABI breakCategory: Build SystemCategory: EngineCategory: OptimizerExtension: opcacheRFC

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@TimWolla@iluuu1994@ndossche