Uh oh!
There was an error while loading. Please reload this page.
[RFC] Deprecate xml_parser_free() - #19449
Merged
Merged
Conversation
DanielEScherzer
requested review from
Girgias
and removed request for
kocsismate and ndosscheAugust 11, 2025 17:30
DanielEScherzer
commented
Aug 11, 2025
MemberAuthor
To avoid merge conflicts, NEWS/UPGRADING will be sent once this is approved |
ndossche
approved these changes
Aug 11, 2025
Girgias
commented
Aug 12, 2025
Member
Do we want to address the same remark as #19454 (review) ? |
DanielEScherzer
commented
Aug 12, 2025
MemberAuthor
Not right now, but can be addressed in a subsequent commit |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/deprecations_php_8_5#deprecate_xml_parser_free