[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielEScherzer merged 1 commit into from
Aug 12, 2025
Merged

[RFC] Deprecate xml_parser_free() #19449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Zend/tests/bug34617.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
$thing = new Thing();
xml_set_object($reader, $thing);
die("ok\n");
xml_parser_free($reader);
}
boom();
?>
Expand Down
1 change: 0 additions & 1 deletion ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
$p = xml_parser_create();
xml_parse_into_struct($p, $xml, $vals, $index);
xml_parser_free($p);
return var_export($vals, true);
}

Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/bug25666.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/bug26528.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
$sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
$parser = xml_parser_create();
$res = xml_parse_into_struct($parser,$sample,$vals,$index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/bug26614.inc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
xml_set_character_data_handler($xml_parser, "characterData");
if (!xml_parse($xml_parser, $xml, true))
echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
xml_parser_free($xml_parser);
}
1 change: 0 additions & 1 deletion ext/xml/tests/bug27908.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/bug30875.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/bug35447.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/bug46699.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down
2 changes: 0 additions & 2 deletions ext/xml/tests/bug50576.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down
2 changes: 0 additions & 2 deletions ext/xml/tests/bug72714.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
xml_parse($xml_parser, $xml);

xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down
2 changes: 2 additions & 0 deletions ext/xml/tests/bug72793.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===
3 changes: 2 additions & 1 deletion ext/xml/tests/bug76874.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===
3 changes: 0 additions & 3 deletions ext/xml/tests/set_element_handler_trampoline.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/set_element_handler_trampoline_errors.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/set_handler_trampoline.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml001.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
}
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml002.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
}
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml003.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
}
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down
2 changes: 0 additions & 2 deletions ext/xml/tests/xml004.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml009.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml010.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a
Expand Down
2 changes: 0 additions & 2 deletions ext/xml/tests/xml011.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml_closures_001.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml_error_string_basic.inc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
var_dump(xml_get_error_code($xml_parser));
var_dump(xml_error_string(xml_get_error_code($xml_parser)));
}
xml_parser_free($xml_parser);
}
1 change: 0 additions & 1 deletion ext/xml/tests/xml_parse_into_struct_variation.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down
15 changes: 15 additions & 0 deletions ext/xml/tests/xml_parser_free_deprecated.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done
2 changes: 0 additions & 2 deletions ext/xml/tests/xml_parser_set_option_basic.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml_set_notation_decl_handler_basic.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
xml_parse($parser, $data, true);
xml_parser_free($parser);
}
}

Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
xml_parse($parser, $data, true);
xml_parser_free($parser);
}


Expand Down
1 change: 0 additions & 1 deletion ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down
1 change: 1 addition & 0 deletions ext/xml/xml.stub.php
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down
11 changes: 9 additions & 2 deletions ext/xml/xml_arginfo.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all 
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '

Skip to content
[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

DanielEScherzer
merged 1 commit into

from

Aug 12, 2025
 Merged


[RFC] Deprecate xml_parser_free()
#19449
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
Zend/tests/bug34617.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
 $thing = new Thing();
 xml_set_object($reader, $thing);
 die("ok\n");
 xml_parser_free($reader);
}
boom();
?>
Expand Down

1 change: 0 additions & 1 deletion
ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
 $p = xml_parser_create();
 xml_parse_into_struct($p, $xml, $vals, $index);
 xml_parser_free($p);
 return var_export($vals, true);
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug25666.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26528.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
 $sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
 $parser = xml_parser_create();
 $res = xml_parse_into_struct($parser,$sample,$vals,$index);
 xml_parser_free($parser);
 var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26614.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
 xml_set_character_data_handler($xml_parser, "characterData");
 if (!xml_parse($xml_parser, $xml, true))
 echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/bug27908.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug30875.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug35447.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug46699.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug50576.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug72714.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

 xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
 xml_parse($xml_parser, $xml);

 xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down

2 changes: 2 additions & 0 deletions
ext/xml/tests/bug72793.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 2 additions & 1 deletion
ext/xml/tests/bug76874.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 0 additions & 3 deletions
ext/xml/tests/set_element_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_element_handler_trampoline_errors.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
 echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml002.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml003.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml004.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml009.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml010.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a 
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml011.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_closures_001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_error_string_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
 var_dump(xml_get_error_code($xml_parser));
 var_dump(xml_error_string(xml_get_error_code($xml_parser)));
 }
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_parse_into_struct_variation.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down

15 changes: 15 additions & 0 deletions
ext/xml/tests/xml_parser_free_deprecated.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml_parser_set_option_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_notation_decl_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
 xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
 xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
 $parser = xml_parser_create();
 xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }


Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down

1 change: 1 addition & 0 deletions
ext/xml/xml.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down

11 changes: 9 additions & 2 deletions
ext/xml/xml_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix");
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

DanielEScherzer
merged 1 commit into

from

Aug 12, 2025
 Merged


[RFC] Deprecate xml_parser_free()
#19449
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
Zend/tests/bug34617.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
 $thing = new Thing();
 xml_set_object($reader, $thing);
 die("ok\n");
 xml_parser_free($reader);
}
boom();
?>
Expand Down

1 change: 0 additions & 1 deletion
ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
 $p = xml_parser_create();
 xml_parse_into_struct($p, $xml, $vals, $index);
 xml_parser_free($p);
 return var_export($vals, true);
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug25666.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26528.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
 $sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
 $parser = xml_parser_create();
 $res = xml_parse_into_struct($parser,$sample,$vals,$index);
 xml_parser_free($parser);
 var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26614.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
 xml_set_character_data_handler($xml_parser, "characterData");
 if (!xml_parse($xml_parser, $xml, true))
 echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/bug27908.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug30875.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug35447.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug46699.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug50576.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug72714.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

 xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
 xml_parse($xml_parser, $xml);

 xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down

2 changes: 2 additions & 0 deletions
ext/xml/tests/bug72793.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 2 additions & 1 deletion
ext/xml/tests/bug76874.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 0 additions & 3 deletions
ext/xml/tests/set_element_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_element_handler_trampoline_errors.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
 echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml002.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml003.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml004.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml009.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml010.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a 
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml011.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_closures_001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_error_string_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
 var_dump(xml_get_error_code($xml_parser));
 var_dump(xml_error_string(xml_get_error_code($xml_parser)));
 }
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_parse_into_struct_variation.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down

15 changes: 15 additions & 0 deletions
ext/xml/tests/xml_parser_free_deprecated.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml_parser_set_option_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_notation_decl_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
 xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
 xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
 $parser = xml_parser_create();
 xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }


Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down

1 change: 1 addition & 0 deletions
ext/xml/xml.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down

11 changes: 9 additions & 2 deletions
ext/xml/xml_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms");
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

DanielEScherzer
merged 1 commit into

from

Aug 12, 2025
 Merged


[RFC] Deprecate xml_parser_free()
#19449
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
Zend/tests/bug34617.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
 $thing = new Thing();
 xml_set_object($reader, $thing);
 die("ok\n");
 xml_parser_free($reader);
}
boom();
?>
Expand Down

1 change: 0 additions & 1 deletion
ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
 $p = xml_parser_create();
 xml_parse_into_struct($p, $xml, $vals, $index);
 xml_parser_free($p);
 return var_export($vals, true);
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug25666.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26528.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
 $sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
 $parser = xml_parser_create();
 $res = xml_parse_into_struct($parser,$sample,$vals,$index);
 xml_parser_free($parser);
 var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26614.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
 xml_set_character_data_handler($xml_parser, "characterData");
 if (!xml_parse($xml_parser, $xml, true))
 echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/bug27908.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug30875.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug35447.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug46699.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug50576.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug72714.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

 xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
 xml_parse($xml_parser, $xml);

 xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down

2 changes: 2 additions & 0 deletions
ext/xml/tests/bug72793.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 2 additions & 1 deletion
ext/xml/tests/bug76874.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 0 additions & 3 deletions
ext/xml/tests/set_element_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_element_handler_trampoline_errors.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
 echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml002.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml003.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml004.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml009.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml010.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a 
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml011.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_closures_001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_error_string_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
 var_dump(xml_get_error_code($xml_parser));
 var_dump(xml_error_string(xml_get_error_code($xml_parser)));
 }
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_parse_into_struct_variation.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down

15 changes: 15 additions & 0 deletions
ext/xml/tests/xml_parser_free_deprecated.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml_parser_set_option_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_notation_decl_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
 xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
 xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
 $parser = xml_parser_create();
 xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }


Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down

1 change: 1 addition & 0 deletions
ext/xml/xml.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down

11 changes: 9 additions & 2 deletions
ext/xml/xml_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links");
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '

Skip to content
[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

DanielEScherzer
merged 1 commit into

from

Aug 12, 2025
 Merged


[RFC] Deprecate xml_parser_free()
#19449
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
Zend/tests/bug34617.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
 $thing = new Thing();
 xml_set_object($reader, $thing);
 die("ok\n");
 xml_parser_free($reader);
}
boom();
?>
Expand Down

1 change: 0 additions & 1 deletion
ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
 $p = xml_parser_create();
 xml_parse_into_struct($p, $xml, $vals, $index);
 xml_parser_free($p);
 return var_export($vals, true);
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug25666.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26528.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
 $sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
 $parser = xml_parser_create();
 $res = xml_parse_into_struct($parser,$sample,$vals,$index);
 xml_parser_free($parser);
 var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26614.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
 xml_set_character_data_handler($xml_parser, "characterData");
 if (!xml_parse($xml_parser, $xml, true))
 echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/bug27908.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug30875.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug35447.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug46699.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug50576.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug72714.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

 xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
 xml_parse($xml_parser, $xml);

 xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down

2 changes: 2 additions & 0 deletions
ext/xml/tests/bug72793.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 2 additions & 1 deletion
ext/xml/tests/bug76874.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 0 additions & 3 deletions
ext/xml/tests/set_element_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_element_handler_trampoline_errors.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
 echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml002.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml003.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml004.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml009.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml010.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a 
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml011.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_closures_001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_error_string_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
 var_dump(xml_get_error_code($xml_parser));
 var_dump(xml_error_string(xml_get_error_code($xml_parser)));
 }
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_parse_into_struct_variation.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down

15 changes: 15 additions & 0 deletions
ext/xml/tests/xml_parser_free_deprecated.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml_parser_set_option_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_notation_decl_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
 xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
 xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
 $parser = xml_parser_create();
 xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }


Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down

1 change: 1 addition & 0 deletions
ext/xml/xml.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down

11 changes: 9 additions & 2 deletions
ext/xml/xml_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default");
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

DanielEScherzer
merged 1 commit into

from

Aug 12, 2025
 Merged


[RFC] Deprecate xml_parser_free()
#19449
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
Zend/tests/bug34617.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
 $thing = new Thing();
 xml_set_object($reader, $thing);
 die("ok\n");
 xml_parser_free($reader);
}
boom();
?>
Expand Down

1 change: 0 additions & 1 deletion
ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
 $p = xml_parser_create();
 xml_parse_into_struct($p, $xml, $vals, $index);
 xml_parser_free($p);
 return var_export($vals, true);
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug25666.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26528.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
 $sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
 $parser = xml_parser_create();
 $res = xml_parse_into_struct($parser,$sample,$vals,$index);
 xml_parser_free($parser);
 var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26614.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
 xml_set_character_data_handler($xml_parser, "characterData");
 if (!xml_parse($xml_parser, $xml, true))
 echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/bug27908.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug30875.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug35447.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug46699.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug50576.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug72714.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

 xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
 xml_parse($xml_parser, $xml);

 xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down

2 changes: 2 additions & 0 deletions
ext/xml/tests/bug72793.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 2 additions & 1 deletion
ext/xml/tests/bug76874.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 0 additions & 3 deletions
ext/xml/tests/set_element_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_element_handler_trampoline_errors.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
 echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml002.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml003.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml004.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml009.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml010.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a 
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml011.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_closures_001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_error_string_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
 var_dump(xml_get_error_code($xml_parser));
 var_dump(xml_error_string(xml_get_error_code($xml_parser)));
 }
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_parse_into_struct_variation.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down

15 changes: 15 additions & 0 deletions
ext/xml/tests/xml_parser_free_deprecated.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml_parser_set_option_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_notation_decl_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
 xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
 xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
 $parser = xml_parser_create();
 xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }


Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down

1 change: 1 addition & 0 deletions
ext/xml/xml.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down

11 changes: 9 additions & 2 deletions
ext/xml/xml_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers");
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '

Skip to content
[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

DanielEScherzer
merged 1 commit into

from

Aug 12, 2025
 Merged


[RFC] Deprecate xml_parser_free()
#19449
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
Zend/tests/bug34617.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
 $thing = new Thing();
 xml_set_object($reader, $thing);
 die("ok\n");
 xml_parser_free($reader);
}
boom();
?>
Expand Down

1 change: 0 additions & 1 deletion
ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
 $p = xml_parser_create();
 xml_parse_into_struct($p, $xml, $vals, $index);
 xml_parser_free($p);
 return var_export($vals, true);
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug25666.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26528.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
 $sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
 $parser = xml_parser_create();
 $res = xml_parse_into_struct($parser,$sample,$vals,$index);
 xml_parser_free($parser);
 var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26614.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
 xml_set_character_data_handler($xml_parser, "characterData");
 if (!xml_parse($xml_parser, $xml, true))
 echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/bug27908.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug30875.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug35447.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug46699.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug50576.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug72714.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

 xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
 xml_parse($xml_parser, $xml);

 xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down

2 changes: 2 additions & 0 deletions
ext/xml/tests/bug72793.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 2 additions & 1 deletion
ext/xml/tests/bug76874.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 0 additions & 3 deletions
ext/xml/tests/set_element_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_element_handler_trampoline_errors.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
 echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml002.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml003.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml004.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml009.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml010.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a 
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml011.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_closures_001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_error_string_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
 var_dump(xml_get_error_code($xml_parser));
 var_dump(xml_error_string(xml_get_error_code($xml_parser)));
 }
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_parse_into_struct_variation.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down

15 changes: 15 additions & 0 deletions
ext/xml/tests/xml_parser_free_deprecated.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml_parser_set_option_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_notation_decl_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
 xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
 xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
 $parser = xml_parser_create();
 xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }


Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down

1 change: 1 addition & 0 deletions
ext/xml/xml.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down

11 changes: 9 additions & 2 deletions
ext/xml/xml_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.


, 'i');
if (__m === '*' || __re.test(location.href)) {
injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode");
}
} catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); }
})();
})();

Skip to content
[RFC] Deprecate xml_parser_free()#19449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

DanielEScherzer
merged 1 commit into

from

Aug 12, 2025
 Merged


[RFC] Deprecate xml_parser_free()
#19449
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


1 commit


Select commit


File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


1 change: 0 additions & 1 deletion
Zend/tests/bug34617.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -11,7 +11,6 @@ function boom()
 $thing = new Thing();
 xml_set_object($reader, $thing);
 die("ok\n");
 xml_parser_free($reader);
}
boom();
?>
Expand Down

1 change: 0 additions & 1 deletion
ext/libxml/tests/libxml_entity_loading_disabled_by_default.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ function parseXML2($xml) {
function parseXML3($xml) {
 $p = xml_parser_create();
 xml_parse_into_struct($p, $xml, $vals, $index);
 xml_parser_free($p);
 return var_export($vals, true);
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug25666.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26528.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -7,7 +7,6 @@ xml
 $sample = "<?xml version=\"1.0\"?><test attr=\"angle&lt;bracket\"/>";
 $parser = xml_parser_create();
 $res = xml_parse_into_struct($parser,$sample,$vals,$index);
 xml_parser_free($parser);
 var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug26614.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -69,5 +69,4 @@ foreach ($xmls as $desc => $xml) {
 xml_set_character_data_handler($xml_parser, "characterData");
 if (!xml_parse($xml_parser, $xml, true))
 echo "Error: ".xml_error_string(xml_get_error_code($xml_parser))."\n";
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/bug27908.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -12,7 +12,6 @@ function x_default_handler($xp,$data)
$xp = xml_parser_create();
xml_set_default_handler($xp,'x_default_handler');
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug30875.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ XML;

$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug35447.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ END_OF_XML;
$parser = xml_parser_create_ns('UTF-8');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
$result = xml_parse_into_struct($parser, $data, $vals, $index);
xml_parser_free($parser);
var_dump($vals);
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/bug46699.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -25,7 +25,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_default_handler($parser,'defaultfunc');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECTF--
<a xmlns="http://example.com/foo"%axmlns:bar="http://example.com/bar">
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug50576.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -21,15 +21,13 @@ echo 'Index array' . PHP_EOL;
print_r($index);
echo 'Vals array' . PHP_EOL;
print_r($vals);
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs) { echo $name . PHP_EOL; }
function endElement($parser, $name) { echo $name . PHP_EOL; }
$xml_parser = xml_parser_create();
xml_set_element_handler($xml_parser, 'startElement', 'endElement');
xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, 4);
xml_parse($xml_parser, $XML);
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/bug72714.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -22,8 +22,6 @@ function parse($tagstart) {

 xml_parser_set_option($xml_parser, XML_OPTION_SKIP_TAGSTART, $tagstart);
 xml_parse($xml_parser, $xml);

 xml_parser_free($xml_parser);
}

parse(3015809298423721);
Expand Down

2 changes: 2 additions & 0 deletions
ext/xml/tests/bug72793.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -33,4 +33,6 @@ $xml_parser->free();
===DONE===
--EXPECTF--
Deprecated: Function xml_set_object() is deprecated since 8.4, provide a proper method callable to xml_set_*_handler() functions in %s on line %d

Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 2 additions & 1 deletion
ext/xml/tests/bug76874.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -27,5 +27,6 @@ $object->test();

?>
===DONE===
--EXPECT--
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
===DONE===

3 changes: 0 additions & 3 deletions
ext/xml/tests/set_element_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -42,21 +42,18 @@ echo "Both handlers are trampolines:\n";
$parser = xml_parser_create();
xml_set_element_handler($parser, $startCallback, $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nStart handler is trampoline, end handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, $startCallback, 'endHandler');
xml_parse($parser, $xml, true);
xml_parser_free($parser);

echo "\nEnd handler is trampoline, start handler method string:\n";
$parser = xml_parser_create();
xml_set_object($parser, $customParser);
xml_set_element_handler($parser, 'startHandler', $endCallback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECTF--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_element_handler_trampoline_errors.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -36,7 +36,6 @@ try {
} catch (\Throwable $e) {
 echo $e::class, ': ', $e->getMessage(), PHP_EOL;
}
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/set_handler_trampoline.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -24,7 +24,6 @@ HERE;
$parser = xml_parser_create();
xml_set_processing_instruction_handler($parser, $callback);
xml_parse($parser, $xml, true);
xml_parser_free($parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -30,7 +30,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

function startElement($parser, $name, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml002.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -72,7 +72,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml003.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -71,7 +71,6 @@ while ($data = fread($fp, 4096)) {
 }
}
print "parse complete\n";
xml_parser_free($xml_parser);
?>
--EXPECT--
{?[<?xml version="1.0" encoding="ISO-8859-1"?>]}{?[
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml004.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,15 +13,13 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);
$xp = xml_parser_create();
xml_parser_set_option($xp, XML_OPTION_CASE_FOLDING, true);
xml_set_element_handler($xp, "start_element", "end_element");
$fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

function start_element($xp, $elem, $attribs)
{
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml009.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -28,7 +28,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
string(24) "http://example.com/foo@a"
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml010.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ $parser = xml_parser_create_ns("ISO-8859-1","@");
xml_set_element_handler($parser,'start_elem','end_elem');
xml_parser_set_option($parser,XML_OPTION_CASE_FOLDING,0);
xml_parse($parser, $xml);
xml_parser_free($parser);
?>
--EXPECT--
http://example.com/foo@a 
Expand Down

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml011.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -17,7 +17,6 @@ $xml = '<text>start<b /> This &amp; that</text>';
$parser = xml_parser_create();
xml_parse_into_struct($parser, $xml, $vals, $index);
print_r($vals);
xml_parser_free($parser);

echo "\nChange to empty end handler\n";
$parser = xml_parser_create();
Expand All@@ -26,7 +25,6 @@ xml_set_element_handler($parser,'start_elem','end_elem');
xml_set_element_handler($parser,'start_elem',NULL);
xml_parse($parser, $xml, TRUE);

xml_parser_free($parser);
echo "\nDone\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_closures_001.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -29,7 +29,6 @@ $fp = fopen("xmltest.xml", "r");
while ($data = fread($fp, 4096)) {
 xml_parse($xp, $data, feof($fp));
}
xml_parser_free($xp);

?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_error_string_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -13,5 +13,4 @@ foreach ($xmls as $xml) {
 var_dump(xml_get_error_code($xml_parser));
 var_dump(xml_error_string(xml_get_error_code($xml_parser)));
 }
 xml_parser_free($xml_parser);
}

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_parse_into_struct_variation.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -9,7 +9,6 @@ echo "*** Testing xml_parse_into_struct() : variation ***\n";
$simple = "<main><para><note>simple note</note></para><para><note>simple note</note></para></main>";
$p = xml_parser_create();
xml_parse_into_struct($p, $simple, $vals, $index);
xml_parser_free($p);
echo "Index array\n";
print_r($index);
echo "\nVals array\n";
Expand Down

15 changes: 15 additions & 0 deletions
ext/xml/tests/xml_parser_free_deprecated.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
@@ -0,0 +1,15 @@
--TEST--
xml_parser_free() deprecation message
--EXTENSIONS--
xml
--FILE--
<?php

$xp = xml_parser_create();
xml_parse($xp, '<root></root>',TRUE);
xml_parser_free($xp);
echo "Done\n";
?>
--EXPECTF--
Deprecated: Function xml_parser_free() is deprecated since 8.5, as it has no effect since PHP 8.0 in %s on line %d
Done

2 changes: 0 additions & 2 deletions
ext/xml/tests/xml_parser_set_option_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -26,8 +26,6 @@ var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));
var_dump(xml_parser_set_option($parser, XML_OPTION_TARGET_ENCODING, "US-ASCII"));
var_dump(xml_parser_get_option($parser, XML_OPTION_TARGET_ENCODING));

xml_parser_free( $parser );

echo "Done\n";
?>
--EXPECT--
Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_notation_decl_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -32,7 +32,6 @@ class XML_Parser
 xml_set_notation_decl_handler($parser, $this->notation_decl_handler(...));
 xml_set_unparsed_entity_decl_handler($parser, $this->unparsed_entity_decl_handler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }
}

Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_processing_instruction_handler_basic.phpt

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -18,7 +18,6 @@ class XML_Parser
 $parser = xml_parser_create();
 xml_set_processing_instruction_handler($parser, $this->PIHandler(...));
 xml_parse($parser, $data, true);
 xml_parser_free($parser);
 }


Expand Down

1 change: 0 additions & 1 deletion
ext/xml/tests/xml_set_start_namespace_decl_handler_basic.inc

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -14,7 +14,6 @@ var_dump(xml_set_start_namespace_decl_handler( $parser, "Namespace_Start_Handler
var_dump(xml_set_end_namespace_decl_handler( $parser, "Namespace_End_Handler" ));

xml_parse( $parser, $xml, true);
xml_parser_free( $parser );

echo "Done\n";

Expand Down

1 change: 1 addition & 0 deletions
ext/xml/xml.stub.php

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -189,6 +189,7 @@ function xml_get_current_column_number(XMLParser $parser): int {}

function xml_get_current_byte_index(XMLParser $parser): int {}

#[\Deprecated(since: '8.5', message: "as it has no effect since PHP 8.0")]
function xml_parser_free(XMLParser $parser): bool {}

/** @param string|int|bool $value */
Expand Down

11 changes: 9 additions & 2 deletions
ext/xml/xml_arginfo.h

View file


Open in desktop


Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.