Skip to content

Fix timelib 2022.16 sync - #21206

Closed
mvorisek wants to merge 2 commits into
php:PHP-8.4from
mvorisek:fix_timelib_84
Closed

Fix timelib 2022.16 sync#21206
mvorisek wants to merge 2 commits into
php:PHP-8.4from
mvorisek:fix_timelib_84

Conversation

@mvorisek

@mvorisekmvorisek commented Feb 12, 2026

Copy link
Copy Markdown
Contributor

detected using #19802

@mvorisek

mvorisek commented Feb 17, 2026

Copy link
Copy Markdown
ContributorAuthor

Can this sync fix be merged so I can work on the CI to prevent this in the future for master?

@mvorisek

Copy link
Copy Markdown
ContributorAuthor

@derickr can you please review?

@mvorisek

Copy link
Copy Markdown
ContributorAuthor

Can someone please review this PR?

int len = 0;

/* Skip over non-numeric chars */

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes are not reflected in ext/date/lib/parse_date.c. It's built with an ancient version of re2c that I don't have on my machine.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much ❤ for your comment, I am on this topic but for master as it will not be a bugfix, I will open another PR.

@mvorisek
mvorisek marked this pull request as draft May 28, 2026 13:26
@mvorisek
mvorisek deleted the fix_timelib_84 branch May 28, 2026 16:01
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@mvorisek@iluuu1994