Uh oh!
There was an error while loading. Please reload this page.
Drop generated timelib lexer files - #22170
Conversation
iluuu1994
commented
May 29, 2026
Can a RM (e.g. @edorian or @DanielEScherzer) confirm whether this needs changes in the release process? I think there are some manual steps involved for generating the language parser files. Maybe this would need to be added to some docs. |
I think this would need a change, but not tested yet But what if instead, we just kept the generated files in this repo, and updated the github tests that make sure generated files are up to date to include these files too? |
iluuu1994
commented
Jun 1, 2026
The output of re2c is bound to change in the future, so I personally think it's better to do this as a build step, especially given re2c is already a dependency for builds from source (from GH at least). |
mvorisek
commented
Jun 1, 2026
There are many The integration is done using Other (and last) integration is done using I have verified after |
mvorisek
commented
Jun 9, 2026
@DanielEScherzer can you please test and tell if anything needs to change? |
derickr
commented
Jun 10, 2026
FWIW, I would object to this. These files must be generated with the right |
iluuu1994
commented
Jun 11, 2026
Hmm, hard dependencies on ancient re2c versions does not sound like a good thing. |
based on #21206 (comment)
The
ext/date/lib/parse_date.candext/date/lib/parse_iso_intervals.cfiles are generated from their.refiles.The C files are newly generated like other lexer files for json, phar... This unifies the build process and simplifies upstream updates, patches...