Uh oh!
There was an error while loading. Please reload this page.
Implement "Followup improvements for ext/uri" RFC - URI type detection - #22075
Merged
Conversation
kocsismate
commented
May 17, 2026
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
TimWolla
approved these changes
May 23, 2026
TimWolla
left a comment
Member
There was a problem hiding this comment.
LGTM, but the lexbor changes need to be extracted first.
kocsismate
commented
May 23, 2026
MemberAuthor
kocsismate added a commit
that referenced
this pull request
May 24, 2026
It's needed to implement #22075 for https://wiki.php.net/rfc/uri_followup#uri_type_detection. Since the upstream changes to lexbor (lexbor/lexbor#362) haven't been released yet, a patch is added for now.
Co-authored-by: Tim Düsterhus <timwolla@googlemail.com>
TimWolla
approved these changes
May 24, 2026
TimWolla
commented
May 24, 2026
Member
Don't forget NEWS/UPGRADING. |
[skip ci]
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC: https://wiki.php.net/rfc/uri_followup#uri_type_detection