Skip to content

Cherry-pick https://github.com/lexbor/lexbor/commit/9181fce - #22093

Merged
kocsismate merged 1 commit into
php:masterfrom
kocsismate:lexbor-update2
May 24, 2026
Merged

Cherry-pick https://github.com/lexbor/lexbor/commit/9181fce#22093
kocsismate merged 1 commit into
php:masterfrom
kocsismate:lexbor-update2

Conversation

@kocsismate

Copy link
Copy Markdown
Member

Updating lexbor for #22075

@kocsismatekocsismate changed the title Cherry-pick https://github.com/lexbor/lexbor/commit/9181fce509ab9b37c02994545f3971687433e770Cherry-pick https://github.com/lexbor/lexbor/commit/9181fceMay 19, 2026
@iluuu1994

Copy link
Copy Markdown
Member

Generally, updates should be done via https://github.com/php/php-src/blob/master/ext/lexbor/patches/update-lexbor.sh now. I think this should either get a patch, or we should update to the given version. Especially if for master only.

@kocsismate

Copy link
Copy Markdown
MemberAuthor

@iluuu1994 Unfortunately, the required change has not been released yet. Thanks for highlighting the script, it was very difficult (for me at least) to update lexbor before. Are you OK if I go with the cherry-pick for now?

@iluuu1994

Copy link
Copy Markdown
Member

Any reason why this can't be added as a patch then? A future update would remove the change, though at least it would be obvious with a compiler error.

@kocsismate
kocsismateforce-pushed the lexbor-update2 branch 2 times, most recently from 08a255d to 07d71e7CompareMay 22, 2026 20:24
@kocsismate
kocsismate requested a review from iluuu1994May 23, 2026 21:08
@kocsismate
kocsismate merged commit 27d7b79 into php:masterMay 24, 2026
18 of 19 checks passed
@kocsismate
kocsismate deleted the lexbor-update2 branch May 24, 2026 20:37
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@kocsismate@iluuu1994@TimWolla@ndossche