Mysqli warning promotion by Girgias · Pull Request #5803 · php/php-src

Girgias · 2020-07-03T14:58:15Z

I will split this extension into multiple PRs as it's already starting to become rather large.

kocsismate · 2020-09-13T09:34:56Z

I think a few the is missing from this message. :) I would say The number of elements in the type definition string doesn't match the number of bind variables, but maybe it's too much now (?). Otherwise, you could say argument #2 (...) instead of type definition string.

Besides, you could use the ... must match the number of bind variables format, which is the most common wording we use (rather than ... doesn't match ...).

kocsismate · 2020-09-13T09:40:24Z

Yes, I do think it makes sense to forbid this case. The other PR handles this though.

nikic · 2020-09-15T09:09:26Z

Suggested change
zend_throw_error(NULL, "Function cannot be used with MYSQL_USE_RESULT");
zend_throw_error(NULL, "mysqli_data_seek() cannot be used with MYSQL_USE_RESULT");
etc.

I have suggested a PR for this error. I believe the constant should be MYSQLI_USE_RESULT

Right, this should be MYSQLI_USE_RESULT.

I still think the message I suggested is better "cannot be used in MYSQLI_USE_RESULT mode". The constant describes result mode. You don't use the function with this constant but rather your result is in one or the other mode.

You can address this in your PR, I just want to get done with this one at this point ^^"

nikic · 2020-09-15T15:47:15Z

ext/opcache/tests/func_info.phpt is failing due to outdated zend_func_info.c.

nikic · 2020-09-15T16:37:51Z

 	F1("mysqli_real_escape_string", MAY_BE_STRING),
 	F1("mysqli_stmt_affected_rows", MAY_BE_LONG | MAY_BE_STRING),
-	F0("mysqli_stmt_data_seek", MAY_BE_NULL | MAY_BE_FALSE),
+	F0("mysqli_stmt_data_seek", MAY_BE_NULL),


You can just drop the line completely now.

carusogabriel added the Warning promotion label Jul 3, 2020

kocsismate reviewed Jul 3, 2020
View reviewed changes

Comment threadext/mysqli/mysqli_api.c Outdated
Comment threadext/mysqli/mysqli_api.c Outdated

Girgias force-pushed the mysqli-warning-promotion branch 9 times, most recently from d1d1ac2 to 6131745Compare July 9, 2020 18:04

Girgias force-pushed the mysqli-warning-promotion branch 2 times, most recently from f5e67f1 to 777f11cCompare July 20, 2020 12:49

Girgias changed the title ~~Mysqli warning promotion part 1~~Mysqli warning promotionJul 20, 2020

kocsismate reviewed Aug 1, 2020
View reviewed changes

Comment threadext/mysqli/mysqli_nonapi.c Outdated

Girgias force-pushed the mysqli-warning-promotion branch from 777f11c to 99ac5b7Compare August 3, 2020 01:48

Girgias mentioned this pull request Aug 13, 2020
Warning to Error (TypeError/ValueError) in extensions php/php-tasks#18
Closed
71 tasks

Girgias force-pushed the mysqli-warning-promotion branch 3 times, most recently from d86e165 to 67e6b6aCompare August 23, 2020 22:10

Girgias force-pushed the mysqli-warning-promotion branch 4 times, most recently from 4d53fdc to 1e66bebCompare September 9, 2020 22:36

Girgias force-pushed the mysqli-warning-promotion branch 3 times, most recently from 26cdc04 to 15f2f4bCompare September 13, 2020 01:15

kocsismate reviewed Sep 13, 2020
View reviewed changes

Girgias force-pushed the mysqli-warning-promotion branch 2 times, most recently from 4b52075 to 717d1fdCompare September 14, 2020 00:58

nikic reviewed Sep 14, 2020
View reviewed changes

Girgias force-pushed the mysqli-warning-promotion branch from c9b011c to 0c4501dCompare September 14, 2020 16:43

nikic reviewed Sep 15, 2020
View reviewed changes

Girgias force-pushed the mysqli-warning-promotion branch from 0c4501d to e096674Compare September 15, 2020 13:52

Girgias added 11 commits September 15, 2020 17:51

Warning to Error promotion in MySQLi extension
e131a7e

Improve errors for mysqli_stmt_attr_set()
cb4598c

Debug output
da7904d

Nit from review
9f6aead

Fix stubs param name
48be020

Address review comments
465a121

Maybe it's attr_get() messing stuff
0ba8865

Fix Linux now
5049bd3

Address reviews
ba93066

Nits
7dd2cd3

Fix OpCache
8a81c50

Girgias force-pushed the mysqli-warning-promotion branch from e096674 to 8a81c50Compare September 15, 2020 15:53

Nit: Use MYSQLI_USE_RESULT
85ab28b

nikic approved these changes Sep 15, 2020
View reviewed changes

php-pulls closed this in 7a95e94Sep 15, 2020

Girgias deleted the mysqli-warning-promotion branch September 15, 2020 17:14

Girgias mentioned this pull request Sep 15, 2020
Pr/5803 #6122
Closed

morozov mentioned this pull request Sep 27, 2020
MySQLi tests fail on PHP nightly doctrine/dbal#4306
Closed

	zend_throw_error(NULL, "Function cannot be used with MYSQL_USE_RESULT");
	zend_throw_error(NULL, "mysqli_data_seek() cannot be used with MYSQL_USE_RESULT");

Uh oh!

Conversation

Girgias commented Jul 3, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nikic commented Sep 15, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants