Uh oh!
There was an error while loading. Please reload this page.
Pr/5803 - #6122
Closed
kamil-tekiela wants to merge 16 commits into
Closed
Conversation
This reverts commit 8d4d181471b787dee8e05f9413add735dfe9d68d.
This reverts commit d4bbbbeaa7c7512d4deae4b1f2f155146fb70435.
Member
@kamil-tekiela It would be much better if you could start your branch from master, not from George's PR. UPDATE: Although, most probably you based your work on the existing PR in order to avoid conflicts and be able to use the |
After GitHub discussion I came to conclusion that it is better to let the function fail silently rather than throw an error. `mysqli_fetch_field_direct` is used mostly with `SELECT *`. In my opinion an exception would still be smart choice but it might not be the right time for this change.
Girgias
commented
Sep 15, 2020
Member
Can you rebase now that I've merged #5803 ? |
kamil-tekiela
commented
Sep 15, 2020
MemberAuthor
PR recreated under #6137 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switched warnings to exceptions for:
mysqli_data_seekmysqli_fetch_field_directmysqli_field_seekmysqli_num_rows