Skip to content

Enhancement: Use phpunit/phpunit to run tests - #605

Merged
derickr merged 1 commit into
php:masterfrom
localheinz:feature/phpunit
Feb 12, 2024
Merged

Enhancement: Use phpunit/phpunit to run tests#605
derickr merged 1 commit into
php:masterfrom
localheinz:feature/phpunit

Conversation

@localheinz

@localheinzlocalheinz commented Jul 3, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request

  • uses phpunit/phpunit to run tests

💁‍♂️ Similar to #559, you can see this in action in localheinz#2.

@localheinz
localheinzforce-pushed the feature/phpunit branch 5 times, most recently from 0759dae to 95db30eCompareJuly 3, 2022 11:24
@localheinzlocalheinz mentioned this pull request Jul 3, 2022
Merged
@cmb69

cmb69 commented Jul 3, 2022

Copy link
Copy Markdown
Member

I'm not sure whether we should use PHPUnit; that's yet another third-party dependency, and it seems that PHPTs may be sufficient (at least for a while). The nice thing is that these also can be run with PHPUnit, what is especially interesting wrt. code coverage reporting.

@localheinz

localheinz commented Jul 3, 2022

Copy link
Copy Markdown
ContributorAuthor

@cmb69

phpunit/phpunit is the de facto industry standard for testing PHP code. I believe it is time to start using select dependencies.

@cmb69cmb69 mentioned this pull request Jul 3, 2022
Merged
@localheinz

localheinz commented Jul 3, 2022

Copy link
Copy Markdown
ContributorAuthor

Closing in favour of #606 and cmb69#1.

@localheinz
localheinz deleted the feature/phpunit branch July 3, 2022 13:50
@localheinz
localheinz restored the feature/phpunit branch December 11, 2023 15:38
@localheinzlocalheinz reopened this Dec 11, 2023
@localheinz
localheinz marked this pull request as draft December 11, 2023 15:38
@localheinzlocalheinz changed the title Enhancement: Run phpunit/phpunit on GitHub ActionsEnhancement: Use phpunit/phpunit to run testsDec 11, 2023
@github-actions

github-actionsBot commented Dec 11, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Commit ff36297 Deployed on https://web-php-pr-605.preview.thephp.foundation

@localheinz
localheinzforce-pushed the feature/phpunit branch 2 times, most recently from 62de7be to 8f93328CompareDecember 11, 2023 16:19
@github-actions

github-actionsBot commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@github-actions

github-actionsBot commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@localheinz
localheinzforce-pushed the feature/phpunit branch 2 times, most recently from a7a6791 to 01dffd8CompareDecember 11, 2023 16:21
@github-actions

github-actionsBot commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

1 similar comment
@github-actions

github-actionsBot commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@github-actions

github-actionsBot commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

1 similar comment
@github-actions

github-actionsBot commented Dec 11, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-605.preview.thephp.foundation

@localheinz
localheinz marked this pull request as ready for review December 11, 2023 16:22
@localheinz

localheinz commented Dec 11, 2023

Copy link
Copy Markdown
ContributorAuthor

@cmb69@kamil-tekiela

I have reopened this pull request because I believe we are at a point where we would benefit from using phpunit/phpunit.

What do you think?

@localheinzlocalheinz mentioned this pull request Dec 14, 2023
Merged
1 task
@derickr
derickr merged commit f24c916 into php:masterFeb 12, 2024
@localheinz
localheinz deleted the feature/phpunit branch February 12, 2024 17:42
@localheinz

localheinz commented Feb 12, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you, @cmb69, @derickr, and @saundefined!

@localheinzlocalheinz mentioned this pull request Feb 12, 2024
Merged
1 task
@TomasVotruba

TomasVotruba commented Feb 13, 2024

Copy link
Copy Markdown

Thank you @localheinz for great improvement 👏

This was referenced Feb 13, 2024
Merged
Merged
Merged
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@localheinz@cmb69@TomasVotruba@derickr@saundefined