Skip to content

Enhancement: Run end-to-end tests asserting an HTTP response status code - #900

Merged
saundefined merged 1 commit into
php:masterfrom
localheinz:feature/end-to-end
Jan 23, 2024
Merged

Enhancement: Run end-to-end tests asserting an HTTP response status code#900
saundefined merged 1 commit into
php:masterfrom
localheinz:feature/end-to-end

Conversation

@localheinz

@localheinzlocalheinz commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request

  • runs end-to-end tests asserting an HTTP response status code

Also see #605.

@github-actions

github-actionsBot commented Dec 14, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

🚀 Commit d8fdb48 Deployed on https://web-php-pr-900.preview.thephp.foundation

localheinz
localheinz commented Dec 14, 2023
View reviewed changes
Comment threadtests/server

@localheinzlocalheinzDec 14, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I copied this file from https://github.com/cubny/php-built-in-server-manager/blob/9a5cbeaad50a108d6058b882b83ba23fbd7722a9/server.

If someone wants to write their own, I'll be happy to copy it.

@github-actions

github-actionsBot commented Dec 14, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation

localheinz
localheinz commented Dec 14, 2023
View reviewed changes
Comment threadtests/EndToEnd/ChangeLog-4.php-returns-http-response-status-code-200.phpt Outdated
@localheinz
localheinz marked this pull request as ready for review December 14, 2023 16:17
@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-900.preview.thephp.foundation

@localheinzlocalheinz mentioned this pull request Dec 15, 2023
Merged
1 task
@pronskiy

pronskiy commented Dec 19, 2023

Copy link
Copy Markdown
Member

@localheinz I tried adding trigger_error('Message', E_USER_ERROR); in search.php (or any other page) and the tests passed green. Is that expected behavior?

@localheinz

localheinz commented Dec 22, 2023

Copy link
Copy Markdown
ContributorAuthor

@pronskiy

I tried adding trigger_error('Message', E_USER_ERROR); in search.php (or any other page) and the tests passed green. Is that expected behavior?

With 48a8881 and running

php -S localhost:8080 .router.php

I can see the following output in the console:

[Fri Dec 22 15:21:47 2023] [::1]:49172 Accepted[Fri Dec 22 15:21:47 2023] PHP Fatal error: Message in /Users/am/Sites/php/web-php/search.php on line 12[Fri Dec 22 15:21:47 2023] [::1]:49172 [200]: GET /search.php?show=quickref&pattern= - Message in /Users/am/Sites/php/web-php/search.php on line 12[Fri Dec 22 15:21:47 2023] [::1]:49172 Closing[Fri Dec 22 15:21:47 2023] [::1]:49173 Accepted[Fri Dec 22 15:21:47 2023] [::1]:49173 [200]: GET /favicon.ico[Fri Dec 22 15:21:47 2023] [::1]:49173 Closing

With 48a8881, the tests fail on GitHub Actions, see https://github.com/php/web-php/actions/runs/7300886487/job/19896408958?pr=900.

I do not know why they pass locally and fail on GitHub Actions, but I assume it has something to do with the configuration of PHP.

@localheinz
localheinzforce-pushed the feature/end-to-end branch 3 times, most recently from a2a8c42 to 30c8014CompareDecember 22, 2023 16:32
localheinz
localheinz commented Dec 22, 2023
View reviewed changes
Comment threadtests/php.ini
@@ -0,0 +1,3 @@
[PHP]

display_errors = Off

@localheinzlocalheinzDec 22, 2023

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pronskiy

According to https://stackoverflow.com/a/28974224/1172545, this should help!

pronskiy
pronskiy reviewed Jan 15, 2024
View reviewed changes
Comment threadtests/EndToEnd/paths-return-http-response-status-code-200.phpt Outdated
@pronskiy

pronskiy commented Jan 15, 2024

Copy link
Copy Markdown
Member

@localheinz with the php.ini it works now 🙏

@localheinz
localheinzforce-pushed the feature/end-to-end branch 4 times, most recently from 57f79e0 to a18982fCompareJanuary 22, 2024 13:22
saundefined
saundefined approved these changes Jan 23, 2024
View reviewed changes

@saundefinedsaundefined left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@saundefined
saundefined merged commit d162fe4 into php:masterJan 23, 2024
@localheinz
localheinz deleted the feature/end-to-end branch January 23, 2024 09:59
@localheinz

localheinz commented Jan 23, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you, @pronskiy, @saundefined, and @sy-records!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pronskiypronskiypronskiy left review comments
@saundefinedsaundefinedsaundefined approved these changes
@sy-recordssy-recordssy-records approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@localheinz@pronskiy@saundefined@sy-records