Uh oh!
There was an error while loading. Please reload this page.
Enhancement: Enable indentation_type fixer - #622
Conversation
7b5ee9f to
5c6fee1Compare
cmb69
left a comment
There was a problem hiding this comment.
Thank you for the PR! Looks good to me.
I'm fine with using four spaces indent instead of tabs, and generally fine with transitioning to PSR-12 (which is likely one of the most common coding standards for PHP OSS projects).
localheinz
commented
Jul 11, 2022
I believe that the specifics of a coding standard do not matter as long as they can be enforced automatically! |
cmb69
commented
Jul 11, 2022
Right! I should have added: ", so we hopefully all can agree on using PSR-12". I wouldn't want to discuss any single rule individually, but rather get this mess somewhat cleaned up. :) |
localheinz
commented
Jul 11, 2022
9739bef to
b0ddb28Compared9aebea to
252401cComparelocalheinz
commented
Jul 11, 2022
Rebased! |
localheinz
commented
Jul 11, 2022
Thank you, @cmb69! |
This pull request
indentation_typefixermake coding-standardsFollows #559.
💁♂️ For reference, see https://github.com/FriendsOfPHP/PHP-CS-Fixer/blob/v3.4.0/doc/rules/whitespace/indentation_type.rst.