Skip to content

Enhancement: Enable PSR12 rule set - #638

Closed
localheinz wants to merge 2 commits into
php:masterfrom
localheinz:feature/psr-12
Closed

Enhancement: Enable PSR12 rule set#638
localheinz wants to merge 2 commits into
php:masterfrom
localheinz:feature/psr-12

Conversation

@localheinz

@localheinzlocalheinz commented Jul 11, 2022

Copy link
Copy Markdown
Contributor

This pull request

  • enables the PSR12 rule set
  • runs make coding-standards

Follows #559.

@localheinz
localheinz marked this pull request as ready for review July 11, 2022 17:42
@localheinz
localheinzforce-pushed the feature/psr-12 branch 3 times, most recently from 7a7e7a9 to 0c8dfe6CompareJuly 11, 2022 17:47
@localheinz

Copy link
Copy Markdown
ContributorAuthor

@cmb69

I think this does not work very well:

  • changes are hard to review
  • mixing PHP code and HTML code is something that is not officially supported by friendsofphp/php-cs-fixer

When enabling fixers one by one, we have more control.

@localheinz
localheinz marked this pull request as draft July 11, 2022 18:08
@localheinz
localheinz marked this pull request as draft July 11, 2022 18:08
@cmb69

Copy link
Copy Markdown
Member

Yes, I have to agree!

@cmb69cmb69 closed this Jul 11, 2022
@localheinz
localheinz deleted the feature/psr-12 branch July 11, 2022 18:17
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@localheinz@cmb69