Skip to content

Fix: Do not pass null to function that expects string - #901

Merged
saundefined merged 1 commit into
php:masterfrom
localheinz:fix/null
Feb 12, 2024
Merged

Fix: Do not pass null to function that expects string#901
saundefined merged 1 commit into
php:masterfrom
localheinz:fix/null

Conversation

@localheinz

@localheinzlocalheinz commented Dec 15, 2023•
edited
Loading

Copy link
Copy Markdown
Contributor

This pull request

  • stops passing null to a function that expects string

Spotted in #900.

💁‍♂️ In the first iteration of the inner foreach-loop, $version is null:

web-php/include/version.inc

Lines 85 to 89 in e1c6168

$version = null;
$current = null;
foreach ($RELEASESas$versions) {
foreach ($versionsas$ver => $info) {
if (version_compare($ver, $version) > 0) {

@github-actions

github-actionsBot commented Dec 15, 2023

Copy link
Copy Markdown
Contributor

🚀 Deployed on https://web-php-pr-901.preview.thephp.foundation

saundefined
saundefined approved these changes Feb 12, 2024
View reviewed changes

@saundefinedsaundefined left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@saundefined
saundefined merged commit 026b509 into php:masterFeb 12, 2024
@localheinz
localheinz deleted the fix/null branch February 12, 2024 17:18
@localheinz

localheinz commented Feb 12, 2024

Copy link
Copy Markdown
ContributorAuthor

Thank you, @saundefined!

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saundefinedsaundefinedsaundefined approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@localheinz@saundefined