Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Support multi-select pending user inputs - #1797

Merged
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix
Apr 6, 2026
Merged

Support multi-select pending user inputs#1797
juliusmarminge merged 1 commit into
mainfrom
t3code/questionnaire-multiselect-fix

Conversation

@juliusmarminge

@juliusmarmingejuliusmarminge commented Apr 6, 2026

Copy link
Copy Markdown
Member

Summary

  • Add multiSelect support to Codex user-input questions and carry it through server/web parsing.
  • Update pending-user-input state to track multiple selected option labels, including toggle behavior and answer resolution.
  • Adjust composer UI and keyboard handling so multi-select questions stay open until the user advances, while single-select questions keep auto-advance.
  • Expand tests to cover multi-select answer building, progress derivation, adapter parsing, and browser interaction flows.

Testing

  • bun fmt
  • bun lint
  • bun typecheck
  • bun run test

Note

Medium Risk
Changes user-input question/answer shape to support multi-select, including different answer types (string vs string[]) and updated UI selection behavior; regressions could affect responding to prompts or keyboard shortcuts in the chat composer.

Overview
Adds end-to-end multiSelect support for pending user-input questions: server adapters/session parsing now preserve a multiSelect flag, and the web client can submit multi-select answers as arrays.

Updates pending user-input state and UI to track multiple selected option labels with toggle semantics, disables auto-advance for multi-select questions (single-select still auto-advances), and tightens numeric shortcut handling to avoid firing while the composer/contenteditable is focused.

Expands unit and browser tests to cover multi-select parsing, selection toggling, progress/answer resolution, and submission payloads.

Reviewed by Cursor Bugbot for commit 0ab01a7. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add multi-select support to pending user input questions

  • Adds a multiSelect flag to user input question types in both pendingUserInput.ts and session-logic.ts, parsed from the activity payload.
  • Replaces selectedOptionLabel: string with selectedOptionLabels: string[] throughout the pending user input data model to support multiple selections uniformly.
  • Introduces togglePendingUserInputOptionSelection to toggle option state; multi-select questions accumulate selections while single-select questions replace them.
  • Multi-select questions no longer auto-advance after an option is chosen; number key shortcuts (1–9) are blocked when focus is inside editable fields.
  • resolvePendingUserInputAnswer returns string[] for multi-select questions and string for single-select; buildPendingUserInputAnswers propagates arrays in the final answers map.
  • Behavioral Change: answer state shape changes from a single string to an array; any code reading selectedOptionLabel directly will break.

Macroscope summarized 0ab01a7.

- Preserve question multi-select metadata end to end
- Toggle option selections in the composer and submit arrays
- Cover keyboard and answer-building behavior with tests
@github-actionsgithub-actionsBot added size:L 100-499 changed lines (additions + deletions). vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. labels Apr 6, 2026
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Needs human review

This PR introduces a new multi-select capability for user input questions, changing data structures from single to array-based selection and adding new toggle behavior. While well-tested and self-contained, it represents new user-facing functionality with runtime behavior changes that warrants human review.

You can customize Macroscope's approvability policy. Learn more.

@juliusmarminge
juliusmarminge merged commit 11d456f into mainApr 6, 2026
11 checks passed
@juliusmarminge
juliusmarminge deleted the t3code/questionnaire-multiselect-fix branch April 6, 2026 23:08
rororowyourboat added a commit to rororowyourboat/t3code that referenced this pull request Apr 9, 2026
…threadId (#2)
* Raise slow RPC ack warning threshold to 15s (pingdotgg#1760)
* Use active worktree path for workspace saves (pingdotgg#1762)
* Stream git status updates over WebSocket (pingdotgg#1763)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(web): unwrap windows shell command wrappers (pingdotgg#1719)
* Rename "Chat" to "Build" in interaction mode toggle (pingdotgg#1769)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Assign default capabilities to Codex custom models (pingdotgg#1793)
* Add project rename support in the sidebar (pingdotgg#1798)
* Support multi-select pending user inputs (pingdotgg#1797)
* Add Zed support to Open actions via editor command aliases (pingdotgg#1303)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius0216@outlook.com>
* Closespingdotgg#1795 - Support building and developing in a devcontainer (pingdotgg#1791)
* Add explicit timeouts to CI and release workflows (pingdotgg#1825)
* fix(web): distinguish singular/plural in pending action submit label (pingdotgg#1826)
* Refactor web stores into atomic slices ready to split ChatView (pingdotgg#1708)
* Add VSCode Insiders and VSCodium icons (pingdotgg#1847)
* Prepare datamodel for multi-environment (pingdotgg#1765)
Co-authored-by: justsomelegs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Implement server auth bootstrap and pairing flow (pingdotgg#1768)
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
* Use dev proxy for loopback auth and environment requests (pingdotgg#1853)
* Refresh local git status on turn completion (pingdotgg#1821)
Co-authored-by: codex <codex@users.noreply.github.com>
* fix(desktop): add Copy Link action for chat links (pingdotgg#1835)
* fix: map runtime modes to correct permission levels (pingdotgg#1587)
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
* Fix persisted composer image hydration typo (pingdotgg#1831)
* Clarify environment and workspace picker labels (pingdotgg#1854)
* Scope git toast state by thread ref (pingdotgg#1855)
* fix build (pingdotgg#1859)
* Stabilize keybindings toast stream setup (pingdotgg#1860)
Co-authored-by: Julius Marminge <julius@macmini.local>
* feat(web): add embeddable thread route for canvas tile hosts
Adds /embed/thread/:environmentId/:threadId — a standalone route that
renders the existing ChatView without the app sidebar chrome. This is the
iframe target for t3-canvas agent shapes (see rororowyourboat/t3-canvas#3).
- New file-based route embed.thread.\$environmentId.\$threadId.tsx
- __root.tsx bypasses AppSidebarLayout for any /embed/* pathname so the
environment connection + websocket surface + toasts still initialize
but the sidebar/diff/plan chrome does not render
- minimal=1 search param is parsed and wired to a data attribute on the
container for future targeted CSS; chrome hiding (BranchToolbar,
PlanSidebar, ThreadTerminalDrawer) stays as a follow-up pass
- routeTree.gen.ts regenerated by the @tanstack/router-plugin
---------
Co-authored-by: Julius Marminge <julius0216@outlook.com>
Co-authored-by: codex <codex@users.noreply.github.com>
Co-authored-by: legs <145564979+justsomelegs@users.noreply.github.com>
Co-authored-by: sonder <168988030+heysonder@users.noreply.github.com>
Co-authored-by: Adem Ben Abdallah <96244394+AdemBenAbdallah@users.noreply.github.com>
Co-authored-by: Kyle Gottfried <6462596+Spitfire1900@users.noreply.github.com>
Co-authored-by: Jacob <589761+jvzijp@users.noreply.github.com>
Co-authored-by: Cursor Agent <cursoragent@cursor.com>
Co-authored-by: cursor[bot] <206951365+cursor[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <julius@macmini.local>
Co-authored-by: Klemencina <56873773+Klemencina@users.noreply.github.com>
Co-authored-by: Oskar Sekutowicz <me.oski646@gmail.com>
Co-authored-by: Noxire <59626436+noxire-dev@users.noreply.github.com>
NeilTheFisher pushed a commit to NeilTheFisher/t3code that referenced this pull request Aug 18, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@juliusmarminge