Stabilize keybindings toast stream setup

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}

[juliusmarminge]

Summary

• Stabilizes the keybindings toast test by waiting for the server config update stream to be ready before asserting toast behavior.
• Replaces the previous warm-up helper with an explicit stream readiness check keyed off server config update notifications.
• Reduces flakiness by ensuring the subscription is actually delivering updates before the toast-triggering push is sent.

Testing

• Not run (PR content only).
• Existing test coverage updated in KeybindingsToast.browser.tsx to wait for stream readiness before exercising the toast flow.

---

Note

Low Risk
Low risk: changes only affect a browser-based Vitest test harness by adding an explicit readiness wait for the server config update stream, reducing flakiness without altering production behavior.

Overview
Stabilizes the KeybindingsToast.browser.tsx test setup by replacing the previous “warm up” push with an explicit waitForServerConfigStreamReady() gate.

The new helper repeatedly emits a settingsUpdated stream event and waits until getServerConfigUpdatedNotification() advances, ensuring the server-config subscription is actively delivering updates before sending keybindingsUpdated events and asserting toast counts.

^{Reviewed by Cursor Bugbot for commit 8a8f0d1. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Stabilize keybindings toast stream setup by polling server-config stream readiness

• Replaces warmServerConfigUpdateStream (which sent a push and waited 50ms) with waitForServerConfigStreamReady, which polls the server-config stream by emitting synthetic settingsUpdated events and verifying a new notification with a greater id is observed.
• mountApp now calls waitForServerConfigStreamReady after the server config snapshot, ensuring the stream can deliver updates before tests proceed.
• The keybinding update test no longer warms the stream explicitly, relying on mountApp's readiness check instead.
• Risk: waitForServerConfigStreamReady retries up to 20 times and throws on timeout, so flaky stream initialization will now cause an explicit test failure rather than a silent race.

^{Macroscope summarized 8a8f0d1.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: 55b16861-e730-4fc7-8f97-dfd672b9e87c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch t3code/fix-keybindings-toast-flake

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[macroscopeapp]

Approvability

Verdict: Approved

This is a test-only change that improves test stability by replacing a simple timeout-based warmup with a more robust retry-based verification that the server config stream is ready. No production runtime behavior is affected.

^{You can customize Macroscope's approvability policy. Learn more.}