Uh oh!
There was an error while loading. Please reload this page.
Use latest user message time for thread timestamps - #1996
Conversation
- Show thread timestamps from `latestUserMessageAt` when available - Compare nested session and turn objects by value to avoid stale sidebar state
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Sidebar summary never written for full thread updates
- Restored the removed block in writeThreadState that builds a SidebarThreadSummary via buildSidebarThreadSummary and conditionally writes it to sidebarThreadSummaryById when the derived summary has changed.
Or push these changes by commenting:
@cursor push b8d786d2fc
Preview (b8d786d2fc)
diff --git a/apps/web/src/store.ts b/apps/web/src/store.ts--- a/apps/web/src/store.ts+++ b/apps/web/src/store.ts@@ -519,6 +519,8 @@
const nextTurnState = toThreadTurnState(nextThread);
const previousShell = state.threadShellById[nextThread.id];
const previousTurnState = state.threadTurnStateById[nextThread.id];
+ const previousSummary = state.sidebarThreadSummaryById[nextThread.id];+ const nextSummary = buildSidebarThreadSummary(nextThread);
let nextState = state;
@@ -652,6 +654,16 @@
};
}
+ if (!sidebarThreadSummariesEqual(previousSummary, nextSummary)) {+ nextState = {+ ...nextState,+ sidebarThreadSummaryById: {+ ...nextState.sidebarThreadSummaryById,+ [nextThread.id]: nextSummary,+ },+ };+ }+
return nextState;
}
@@ -718,7 +730,9 @@
};
}
- if (!threadSessionsEqual(state.threadSessionById[nextThread.shell.id] ?? null, nextThread.session)) {+ if (+ !threadSessionsEqual(state.threadSessionById[nextThread.shell.id] ?? null, nextThread.session)+ ) {
nextState = {
...nextState,
threadSessionById: {You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 0bb7044. Configure here.
| }, | ||
| }; | ||
| } | ||
There was a problem hiding this comment.
Sidebar summary never written for full thread updates
High Severity
The writeThreadState function no longer writes to sidebarThreadSummaryById, but it's the sole write path for many thread events. When a thread.created event fires, the thread ID is added to threadIds and other structures, but no sidebarThreadSummaryById entry is created. Since selectSidebarThreadsForProjectRef filters out threads without a sidebar summary entry, newly created threads won't appear in the sidebar until a separate thread-upserted shell event arrives. Similarly, all event-driven updates (thread.message-sent, thread.archived, session-set, etc.) via updateThreadState → writeThreadState won't update the sidebar's latestUserMessageAt, hasPendingApprovals, or other derived fields — the very fields this PR aims to leverage.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 0bb7044. Configure here.
ApprovabilityVerdict: Needs human review This PR combines a minor timestamp display change with a substantial refactor of thread state management in store.ts, including removal of syncServerReadModel and ~300 lines of related tests. An unresolved high-severity review comment identifies that the refactor may cause newly created threads to not appear in the sidebar until a separate shell event arrives, directly impacting the feature this PR aims to implement. You can customize Macroscope's approvability policy. Learn more. |
- Use refs to avoid invalidating sidebar row callbacks - Keep relative timestamps at "just now" under 60 seconds - Add React Scan script to the web shell
Uh oh!
There was an error while loading. Please reload this page.
- Keep thread timestamp formatting aligned in the sidebar and command palette - Reflow a long store condition for readability
- Delete the unpkg react-scan script from `apps/web/index.html` - Keep the app shell lean for production
- Share bookkeeping for thread IDs and project membership across shell and detail writes - Remove read-model sync and unused sidebar selector plumbing - Keep shell data authoritative for sidebar summaries
Uh oh!
There was an error while loading. Please reload this page.
- Split upstream pingdotgg#1996 into two ledger entries for the two MarCode PRs that port it: PR #69 (sidebar row timestamp behavioral fix, 524e93a) and PR #70 (store.ts shell-stream-authority correctness refactor, 506b808). - Remove "NOT yet equivalent" note in the Already-equivalent section now that both halves are ported. - Drop pingdotgg#1996 from Pending real work; only pingdotgg#2246 remains. - Add plan-file pointer (/Users/tyulyukov/.claude/plans/cached-napping-sundae.md) to the pingdotgg#2246 row so the next cycle's porter has the staged-commit strategy. Corrects the earlier claim that pingdotgg#1996's store.ts refactor was "cleanup with no behavioral delta" — it's a real correctness fix aligning MarCode with the stream-separation contract MEMORY.md already requires.
…atest-user-msg feat(sidebar): latestUserMessageAt for thread row timestamp (upstream pingdotgg#1996)
- Record PR #68 (cycle ledger bootstrap), #69 (upstream pingdotgg#1996 sidebar timestamp), and #71 (upstream pingdotgg#2246 option-array refactor) under the current cycle's ported set, with deviation notes for pingdotgg#2246. - Document the post-merge composerDraftStore hotfix (9a8c78f) and its regression guard. - Record the Phase 4 real-DB smoke: 0 legacy `$.options` rows across projection_threads, projection_projects, and orchestration_events; 155 canonical thread rows. - Move pingdotgg#1996 and pingdotgg#2246 out of "Pending real work" — no real work outstanding as of 2026-04-24. - Advance "Baseline after cycle" to ececcdc (the #71 merge SHA).
…e-store-refactor fix(store): enforce shell-stream authority for sidebar summary flags (upstream pingdotgg#1996)
Summary
latestUserMessageAtso threads reflect the most recent user activity.Testing
bun fmt,bun lint,bun typecheck, andbun run test.Note
Medium Risk
Moderate risk because it refactors store update paths and equality checks for thread shell/session/turn state, which could affect re-render behavior and sidebar consistency across shell vs detail streams.
Overview
Thread timestamps in the sidebar and command palette now prefer
latestUserMessageAt(falling back toupdatedAt/createdAt) so recency reflects user activity.Sidebar context-menu actions (multi-select and per-thread) now read thread data via a
useRef-backed map to avoid stale captures and reduce memo invalidation.Store/state updates are tightened:
sidebarThreadSummaryByIdis now shell-stream-only (detail writes removed),syncServerReadModelis removed, and new structural equality helpers for sessions/turns reduce redundant state churn.formatRelativeTimealso treats anything under 60s as "just now".Reviewed by Cursor Bugbot for commit c26d203. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Use latest user message time for thread timestamps in sidebar and command palette
latestUserMessageAtwhen available, falling back toupdatedAtthencreatedAt.syncServerReadModelfrom the app store; sidebar summaries are now written exclusively by the shell stream, with deep structural equality checks reducing unnecessary state updates.archiveThreadand sidebar context menu actions are fixed using refs to hold the latest function/map values.Macroscope summarized c26d203.