fix(server): bound editor discovery latency

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}

[StiensWout]

Summary

• run editor availability probes concurrently instead of serializing every command lookup
• cap each editor probe at three seconds and keep successful partial results when another probe stalls
• preserve the configured editor order and add deterministic virtual-clock regression coverage

Root cause

server.getConfig waits for external editor discovery before returning its configuration snapshot. Editor discovery checked every configured editor sequentially, and every missing Windows command could traverse the full inherited PATH across all PATHEXT variants. Slow filesystem lookups therefore accumulated across the entire editor catalog and blocked provider statuses from reaching the client.

Impact

Optional editor detection can no longer block configuration indefinitely. Fast probes remain visible even when another editor lookup times out, allowing the Providers page and other configuration consumers to resolve within a bounded interval.

Validation

• pnpm exec vp test run apps/server/src/process/externalLauncher.test.ts (5 tests passed)
• pnpm exec vp lint --report-unused-disable-directives apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• pnpm exec vp run --filter t3 typecheck
• pnpm exec vp fmt --check apps/server/src/process/externalLauncher.ts apps/server/src/process/externalLauncher.test.ts
• isolated authenticated web verification: the Providers page rendered completed provider states; on Windows the editor discovery span completed in about 1.62 seconds while individual missing-command probes took about 1.5 seconds

Closes#4210

Current main compatibility

• based on 3c50a648
• focused regression tests and targeted package type checks passed
• targeted formatting and lint passed
• git diff --check passed

---

Note

Medium Risk
Changes timing and concurrency of editor detection used on config load; behavior shifts from exhaustive serial probes to bounded parallel races, which could omit editors on very slow disks but fixes indefinite blocking.

Overview
Editor discovery no longer blocks config indefinitely. Availability checks run in parallel across editors and command aliases (via Effect.raceAll / unbounded forEach), and each probe is capped at 3 seconds with Effect.timeoutOption so slow or stuck PATH lookups are dropped while faster hits still appear in order.

ExternalLauncher gains makeWithOptions so tests can stub command availability and discovery timeout; production still defaults to isCommandAvailable. Launch resolves the first responsive alias the same way instead of walking commands serially.

New tests cover responsive fallback aliases (e.g. zed → zeditor) and TestClock regression that partial editor lists survive when other probes never complete.

^{Reviewed by Cursor Bugbot for commit 5c8af7c. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound editor discovery latency by probing aliases concurrently with a 3-second timeout

• Editor discovery in externalLauncher.ts now probes all editors concurrently instead of sequentially, applying a per-editor timeout (default 3 seconds) and returning partial results for editors that resolved in time.
• For multi-alias editors (e.g. zed/zeditor), the selected command is now the first alias whose availability check resolves, rather than using a fixed order.
• A new makeWithOptions factory allows injecting a custom editorCommandAvailability function and editorDiscoveryTimeout, used by tests to control probe timing.
• Behavioral Change: editors whose availability probes never complete (e.g. hung filesystem checks) are now silently dropped from results after the timeout rather than blocking discovery indefinitely.

^{Macroscope summarized 5c8af7c.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d785e1c1-479f-470e-a6aa-3887c4108d46

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Needs human review

This PR changes editor discovery from sequential to concurrent with timeouts, which is a significant behavioral change affecting which editor gets selected when multiple are available. The algorithm change (race-based vs. ordered iteration) and its user-facing implications warrant human review.

^{You can customize Macroscope's approvability policy. Learn more.}