Uh oh!
There was an error while loading. Please reload this page.
fix(server): keep installed editors visible when discovery times out - #4956
fix(server): keep installed editors visible when discovery times out#4956eeinarsson wants to merge 1 commit into
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Needs human review This PR introduces new timeout handling, caching, and retry logic for editor discovery - significant runtime behavior changes. An unresolved review comment identifies that retry failures in the discovery stream could terminate the entire config subscription, which warrants human review. You can customize Macroscope's approvability policy. Learn more. |
8c9c656 to
feb5302CompareThere was a problem hiding this comment.
One finding on Effect dependency acquisition: the new Windows discovery path reads process.env directly instead of the HostProcessEnvironment reference already used elsewhere in this module.
Posted via Macroscope — Effect Service Conventions
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
e058e19 to
8c0a223CompareUh oh!
There was an error while loading. Please reload this page.
Bound editor discovery, preserve partial and last-known results, retry incomplete scans through the config stream, and distinguish incomplete discovery from a complete empty result in the picker.
8c0a223 to
64d5e41CompareThere was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 64d5e41. Configure here.
| ); | ||
| editorDiscoveryRetry, | ||
| Stream.merge(keybindingsUpdates, Stream.merge(providerStatuses, settingsUpdates)), | ||
| ).pipe(Stream.mapAccum(() => initialConfig, projectServerConfigLiveEvent)); |
There was a problem hiding this comment.
Retry failure kills config stream
Medium Severity
The incomplete-discovery retry is merged into the live subscribeServerConfig stream without isolating failures. Stream.merge propagates errors from either side immediately, so a defect or unexpected failure from resolveAvailableEditors after the initial snapshot terminates settings, keybindings, and provider updates for that subscription. Nearby provider refresh already uses ignoreCause, and launcher tests cover discovery defects, but this retry path does not.
Reviewed by Cursor Bugbot for commit 64d5e41. Configure here.
eeinarsson
commented
Aug 7, 2026
Closing as superseded by #5561. I verified on Windows 11 with the latest nightly that the editor dropdown now works correctly without this PR. |
What Changed
Why
Editor discovery could exceed the server config timeout and discard editors already found, causing clients to incorrectly show “No installed editors found.”
The optional completion field and existing snapshot event keep this compatible across mixed client/server versions.
Fixes#4697.
Related approaches: #4739 and #4435. Complementary command-probe performance work: #4778.
UI Changes
Before:
After:
Checklist
Note
Medium Risk
Touches server config streaming and cross-platform command discovery with new timeout/partial-result semantics; behavior is well tested but affects what clients show for editor availability.
Overview
Editor discovery no longer collapses to an empty list when probes time out or stall.
discoverAvailableCommandsin shared shell code runs bounded, concurrent PATH checks and returns{ available, complete }.ExternalLauncher.resolveAvailableEditorsnow returns{ editors, complete }, merges partial results with the last known complete list, and only caches successful complete discoveries.ServerConfigadds optionalavailableEditorsComplete. The websocket config stream keeps that flag on snapshots, schedules a 1s retry when the initial load is incomplete, and folds retries into live updates without clobbering settings/keybinding events.OpenInPickershows “Couldn’t check for installed editors” when discovery is incomplete or unknown, instead of “No installed editors found”.Coverage spans shell discovery, launcher caching/retry behavior, server config subscription, and the picker empty state.
Reviewed by Cursor Bugbot for commit 64d5e41. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Keep installed editors visible in server config when editor discovery times out
EditorDiscoveryResult(witheditorsandcompletefields) to replace the plain editor array returned byresolveAvailableEditorsin externalLauncher.ts.discoverAvailableCommandsin shell.ts: a platform-aware, timeout-bounded bulk command scanner that returns partial results with acompleteflag instead of failing on timeout.subscribeServerConfigin ws.ts schedules a retry after 1s and emits a refreshedServerConfigsnapshot, propagatingavailableEditorsCompleteto clients.OpenInPickerUI in OpenInPicker.tsx now shows "Couldn't check for installed editors" when discovery is incomplete, versus "No installed editors found" when it is complete.Macroscope summarized 64d5e41.