feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

feat(ci): download macOS preview DMGs without signing in - #8243

Merged
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg
Aug 27, 2026
Merged

feat(ci): download macOS preview DMGs without signing in#8243
t3dotgg merged 9 commits into
mainfrom
ci/anonymous-preview-dmg

Conversation

@t3dotgg

@t3dotggt3dotgg commented Aug 26, 2026

Copy link
Copy Markdown
Member

Preview DMGs from preview:mac PRs upload as Actions artifacts, and GitHub requires a signed-in account to download those. That breaks testing on headless devices. For a public repo the login gate adds no real protection, since any GitHub account can already download them.

Now the workflow publishes each DMG as an asset on a rolling desktop-preview prerelease. Release assets download anonymously with a stable URL, so curl from a headless box works. The PR comment links to that URL.

How it stays safe and tidy:

  • The build job keeps a read-only token and still runs PR code. A new publish job holds the write token, and it only downloads the built artifact and talks to the GitHub API. It never checks out PR code.
  • One rolling prerelease holds all preview DMGs. Publishing a new build uploads an asset instead of creating a release, so release watchers get no notification and the releases page gets no clutter. The desktop-preview tag does not match the v*.*.* pattern in release.yml.
  • Each PR keeps one DMG on the release. A new build replaces the old one.
  • A cleanup job deletes the PR's DMG and updates the comment when the PR closes or the label comes off. This replaces the old 7-day artifact expiry.

Build restrictions are unchanged: same-repo PRs with the preview:mac label only, unsigned build, no Apple secrets.

Change made by Claude Fable 5 running in Claude Code.


Note

Medium Risk
Introduces release publishing and asset deletion driven by PR events, but mitigated by isolating write permissions to jobs that do not run PR code and by filename and PR-state guards against cross-PR clobbering.

Overview
macOS preview builds no longer rely on Actions artifacts (which require a GitHub login). A new publish job uploads each DMG to a rolling desktop-preview prerelease and the PR comment links to the public release asset URL so headless testers can curl without signing in.

The build job still runs PR code with read-onlycontents; publish and cleanup hold contents: write and never check out PR code. publish re-checks that the PR is still open and labeled before and after upload, and refuses filenames that lack this PR’s ‑pr.N. marker so one build cannot touch another PR’s assets. cleanup runs on PR close or preview:mac removal, deletes matching release assets, and updates the comment; it skips if the label was re-applied.

Workflow triggers now include unlabeled and closed. Concurrency is split into separate build vs cleanup groups so in-flight cleanups are not canceled mid-delete and unrelated label events do not cancel builds.

Reviewed by Cursor Bugbot for commit 5c4c7e4. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Publish macOS preview DMGs as public release assets

  • Adds a publish job that uploads the built DMG to a rolling prerelease tagged desktop-preview, so download links are public and require no GitHub sign-in. Prior assets for the same PR are deleted before upload, and the upload is reverted if the PR is closed or loses the preview:mac label mid-publish.
  • Adds a cleanup job that deletes a PR's DMG from the release when the PR is closed or the preview:mac label is removed, then updates the PR comment to note removal.
  • Reworks workflow concurrency to distinguish build runs from cleanup runs so cleanup is never canceled mid-delete; build runs are still canceled on superseding pushes.
  • The build job now exposes dmg_name and version as job outputs for publish to consume, and skips on closed or unlabeled events.
  • Risk: publish uses a rolling tag desktop-preview with multiple PR assets coexisting; the deletion logic in publish and cleanup matches assets by the -pr.<PR_NUMBER>. filename marker, so any asset not matching that pattern will not be managed or removed.

Macroscope summarized 5c4c7e4.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@coderabbitai

coderabbitaiBot commented Aug 26, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: bc404ffb-5ee4-4300-8fb6-d5c00d3afb90

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.3 KiB13.3 KiB−15 B (−0.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.4 KiB6.4 KiB−18 B (−0.3%)7.8 KiB
CodexLive turn WebSocket decoded55.6 KiB55.6 KiB−44 B (−0.1%)66.4 KiB
CodexLive turn messages1110−1 (−9.1%)21
ClaudeTotal thread wire13.3 KiB13.3 KiB−17 B (−0.1%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+2 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.4 KiB−19 B (−0.3%)7.8 KiB
ClaudeLive turn WebSocket decoded56.4 KiB56.4 KiB−44 B (−0.1%)66.4 KiB
ClaudeLive turn messages1110−1 (−9.1%)21

Baseline: 5041777 · PR result: 5c4c7e4 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@t3dotggt3dotgg added the preview:mac Build an Apple Silicon DMG for this PR on every push. label Aug 26, 2026
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Comment thread.github/workflows/desktop-macos-preview.yml
Comment thread.github/workflows/desktop-macos-preview.yml
@github-actions

github-actionsBot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

macOS preview

The preview download was removed because this PR closed or the preview label was removed.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml Outdated
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 12d31ce. Configure here.

Comment thread.github/workflows/desktop-macos-preview.yml
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This adds a new public DMG distribution workflow with release creation, asset replacement/deletion, PR-comment updates, and write permissions driven by PR events. The release lifecycle and permission-boundary changes have broader operational impact than a minor CI tweak.

You can add or adjust custom eligibility rules. Learn more.

@t3dotgg
t3dotgg merged commit 33b650a into mainAug 27, 2026
24 checks passed
@t3dotgg
t3dotgg deleted the ci/anonymous-preview-dmg branch August 27, 2026 01:35
mikeastock-bot pushed a commit to mikeastock/t3code that referenced this pull request Aug 27, 2026
The custom-nightly sync drops workflow-file updates so GITHUB_TOKEN can
push. Bring pingdotgg#8243 in over SSH, which can update workflow files.
frankdavidcorona pushed a commit to frankdavidcorona/t3code that referenced this pull request Aug 27, 2026
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Aug 27, 2026
## What's Changed
* fix(desktop): let Clerk UI receive stable auth fixes by @t3dotgg in pingdotgg/t3code#8248
* fix(app): un-settled threads return to the top of the list by @t3dotgg in pingdotgg/t3code#8231
* perf(ci): cut about a minute from every release by @t3dotgg in pingdotgg/t3code#8250
* feat(ci): download macOS preview DMGs without signing in by @t3dotgg in pingdotgg/t3code#8243
* fix(codex): accept Codex 0.150 multi-agent events by @t3dotgg in pingdotgg/t3code#8346
**Full Changelog**: pingdotgg/t3code@v0.0.34...v0.0.35
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.35
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 28, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
aaditagrawal added a commit to aaditagrawal/t3code that referenced this pull request Aug 29, 2026
* fix(desktop): let Clerk UI receive stable auth fixes (pingdotgg#8248)
* fix(app): un-settled threads return to the top of the list (pingdotgg#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* perf(ci): cut about a minute from every release (pingdotgg#8250)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* feat(ci): download macOS preview DMGs without signing in (pingdotgg#8243)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
* fix(codex): accept Codex 0.150 multi-agent events (pingdotgg#8346)
* chore(release): prepare v0.0.35
---------
Co-authored-by: Theo Browne <me@t3.gg>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Aug 31, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
jmclaren7 added a commit to mclaren-data-systems/t3code that referenced this pull request Sep 1, 2026
`desktop-macos-preview.yml` arrives from upstream pingdotgg#8182/pingdotgg#8243: it builds an
unsigned macOS DMG for any PR carrying a `preview:mac` label, publishes it to a
rolling release, and cleans it up when the label or the PR goes away. It is
genuinely credential-free — `GITHUB_TOKEN` covers all of it — but it fails the
other half of the fork's workflow rule twice over.
All three of its jobs run on `blacksmith-*` runners, which never resolve here,
and nothing about it is needed to build or to check code quality: this fork
already publishes unsigned artifacts for all four platforms from
`desktop-artifacts.yml` on every push to `main`. Adopting it would mean swapping
in `macos-*` runners and paying for a full macOS desktop build on every labeled
PR to duplicate an artifact the fork already ships.
A new upstream workflow is opt-in. This one is declined; FORK.md entry 14
records the decision so the next rebase does not re-litigate it.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01SzCcc9XJPsJL14c2sxa7sM
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

preview:macBuild an Apple Silicon DMG for this PR on every push.size:L100-499 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@t3dotgg