chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore(upstream): sync marcode through f6f2be32 - #56

Draft
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l
Draft

chore(upstream): sync marcode through f6f2be32#56
maarco wants to merge 42 commits into
mainfrom
claude/gracious-bohr-rlxi8l

Conversation

@maarco

Copy link
Copy Markdown
Owner

What Changed

Daily upstream sync: merges pingdotgg/t3code@f6f2be32 (41 commits since f035a0f4, through upstream v0.0.35) into main as a normal two-parent merge. Fourteen conflicts, each resolved by hand so both intents survive — no whole-file ours/theirs, no force push, reset, restore, stash, or clean.

Conflict decisions

PathDecision
apps/server/src/persistence/Migrations.tsUpstream's new 042/043 renamed to Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so every shared migration sits one id higher; renumbering an applied id would re-run or skip it on existing installs. Migrations.test.ts (the pin that fails loudly on every sync) and the migration's own test extended to match.
apps/server/src/cloud/bootService.ts (+ test)Took upstream's launchd PATH export (pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without it, so exporting upstream's T3CODE_HOME would ship a service that never boots. Both assertions kept.
packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test)Kept both capability flags — Marcode's workspaceLayoutMutations and upstream's new threadPullRequestLinking. Additive on both sides.
apps/web/src/components/ChatMarkdown.tsxTook upstream's expanded editorPreferences/editorLabels imports and the whole markdown file-link rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop. Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers upstream replaced.
apps/web/src/components/ChatView.tsxKept Marcode's title-only ChatHeader and single panelLayoutControls mount; took upstream's settleThread. Upstream's new project-scoped openProjectPullRequest has no consumer here — ThreadActionsCluster already wires the more capable openThreadPullRequest — so it is dropped with a seam comment naming where new entry points belong.
apps/web/src/components/chat/OpenInPicker.tsxTook upstream's editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and kept Marcode's FolderOpenFilled icon.
apps/web/src/components/ThreadTerminalDrawer.tsxKept Marcode's xterm link provider. Upstream's pingdotgg#7488 swapped an inline regex for isTerminalUrl; Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is the same https?:// test, so the fix is already present in this path. Recorded as a seam so the divergence is re-ported deliberately each sync.
apps/mobile/src/lib/mobileBranding.test.tsUpstream deleted it as low-signal (pingdotgg#8397). Kept — it pins Marcode's empty stable-channel stage label against upstream's "Alpha". Annotated so the next sync knows why it survives an upstream deletion.
apps/web/src/components/threadSidebarWidth.test.tsUpstream deleted it as trivial (pingdotgg#8400). Kept — it carries the sidebar brand-removal pin, which has no other home. Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than re-exporting it for the test, and re-expressed that one assertion against the minimum.
scripts/build-desktop-artifact.test.tsKept Marcode's provisioning-profile fixture; took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign assertion from the signing rework (pingdotgg#8093).
pnpm-lock.yamlKept Marcode's @xterm/* entries; the Clerk bumps merged cleanly. pnpm install --frozen-lockfile passes against the merged workspace.

Fork-boundary breaks that merged cleanly (no conflict)

These are the dangerous ones — they produce no mark and then quietly do not work:

  • apps/server/src/process/externalLauncher.test.ts carried an upstream oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin namespace is marcode/, so the directive would have been unknown and tripped --report-unused-disable-directives. Renamed.
  • .github/workflows/desktop-macos-preview.yml (new, feat(desktop): build macOS previews from a PR label pingdotgg/t3code#8182/feat(ci): download macOS preview DMGs without signing in pingdotgg/t3code#8243) ran on Blacksmith runners the public fork cannot reach, which queue forever rather than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention ci.yml already uses. The workflow is opt-in behind a preview:mac label and is not a required check — say the word if you would rather leave it upstream-shaped.
  • apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model manifest (feat(server): fetch legacy model classification from a hosted manifest pingdotgg/t3code#8227). Kept pointed at pingdotgg/t3codedeliberately: model classification is upstream-owned with no Marcode divergence, and the fork's own main would only refresh on a sync — losing the point of hosting it. Same precedent as the triage playbook URL. Recorded in a seam comment.

Swept T3CODE_*, t3code.service, WORKTREE_BRANCH_PREFIX, and boot-service naming across the merged tree; every other hit is an intentional compatibility identifier (T3_BOOT_SERVICE_UNIT, com.t3tools.t3code.service, t3code:* storage keys, @t3tools/*, the t3 package name) and is left upstream-shaped.

Coupled subtrees

pnpm-workspace.yaml moved only Clerk versions. The effect and alchemy catalog entries are unchanged, so neither .repos/effect-smol nor .repos/alchemy-effect needs a sync in this change.

Deleted tests

Upstream pruned 13 test files (pingdotgg#8397, pingdotgg#8400). Each was checked against the previous merge base and carried no Marcode edits, so all 13 deletions are accepted. The two that did carry Marcode behavior are kept and annotated (above).

Why

Marcode is a maintained fork. Upstream correctness, security, protocol, dependency, and operational fixes have to land, while Marcode's intentional product behavior — the floating editor, the unified workspace tree, FloatingPillNav, branding, and the migration id offset — has to survive them. Hotspot paths are mandatory-review paths, not automatic keep-Marcode paths, so the upstream launchd PATH fix, the editorLabelForPlatform refactor, and the mac.sign assertion were all taken even though they landed in customized files.

Where Marcode keeps a divergent implementation of an upstream subsystem, the divergence is now marked with a ── Marcode fork seam ── comment saying what it mounts and why, so the next person resolving that conflict knows instantly whether a hunk is theirs, ours, or a join.

UI Changes

None. Every web change in this merge is upstream's own; Marcode's user-visible surfaces (ChatHeader, OpenInPicker icon, panel layout controls, terminal link behavior) are preserved unchanged by the resolutions above. No live client verification was run in this container — it has no display or simulator — so if you want the chat markdown file-link rework driven in a real browser before this goes ready, that is the one thing left.

Checklist

  • This PR is small and focused — one concern: the upstream sync
  • I explained what changed and why
  • I included before/after screenshots for any UI changes — n/a, no Marcode UI change
  • I included a video for animation/interaction changes — n/a

Verification

Focused only on what the merge touched; CI owns the full suite.

  • Tests (all passing): server boot service, ServerEnvironment, serviceLauncher, migrations 033/042/043 + the Migrations.test.ts pin, externalLauncher, GitVcsDriverCore, ProviderRegistry, ProjectionSnapshotQuery, serverSettings; web ChatMarkdown (×2), ChatView.logic, ThreadTerminalDrawer (+ stylesheet), terminal-links, editorLabels, Sidebar.logic, openPullRequestLink, imageCompression, versionSkew, threadSidebarWidth; mobile branding, markdownLinks, threadListV2, connection, linkEnvironment; contracts environment/settings; build-desktop-artifact, sign-macos, upstream-sync-workflow parity.
  • Typecheck: @t3tools/contracts, @t3tools/web, t3, @t3tools/scripts, @t3tools/mobile — all clean.
  • Format / lint: vp fmt --check over all 203 changed files, vp lint --report-unused-disable-directives over the 44 changed directories — clean, warnings only and all pre-existing.
  • Install: pnpm install --frozen-lockfile succeeds, confirming the resolved lockfile matches the merged workspace and every package.json.
  • Mobile static analysis: scripts/mobile-native-static-check.ts exits 0 (swiftlint/ktlint/detekt unavailable in this container, as on any non-macOS host).

Not verified here: live browser and simulator runs, and the four required CI checks — those run on this PR.


Generated by Claude Code

t3dotggand others added 30 commits August 24, 2026 12:42
Co-authored-by: mweinbach <maxweinbach5@gmail.com>
…gg#7140)
Co-authored-by: Dara Adedeji <daraaded@amazon.com>
Co-authored-by: shivam <91240327+shivamhwp@users.noreply.github.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
t3dotggand others added 12 commits August 25, 2026 23:59
…#8231)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
)
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…tgg#8358)
Co-authored-by: Dara Adedeji <daraadedeji07@gmail.com>
Co-authored-by: Ahmed Besic <ahmed-besic@users.noreply.github.com>
Co-authored-by: Michael Brown <michaeltbrown.mtb@gmail.com>
Co-authored-by: Lars Nieuwenhuis <35393046+lnieuwenhuis@users.noreply.github.com>
Co-authored-by: Guilherme Barros <gbarros1095@gmail.com>
Co-authored-by: PC <pc@localhost>
Co-authored-by: 1xpixi <157762409+1xpixi@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
Co-authored-by: t3-code[bot] <269035359+t3-code[bot]@users.noreply.github.com>
Co-authored-by: Julius Marminge <51714798+juliusmarminge@users.noreply.github.com>
41 upstream commits since f035a0f, through v0.0.35. Fourteen conflicts,
resolved by hand so both intents survive.
Conflict decisions:
- apps/server/src/persistence/Migrations.ts — upstream's new 042/043 renamed to
Marcode's next free ids 043/044. Marcode's ProjectWorkspaceLayout owns 033, so
every shared migration sits one id higher; renumbering an applied id would
re-run or skip it on existing installs. Migrations.test.ts (the pin that fails
loudly on every sync) and the migration's own test extended to match.
- apps/server/src/cloud/bootService.ts — took upstream's launchd PATH export
(pingdotgg#8173, keeps provider CLIs reachable from the macOS service) and kept
Marcode's MARCODE_HOME key. The launcher reads MARCODE_HOME and exits without
it, so exporting upstream's T3CODE_HOME would ship a service that never boots.
Both assertions kept in bootService.test.ts.
- packages/contracts/src/environment.ts, ServerEnvironment.ts (+ test) — kept
both capability flags: Marcode's workspaceLayoutMutations and upstream's new
threadPullRequestLinking. Purely additive on both sides.
- apps/web/src/components/ChatMarkdown.tsx — took upstream's expanded
editorPreferences/editorLabels imports and the whole markdown file-link
rework; kept Marcode's openFileInFloatingEditor seam and workspacePath prop.
Dropped useRightPanelStore and useActiveEnvironmentId, whose only consumers
upstream replaced.
- apps/web/src/components/ChatView.tsx — kept Marcode's title-only ChatHeader
and single panelLayoutControls mount; took upstream's settleThread. Upstream's
new project-scoped openProjectPullRequest has no consumer here because
ThreadActionsCluster already wires the more capable openThreadPullRequest, so
it is dropped with a seam comment naming where new entry points belong.
- apps/web/src/components/chat/OpenInPicker.tsx — took upstream's
editorLabelForPlatform refactor (which preserves Finder/Explorer/Files) and
kept Marcode's FolderOpenFilled icon.
- apps/web/src/components/ThreadTerminalDrawer.tsx — kept Marcode's xterm link
provider. Upstream's pingdotgg#7488 change swapped an inline regex for isTerminalUrl;
Marcode already classifies through extractTerminalLinks, whose URL_PATTERN is
the same https?:// test, so the fix is already present in this path. Recorded
as a seam so the divergence is re-ported deliberately.
- apps/mobile/src/lib/mobileBranding.test.ts, threadSidebarWidth.test.ts —
upstream deleted both as low-signal (pingdotgg#8397, pingdotgg#8400). Kept: the first pins
Marcode's empty stable-channel stage label against upstream's "Alpha", the
second carries the sidebar brand-removal pin that has no other home. Both
annotated so the next sync knows why they survive an upstream deletion.
Followed upstream in un-exporting THREAD_SIDEBAR_DEFAULT_WIDTH rather than
re-exporting it for the test.
- scripts/build-desktop-artifact.test.ts — kept Marcode's provisioning-profile
fixture, took upstream's MAC_FILE_EXCLUSIONS import and the new mac.sign
assertion from the signing rework (pingdotgg#8093).
- pnpm-lock.yaml — kept Marcode's @xterm/* entries; the Clerk bumps merged
cleanly. pnpm install --frozen-lockfile passes against the merged workspace.
Fork-boundary breaks that merged without a conflict:
- apps/server/src/process/externalLauncher.test.ts carried an upstream
oxlint-disable for t3code/no-global-process-runtime. Marcode's plugin is
marcode/, so the directive would have been unknown and tripped
--report-unused-disable-directives. Renamed.
- .github/workflows/desktop-macos-preview.yml (new, pingdotgg#8182/pingdotgg#8243) ran on
Blacksmith runners the public fork cannot reach, which queue forever rather
than failing. Pinned to ubuntu-24.04/macos-26 with the same comment convention
ci.yml uses. The workflow is opt-in behind a preview:mac label and is not a
required check.
- apps/server/src/provider/ModelManifest.ts fetches upstream's hosted model
manifest (pingdotgg#8227). Kept pointed at pingdotgg/t3code deliberately: model
classification is upstream-owned with no Marcode divergence, and the fork's
own main would only refresh on a sync. Same precedent as the triage playbook
URL. Recorded in a seam comment.
Coupled subtrees: pnpm-workspace.yaml moved only Clerk versions; the effect and
alchemy catalog entries are unchanged, so neither .repos/ subtree needs a sync.
Deleted upstream test files (13, from pingdotgg#8397/pingdotgg#8400) were each checked against the
previous merge base and carried no Marcode edits.
Verified: focused tests for every resolved path (server boot service,
environment, migrations, process launcher, desktop artifact, sign-macos,
upstream-sync workflow parity, web chat markdown/view/terminal/sidebar/links,
mobile branding and thread list, contracts environment/settings), typecheck for
contracts, web, server, scripts and mobile, vp fmt --check and vp lint
--report-unused-disable-directives over the changed scope.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0134QKJdojNMdyacXtMwWpic
@maarcomaarco added the upstream-sync Upstream T3 Code sync label Aug 27, 2026 — with Claude
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL labels Aug 27, 2026
@github-actions

github-actionsBot commented Aug 27, 2026

Copy link
Copy Markdown

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.4 KiB13.2 KiB−173 B (−1.3%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB+1 B (+0.0%)7.3 KiB
CodexLive turn WebSocket wire6.5 KiB6.4 KiB−174 B (−2.6%)7.8 KiB
CodexLive turn WebSocket decoded55.0 KiB55.5 KiB+514 B (+0.9%)66.4 KiB
CodexLive turn messages169−7 (−43.8%)21
ClaudeTotal thread wire13.4 KiB13.2 KiB−252 B (−1.8%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+17 B (+0.2%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.3 KiB−269 B (−4.0%)7.8 KiB
ClaudeLive turn WebSocket decoded55.8 KiB55.5 KiB−308 B (−0.5%)66.4 KiB
ClaudeLive turn messages169−7 (−43.8%)21

Baseline: 133f3f7 · PR result: f08c879 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXLupstream-syncUpstream T3 Code syncvouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

12 participants

@maarco@t3dotgg@tris203@flamboh@RakshithBhat03@StiensWout@lnieuwenhuis@MohtashamMurshid@SunkenInTime@luckyPipewrench@krutftw@claude