fix(web): avoid stale file writes on close

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.

[yashranaway]

What Changed

• track the latest confirmed file revision in the debounced save coordinator
• flush only revisions that are still pending when a file surface is disposed
• ignore editor callbacks that arrive after the coordinator has been disposed
• add regressions for confirmed-content disposal and post-disposal editor changes

Why

Closing a file could write an already-confirmed in-memory buffer back to disk. If another device or process had updated the file since that confirmation, the close-time write replaced those newer contents with stale data.

Closes#8475.

Testing

• vp test run apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp lint apps/web/src/components/files/fileSaveCoordinator.ts apps/web/src/components/files/fileSaveCoordinator.test.ts
• vp run --filter @t3tools/web typecheck

Checklist

• focused regression tests added
• lint passes for changed files
• web typecheck passes
• rebased onto latest upstream main
• no visual change; screenshots are not applicable

Model: GPT-5.6 Sol
Harness: Codex in T3 Code

---

Note

Medium Risk
Changes debounced file persistence on editor close; incorrect revision tracking could drop unsaved edits or still overwrite disk, though behavior is heavily regression-tested.

Overview
Fixes FileSaveCoordinator re-writing already-confirmed buffer contents when a file editor closes, which could overwrite newer on-disk changes from elsewhere.

The coordinator now tracks confirmedRevision after each successful persist and skips persistLatest when there is nothing newer than what was last confirmed, including the flush triggered by dispose(). change() is ignored once disposed, so late editor callbacks cannot schedule another save.

Regression tests cover debounce-close flushes, in-flight writes, failed-write retry on close, post-disposal changes, and the case where disposal must not trigger an extra persist.

^{Reviewed by Cursor Bugbot for commit 38f126f. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix stale file writes on close in FileSaveCoordinator

• dispose() now cancels the debounce timer and flushes any unconfirmed revision, so edits pending in the debounce window or during an in-flight write are persisted when the editor closes.
• Adds confirmedRevision tracking in persistLatest() so already-written contents are not re-persisted on disposal.
• change() early-returns when the coordinator is disposed, ignoring editor changes emitted after close.
• Risk: dispose() now triggers a persistence call whenever a newer-than-confirmed revision exists; callers that relied on disposal silently dropping pending writes will see an extra write in fileSaveCoordinator.ts.

^{Macroscope summarized 38f126f.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: f87b9227-0d60-426d-8be7-a00cbc87bbba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 38f126f

Macroscope's review found this PR approvable — This is a focused bug fix confined to the file-save coordinator, correcting close-time revision handling and adding regression coverage for pending, failed, in-flight, and post-disposal cases. It introduces no schema, infrastructure, security-sensitive, default, or static-analysis changes.

Notes:

• No code objects were reviewed. Approvability was decided on eligibility alone.

^{You can add or adjust custom eligibility rules. Learn more.}

[t3dotgg]

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

Please retain the additional FileSaveCoordinator test cases from PR #8632. They cover closing during the debounce window, closing during an in-flight save with and without a newer edit, and retrying a save that failed before close. These tests have not been copied into this PR.

Dismissing prior approval to re-evaluate 38f126f

[yashranaway]

Added in 38f126f; #8630 now retains all four FileSaveCoordinator close-path cases from #8632.