Uh oh!
There was an error while loading. Please reload this page.
fix(web): address composer banner review follow-ups - #8850
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
Thread transfer impact✅ Thread transfer remains within every enforced ceiling.
Baseline: Scenario and decoded snapshot size10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.
Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed. |
There was a problem hiding this comment.
One finding in ComposerBannerStack: the Escape handler runs even when the stack is already collapsed, which leaves a stale pending-focus request that later steals focus. Details inline.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This is a contained web composer UI and accessibility follow-up with no schema, security, billing, or deployment impact. An unresolved comment identifies a concrete keyboard-focus and Escape-event regression in the notice stack, so the changed interaction behavior needs human review. You can add or adjust custom eligibility rules. Learn more. |
- Keep Escape focused on collapsing an expanded banner stack - Add local composer playground scenarios and before/after review evidence
There was a problem hiding this comment.
One finding: the production composer now routes its props through a committed dev-only review fixture. Details inline.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
## What's Changed * fix(web): address composer banner review follow-ups by @juliusmarminge in pingdotgg/t3code#8850 * fix(web): widen sync banners and simplify the working timer by @juliusmarminge in pingdotgg/t3code#8855 * fix(preview): improve browser recording quality by @maria-rcks in pingdotgg/t3code#8839 * fix(web): mark pull request links as external by @juliusmarminge in pingdotgg/t3code#8856 * fix(mobile): replace Callstack glass with Expo glass by @juliusmarminge in pingdotgg/t3code#8862 **Full Changelog**: pingdotgg/t3code@v0.0.38-nightly.20260831.1235...v0.0.38-nightly.20260831.1236 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38-nightly.20260831.1236
Restores main features dropped by the policy replay: #8569 theme wiring, #8850 composer banner follow-ups, #8855/#8904 composer fixes, #8831 settings search rework, #8803 workspace-mutation refresh (v2-adapted), #8840 circle-alert, #8584 codex artifact templates, #8688/#8807/#8936 video + image previews (web and mobile, v2-adapted), #8862 Expo glass, and the round's docs. Timeline thinking rows (#8984) stay on the v2 work-live system. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
## What's Changed * Add mobile composer attachment menu with video support by @juliusmarminge in pingdotgg/t3code#8843 * fix(web): restore unified activity logs and composer banners by @t3dotgg in pingdotgg/t3code#8734 * fix(web): address composer banner review follow-ups by @juliusmarminge in pingdotgg/t3code#8850 * fix(web): widen sync banners and simplify the working timer by @juliusmarminge in pingdotgg/t3code#8855 * fix(preview): improve browser recording quality by @maria-rcks in pingdotgg/t3code#8839 * fix(web): mark pull request links as external by @juliusmarminge in pingdotgg/t3code#8856 * fix(mobile): replace Callstack glass with Expo glass by @juliusmarminge in pingdotgg/t3code#8862 * fix(server): skip IDE detection in Claude probes by @yashranaway in pingdotgg/t3code#8634 * chore(macroscope): review diagnostic overrides by @t3-code[bot] in pingdotgg/t3code#8917 * fix(contracts): accept CLI event origins by @nateEc in pingdotgg/t3code#8905 * fix(web): hide invalid slash skill completions by @nateEc in pingdotgg/t3code#8904 * fix(mobile): defer draft navigation until submission completes by @juliusmarminge in pingdotgg/t3code#8914 * chore: disable CodeRabbit review status by @juliusmarminge in pingdotgg/t3code#8933 * Delete app.json by @juliusmarminge in pingdotgg/t3code#8934 * fix(web): show scrollbar for wide markdown tables by @UtkarshUsername in pingdotgg/t3code#8868 * fix(mobile): shimmer active tool rows by @juliusmarminge in pingdotgg/t3code#8932 * chore(deps): bump Electron to 43.4.1 by @StiensWout in pingdotgg/t3code#8626 * fix(chat): smooth worktree setup status by @juliusmarminge in pingdotgg/t3code#8922 * feat(mobile): add video playback with native iOS controls by @juliusmarminge in pingdotgg/t3code#8919 * fix(web): prevent chat metadata overlap by @MatthewFeroz in pingdotgg/t3code#8851 * fix(server): preserve usage cache outside walked roots by @Lucenx9 in pingdotgg/t3code#8540 * feat(mobile): add native image and PDF previews by @juliusmarminge in pingdotgg/t3code#8959 * fix(server): allow long thread IDs in HTTP routes by @nateEc in pingdotgg/t3code#8898 * fix(shared): preserve Windows shell PATH priority by @UtkarshUsername in pingdotgg/t3code#8748 * fix(web): make WSL settings searchable by @UtkarshUsername in pingdotgg/t3code#8881 * feat(web): add expand/collapse all control to the files surface by @UtkarshUsername in pingdotgg/t3code#8889 * feat(mobile): upload attachments while composing by @juliusmarminge in pingdotgg/t3code#8978 * fix(chat): keep agent activity visible between actions by @maria-rcks in pingdotgg/t3code#8984 * fix(server): isolate remote web session cookies by @Bil0000 in pingdotgg/t3code#8085 * feat(pull-requests): link GitHub references in markdown by @maria-rcks in pingdotgg/t3code#8812 * perf(server): reduce frequency of full tool call output being loaded into memory from db by @t3dotgg in pingdotgg/t3code#8988 * feat(web): add pull request list filters by @maria-rcks in pingdotgg/t3code#8809 * feat(web): search individual settings by detail by @maria-rcks in pingdotgg/t3code#8831 * feat(client): render viewed images in work logs by @maria-rcks in pingdotgg/t3code#8936 * fix(client): use package import for markdown image helpers by @juliusmarminge in pingdotgg/t3code#9010 * test: remove static presentation snapshots by @t3-code[bot] in pingdotgg/t3code#9008 * perf(server): bound snapshot activity payload memory by @t3dotgg in pingdotgg/t3code#9000 * perf(server): cut idle CPU use and stop provider event leaks by @t3dotgg in pingdotgg/t3code#8187 * perf(server): scan only appended transcript bytes for usage summaries by @StiensWout in pingdotgg/t3code#9024 * perf(server): cut chatty tool-update frames by 90% by @Adamulek123 in pingdotgg/t3code#8368 * fix(server): settle threads server-side by @t3dotgg in pingdotgg/t3code#8600 * fix(clients): dedupe skills in composer menus by @Adamulek123 in pingdotgg/t3code#8043 * fix(server): stop OpenCode child sessions by @t3dotgg in pingdotgg/t3code#9005 * perf(web): defer pull request line stats until visible by @Adamulek123 in pingdotgg/t3code#6471 * perf(server): skip full-message reads while streaming by @t3dotgg in pingdotgg/t3code#9032 * perf(client-runtime): halve server config bootstrap traffic by @Adamulek123 in pingdotgg/t3code#8367 * fix(web): align un-settle banner action by @StiensWout in pingdotgg/t3code#9033 * fix(web): block type-to-focus behind open dialogs by @Lucenx9 in pingdotgg/t3code#8139 * feat(shortcuts): copy active thread reference by @maria-rcks in pingdotgg/t3code#8994 * fix(mobile): keep thread scroll bounds current after animations by @juliusmarminge in pingdotgg/t3code#9013 * fix(server): cache project favicon resolution by @willsheldon in pingdotgg/t3code#9080 * feat(claude): add Claude Fable 5.1 model by @q1 in pingdotgg/t3code#9078 * fix(preview): restore recording and macOS rendering after Electron 43 by @StiensWout in pingdotgg/t3code#9001 * feat(desktop): add configurable quit shortcut confirmation by @juliusmarminge in pingdotgg/t3code#9076 * feat(web): open project settings from thread menus by @SunkenInTime in pingdotgg/t3code#8925 * fix(chat): reuse one row for live activity by @maria-rcks in pingdotgg/t3code#9062 * feat(models): discover Claude models from remote manifest by @juliusmarminge in pingdotgg/t3code#9084 * Revert "fix(chat): reuse one row for live activity" by @maria-rcks in pingdotgg/t3code#9096 * fix(web): sync sidebar PR state from open panel by @t3-code[bot] in pingdotgg/t3code#9092 * fix(web): changing projects no longer creates a draft by @extoci in pingdotgg/t3code#9097 * fix(web): keep theme placeholder text dimmer than entered text by @flamboh in pingdotgg/t3code#9104 * fix(web): keep the selected environment when changing projects by @t3dotgg in pingdotgg/t3code#9102 ## New Contributors * @willsheldon made their first contribution in pingdotgg/t3code#9080 * @q1 made their first contribution in pingdotgg/t3code#9078 **Full Changelog**: pingdotgg/t3code@v0.0.37...v0.0.38 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38
Follow-up fixes from the review of #8734. Monitoring could hide the loading status, keyboard focus could disappear inside a notice stack, and composer controls had a few focus and pointer issues.
Open the before/after comparison page for every change, including keyboard and pointer recordings.
The notice-action alignment change and enlarged touch disclosure were reverted. Items 4 and 6 in the comparison document show the original layouts restored. The compact touch peek remains.
The working timer stays in the timeline, tasks stay in the composer, loading hides tasks, and stash remains a separate tab.
Validation: 110 focused tests, web typecheck, targeted lint, and 36 browser checks passed. Browser checks cover keyboard focus, hover, touch expansion, pointer hit testing, responsive widths, reduced motion, and inset sizing. Web and the shared desktop UI are affected; native mobile is unchanged. Safari and VoiceOver were not exercised.
Fixtures and comparison assets are not committed.
Note
Low Risk
UI, accessibility, and layout-only changes; the main behavioral caveat is drawer inset computing to 0 if
--chat-composer-drawer-insetis missing outsideComposerSurface.Shell.Overview
Follow-up polish for composer banners and notices on web/desktop: loading/activity stays the attached front banner ahead of other notices (including Monitoring), and server update notices use status-specific icons (spinner, error, info) instead of a generic info icon.
Notice stack keyboard and pointer behavior is tightened in
ComposerBannerStack: hover no longer auto-expands on touch; Tab/Enter/Space on Show other notices moves focus into the expanded stack; Escape collapses and returns focus to the peek control; peek is hidden from the tab order while expanded. ARIArole="group"/ labels androle="list"on stash and task lists improve semantics.Layout standardizes horizontal inset via
--chat-composer-drawer-inseton the composer shell (banner width, context strip, clip-path, command-menu positioning); the command menu drops the 1.375rem JS fallback when the variable is unset. Minor UI fixes: decorative chevronpointer-events-none, padding on the pending-question panel body, and user docs for the notice stack interaction.Reviewed by Cursor Bugbot for commit 5e56011. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Fix composer banner accessibility, focus management, and drawer inset CSS variable
Escapeto close,aria-hidden/tabIndexmanagement, androle="group"toComposerBannerStack; hover no longer expands on touch pointersInfoIconin the server update banner with a newComposerServerUpdateIconthat renders a spinner forrunning, alert forfailed, and info otherwise--chat-composer-drawer-inset(default1.375rem) onComposerSurface.Shelland uses it inComposerBanner.Attachmentwidth andComposerCommandMenuLayerpositioning instead of hardcoded valuesrole="list"to stash menu and tasks badge lists,pointer-events-nonetoComposerBanner.ToggleIcon, and movesactivityStackItemahead ofprops.bannerItemsin the stackComposerCommandMenuLayerno longer falls back to1.375when the CSS variable is missing — callers relying on--chat-composer-drawer-insetmust define it or inherit theComposerSurface.ShelldefaultMacroscope summarized 5e56011.