Uh oh!
There was an error while loading. Please reload this page.
feat(web): open project settings from thread menus - #8925
Conversation
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Warning Your free Security trial is over. An organization admin can activate Security or dismiss this notice. Comment |
There was a problem hiding this comment.
UI consistency review found one regression risk in apps/web/src/components/Sidebar.tsx: the new projectGroups dependency on handleThreadContextMenu defeats the documented row-memoization pattern in that file. Details inline. The rest of the change (shared buildThreadActionMenuItems item, settings icon registered in the web fallback, project resolution scoped to thread.environmentId in both handlers) looks consistent.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a focused additive navigation shortcut to the existing project settings page across current thread-menu surfaces. Existing actions and data flows remain unchanged, with only small project-key resolution and fallback-icon wiring added. You can add or adjust custom eligibility rules. Learn more. |
SunkenInTime
commented
Aug 31, 2026
Addressed the Macroscope UI consistency finding in fa436a5: the latest project groups are now read through a stable ref, so handleThreadContextMenu no longer depends on the per-stream projectGroups identity. Formatting, lint, typecheck, and all 3,033 web tests pass locally. |
There was a problem hiding this comment.
One consistency finding on the new context-menu entry (see inline comment). The dependency-churn issue flagged on the previous commit is resolved — projectGroupsRef plus the stable openProjectSettings (deps: isMobile, router, setOpenMobile, all stable) keeps handleThreadContextMenu's identity unaffected by thread-shell updates.
Posted via Macroscope — UI Consistency
Uh oh!
There was an error while loading. Please reload this page.
SunkenInTime
commented
Aug 31, 2026
Addressed the second Macroscope UI consistency finding in a43cc22 by removing the gear from the legacy icon-less menu row; the modern shared menu keeps its consistent gear icon. Formatting, lint, typecheck, and all 3,033 web tests pass locally. |
Dismissing prior approval to re-evaluate 8c42e6f
8c42e6f to
450fa8bCompareUh oh!
There was an error while loading. Please reload this page.
## What's Changed * Add mobile composer attachment menu with video support by @juliusmarminge in pingdotgg/t3code#8843 * fix(web): restore unified activity logs and composer banners by @t3dotgg in pingdotgg/t3code#8734 * fix(web): address composer banner review follow-ups by @juliusmarminge in pingdotgg/t3code#8850 * fix(web): widen sync banners and simplify the working timer by @juliusmarminge in pingdotgg/t3code#8855 * fix(preview): improve browser recording quality by @maria-rcks in pingdotgg/t3code#8839 * fix(web): mark pull request links as external by @juliusmarminge in pingdotgg/t3code#8856 * fix(mobile): replace Callstack glass with Expo glass by @juliusmarminge in pingdotgg/t3code#8862 * fix(server): skip IDE detection in Claude probes by @yashranaway in pingdotgg/t3code#8634 * chore(macroscope): review diagnostic overrides by @t3-code[bot] in pingdotgg/t3code#8917 * fix(contracts): accept CLI event origins by @nateEc in pingdotgg/t3code#8905 * fix(web): hide invalid slash skill completions by @nateEc in pingdotgg/t3code#8904 * fix(mobile): defer draft navigation until submission completes by @juliusmarminge in pingdotgg/t3code#8914 * chore: disable CodeRabbit review status by @juliusmarminge in pingdotgg/t3code#8933 * Delete app.json by @juliusmarminge in pingdotgg/t3code#8934 * fix(web): show scrollbar for wide markdown tables by @UtkarshUsername in pingdotgg/t3code#8868 * fix(mobile): shimmer active tool rows by @juliusmarminge in pingdotgg/t3code#8932 * chore(deps): bump Electron to 43.4.1 by @StiensWout in pingdotgg/t3code#8626 * fix(chat): smooth worktree setup status by @juliusmarminge in pingdotgg/t3code#8922 * feat(mobile): add video playback with native iOS controls by @juliusmarminge in pingdotgg/t3code#8919 * fix(web): prevent chat metadata overlap by @MatthewFeroz in pingdotgg/t3code#8851 * fix(server): preserve usage cache outside walked roots by @Lucenx9 in pingdotgg/t3code#8540 * feat(mobile): add native image and PDF previews by @juliusmarminge in pingdotgg/t3code#8959 * fix(server): allow long thread IDs in HTTP routes by @nateEc in pingdotgg/t3code#8898 * fix(shared): preserve Windows shell PATH priority by @UtkarshUsername in pingdotgg/t3code#8748 * fix(web): make WSL settings searchable by @UtkarshUsername in pingdotgg/t3code#8881 * feat(web): add expand/collapse all control to the files surface by @UtkarshUsername in pingdotgg/t3code#8889 * feat(mobile): upload attachments while composing by @juliusmarminge in pingdotgg/t3code#8978 * fix(chat): keep agent activity visible between actions by @maria-rcks in pingdotgg/t3code#8984 * fix(server): isolate remote web session cookies by @Bil0000 in pingdotgg/t3code#8085 * feat(pull-requests): link GitHub references in markdown by @maria-rcks in pingdotgg/t3code#8812 * perf(server): reduce frequency of full tool call output being loaded into memory from db by @t3dotgg in pingdotgg/t3code#8988 * feat(web): add pull request list filters by @maria-rcks in pingdotgg/t3code#8809 * feat(web): search individual settings by detail by @maria-rcks in pingdotgg/t3code#8831 * feat(client): render viewed images in work logs by @maria-rcks in pingdotgg/t3code#8936 * fix(client): use package import for markdown image helpers by @juliusmarminge in pingdotgg/t3code#9010 * test: remove static presentation snapshots by @t3-code[bot] in pingdotgg/t3code#9008 * perf(server): bound snapshot activity payload memory by @t3dotgg in pingdotgg/t3code#9000 * perf(server): cut idle CPU use and stop provider event leaks by @t3dotgg in pingdotgg/t3code#8187 * perf(server): scan only appended transcript bytes for usage summaries by @StiensWout in pingdotgg/t3code#9024 * perf(server): cut chatty tool-update frames by 90% by @Adamulek123 in pingdotgg/t3code#8368 * fix(server): settle threads server-side by @t3dotgg in pingdotgg/t3code#8600 * fix(clients): dedupe skills in composer menus by @Adamulek123 in pingdotgg/t3code#8043 * fix(server): stop OpenCode child sessions by @t3dotgg in pingdotgg/t3code#9005 * perf(web): defer pull request line stats until visible by @Adamulek123 in pingdotgg/t3code#6471 * perf(server): skip full-message reads while streaming by @t3dotgg in pingdotgg/t3code#9032 * perf(client-runtime): halve server config bootstrap traffic by @Adamulek123 in pingdotgg/t3code#8367 * fix(web): align un-settle banner action by @StiensWout in pingdotgg/t3code#9033 * fix(web): block type-to-focus behind open dialogs by @Lucenx9 in pingdotgg/t3code#8139 * feat(shortcuts): copy active thread reference by @maria-rcks in pingdotgg/t3code#8994 * fix(mobile): keep thread scroll bounds current after animations by @juliusmarminge in pingdotgg/t3code#9013 * fix(server): cache project favicon resolution by @willsheldon in pingdotgg/t3code#9080 * feat(claude): add Claude Fable 5.1 model by @q1 in pingdotgg/t3code#9078 * fix(preview): restore recording and macOS rendering after Electron 43 by @StiensWout in pingdotgg/t3code#9001 * feat(desktop): add configurable quit shortcut confirmation by @juliusmarminge in pingdotgg/t3code#9076 * feat(web): open project settings from thread menus by @SunkenInTime in pingdotgg/t3code#8925 * fix(chat): reuse one row for live activity by @maria-rcks in pingdotgg/t3code#9062 * feat(models): discover Claude models from remote manifest by @juliusmarminge in pingdotgg/t3code#9084 * Revert "fix(chat): reuse one row for live activity" by @maria-rcks in pingdotgg/t3code#9096 * fix(web): sync sidebar PR state from open panel by @t3-code[bot] in pingdotgg/t3code#9092 * fix(web): changing projects no longer creates a draft by @extoci in pingdotgg/t3code#9097 * fix(web): keep theme placeholder text dimmer than entered text by @flamboh in pingdotgg/t3code#9104 * fix(web): keep the selected environment when changing projects by @t3dotgg in pingdotgg/t3code#9102 ## New Contributors * @willsheldon made their first contribution in pingdotgg/t3code#9080 * @q1 made their first contribution in pingdotgg/t3code#9078 **Full Changelog**: pingdotgg/t3code@v0.0.37...v0.0.38 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.38
What Changed
Project settingsaction to thread context menus in the current and legacy sidebars.Why
Opening project settings from a thread currently requires finding its project separately in the sidebar. The thread already identifies its project, so the context menu can navigate there directly.
UI Changes
Before
After
Destination
Testing
Checklist
Made with GPT-5.6-Sol in T3 Code using the Codex harness.
Note
Low Risk
Navigation-only UI wiring with existing project-key resolution; wrong settings page would be the main failure mode if grouping keys were stale.
Overview
Adds a Project settings action to thread context and action menus so users can jump straight to the project settings page from a thread.
The new item is defined in
threadActionMenu.logic(after Copy, before Archive) with asettingsicon in the context-menu fallback. Choosing it navigates to/projects/$projectKey, closes the mobile sidebar when needed, and is wired in the main sidebar, legacy sidebar, anduseThreadActionMenu(chat header). Grouped sidebar projects resolve the correct logicalprojectKeyviaprojectGroupsRefand the physical-to-logical map; legacy sidebar uses the row’sproject.projectKey.Tests cover menu ordering and presence when lifecycle capabilities are disabled.
Reviewed by Cursor Bugbot for commit 450fa8b. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Add 'Project settings' item to thread context and action menus
project-settingsentry to the thread action menu, positioned after 'Copy' and before 'Archive', with asettingsicon in the fallback context menu/projects/$projectKeyfrom the sidebar, legacy sidebar, and chat header thread action menu; the sidebar closes on mobile when applicableuseThreadActionMenuhook resolves the logical project key via a physical-to-logical project map that respects current grouping settings, falling back to derivation when the map lacks an entryuseThreadActionMenurelies on a newprojectGroupsRefin Sidebar.tsx to avoid stale closures; if the ref is not kept in sync, the wrong project group may be selectedMacroscope summarized 450fa8b.