perf(provider): bound persisted session lookups

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}

[nateEc]

Fixes#8794.

listSessions enumerated every persisted thread and performed a binding lookup for each one, although it returns only sessions currently held by live provider adapters. The work grew with total thread history and stalled turn starts.

Look up bindings only for deduplicated active session thread ids. The regression test proves the historical thread scan is not invoked.

Verification: vp fmt --check, focused ProviderService tests (39 passing), and server typecheck (existing suggestions only).

Model and harness: GPT-5 Codex via Codex CLI.

---

Note

Low Risk
Narrow performance refactor on session listing with regression coverage; response shape stays tied to live adapter sessions, so omitting historical binding scans should not change observable output.

Overview
listSessions no longer walks every persisted thread via directory.listThreadIds(); it only calls getBinding for the deduplicated threadId values on sessions returned from live provider adapters, so work scales with active sessions instead of full thread history.

Tests inject a mock ProviderSessionDirectory (optional on makeProviderServiceLayer) and assert listThreadIds is never called while getBinding runs only for the active thread.

^{Reviewed by Cursor Bugbot for commit a319843. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Bound persisted session lookups in ProviderService.listSessions

• listSessions in ProviderService.ts no longer calls directory.listThreadIds(); it collects unique thread IDs from activeSessions and resolves bindings only for those via Effect.forEach over a Set.
• Adds tests in ProviderService.test.ts using a custom ProviderSessionDirectory service to verify listThreadIds is not called and getBinding runs only for active session thread IDs.
• Behavioral Change: sessions for persisted threads not in activeSessions are no longer returned by listSessions; callers depending on listing inactive/historical sessions will see fewer results.

^{Macroscope summarized a319843.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 161e66e7-5118-42bc-8aae-0e6e8b6d5c4c

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can activate Security or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at a319843

Macroscope's review found this PR approvable — This is a narrow performance fix that limits persisted binding reads to deduplicated sessions already reported by live adapters, preserving the active-session response path. The companion changes are test-only regression coverage, with no product-default, schema, security, billing, or deployment changes.

^{You can add or adjust custom eligibility rules. Learn more.}