feat(swift-ios): show skill invocations as pills by mackinleysmith · Pull Request #9071 · pingdotgg/t3code

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

mackinleysmith · 2026-09-01T17:52:37Z

What Changed

The SwiftUI client now renders known $skill invocations as labeled pills in the composer and sent chat messages. The underlying value stays plain text, so sending, selection, copy, and cut still use the original token.

Inline code, links, and unknown $tokens remain unchanged.

This is built on the caret fix in #8428. Until that PR lands, GitHub will show its small prerequisite commit in this branch too.

Why

Web and desktop already make skill invocations easy to spot. SwiftUI showed the raw token, which made the same message harder to scan and visually inconsistent across clients.

UI Changes

Surface	Before	After
Composer
Sent message

Verification

SwiftUI tests: 558 passed, 0 failed, 1 skipped
Built and exercised on an iPhone 17 Pro simulator against disposable local state
Verified the original $file-pr text survives composer edits and message rendering

Checklist

This PR is focused on SwiftUI skill-pill parity
I explained what changed and why
I included before/after screenshots for the UI changes
No animation or timing behavior changed, so a video is not needed

Created with GPT-5.6-Sol in T3 Code using the Codex harness.

Note

Medium Risk
Composer editing now depends on attributed-string projection and custom undo around pill sync; regressions could affect caret, undo, or what text is actually sent, though behavior is covered by new tests.

Overview
Recognized $skill tokens from the active provider now render as labeled inline pills in the composer and chat markdown, while the bound message text and send payload stay the original plain tokens.

A new inline-skill stack parses tokens, maps between plain-text and attachment display coordinates, and draws cached pill images as NSTextAttachments. Composer input takes a skills list, continuously re-syncs attributed text (including a trailing-token rule so a pill is not committed until a following space), reports selection in plain offsets, and registers custom undo/redo that restores source text, caret, and trailing pill state. Copy/cut on pill selections writes $skill text via FeatureInlineSkillTextView.

Thread transcript and MarkdownMessageView receive provider skills so rendered messages show pills too; parsing is skipped inside code and links and respects whitespace boundaries across formatted runs.

^{Reviewed by Cursor Bugbot for commit e64d785. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Add inline skill invocation pills to iOS composer and transcript

Adds a parser, renderer, and projection utility to turn $skill tokens into styled inline attachment pills in FeatureInlineSkillPill.swift.
Updates the chat composer in FeatureComposerTextInput.swift to synchronize the plain-text draft with the pill display text, projecting selections and managing undo/redo history across edits.
Renders known skill invocations as pills in Markdown transcript messages, excluding code blocks and links, via updates to MarkdownMessageView.swift.
Passes the selected provider's skills down through ThreadDetailView.swift to the composer and transcript cells.
Behavioral Change: Composer selection callbacks now report plain-text offsets, and copying or cutting a skill pill places the literal $skill text on the pasteboard instead of an attachment character.

^{Macroscope summarized e64d785.}

macroscopeapp · 2026-09-01T18:03:06Z

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces substantial automatic pill rendering and attributed-text editing behavior across the iOS composer and transcript, including custom selection and undo handling. An unresolved Medium-severity issue also allows disabled skills to appear as invocation pills.

Not approved because:

1 blocking correctness issue found at or above your repo's Minimum Blocking Severity

^{Adjust the Minimum Blocking Severity for this repo — including turning it Off — in Settings. You can add or adjust custom eligibility rules. Learn more.}

coderabbitai · 2026-09-01T18:29:45Z

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 039be2d6-97ca-4747-bcfd-c37efbc9018e

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

_{Comment @coderabbitai help to get the list of available commands.}

mackinleysmith · 2026-09-02T18:10:46Z

Hey, just acknowledging the failing CI Release Smoke phase: it looks like this was preexisting and will be fixed by #9240. Whenever that merges, I will rebase against the base branch.

cursor

Cursor Bugbot has reviewed your changes using high effort and found 2 potential issues.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit ad01975. Configure here.}

macroscopeapp · 2026-09-03T17:57:30Z

 placeholder: composerPlaceholder,
 acceptsImages: imagesAllowed,
 isReadOnly: voiceInputController.isBusy,
+ skills: powerFeatures.skills,


🟡 MediumChat/FeatureComposerView.swift:303
Typing a disabled skill token such as $disabled renders it as an invocation pill, even though that skill cannot be selected or used. expandedComposer passes disabled entries in powerFeatures.skills to the parser, which matches by name without checking isEnabled; filter the list before passing it.
🤖 Copy this AI Prompt to have your agent fix this:
In file @apps/swift-ios/Features/Chat/FeatureComposerView.swift around line 303: Typing a disabled skill token such as `$disabled ` renders it as an invocation pill, even though that skill cannot be selected or used. `expandedComposer` passes disabled entries in `powerFeatures.skills` to the parser, which matches by name without checking `isEnabled`; filter the list before passing it.

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 1, 2026

macroscopeappBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift

cursorBot reviewed Sep 1, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureInlineSkillPill.swift

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 4e612e5 to c0c69faCompare September 2, 2026 17:50

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/MarkdownMessageView.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

github-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026

cursorBot reviewed Sep 2, 2026
View reviewed changes

Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift
Comment threadapps/swift-ios/Features/Chat/FeatureComposerTextInput.swift

mackinleysmith mentioned this pull request Sep 2, 2026
fix(desktop): exclude opposite macOS pty prebuilds #9240
Merged

mackinleysmith added 5 commits September 3, 2026 11:24

feat(swift-ios): show skill invocations as pills
f9c9d8c

fix(swift-ios): harden inline skill boundaries
3e11d06

fix(swiftui): preserve code and undo around skill pills
d5b2590

fix(swiftui): balance composer undo registration
02ec0cd

fix(swiftui): preserve trailing pills through redo
4ebf88b

mackinleysmith force-pushed the t3code/swiftui-inline-invocation-pills branch from 70d6758 to 4ebf88bCompare September 3, 2026 17:26

fix(swift-ios): match web pill corners
e64d785

macroscopeappBot reviewed Sep 3, 2026
View reviewed changes

Uh oh!

Conversation

mackinleysmith commented Sep 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

UI Changes

Verification

Checklist

Add inline skill invocation pills to iOS composer and transcript

Uh oh!

Uh oh!

Uh oh!

macroscopeappBot commented Sep 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

coderabbitaiBot commented Sep 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

mackinleysmith commented Sep 2, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

macroscopeappBotSep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

mackinleysmith commented Sep 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What Changed

Why

UI Changes

Verification

Checklist

Add inline skill invocation pills to iOS composer and transcript

Uh oh!

Uh oh!

Uh oh!

macroscopeappBot commented Sep 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

coderabbitaiBot commented Sep 1, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

Uh oh!

Uh oh!

mackinleysmith commented Sep 2, 2026

Uh oh!

cursorBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

macroscopeappBotSep 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

mackinleysmith commented Sep 1, 2026•
edited
Loading

macroscopeappBot commented Sep 1, 2026•
edited
Loading

coderabbitaiBot commented Sep 1, 2026•
edited
Loading

mackinleysmith commented Sep 1, 2026•
edited
Loading

macroscopeappBot commented Sep 1, 2026•
edited
Loading

coderabbitaiBot commented Sep 1, 2026•
edited
Loading

mackinleysmith commented Sep 1, 2026•
edited
Loading

macroscopeappBot commented Sep 1, 2026•
edited
Loading

coderabbitaiBot commented Sep 1, 2026•
edited
Loading

mackinleysmith commented Sep 1, 2026•
edited
Loading