fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(claude): expand slash commands when a message has attachments - #9122

Merged
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments
Sep 3, 2026
Merged

fix(claude): expand slash commands when a message has attachments#9122
t3dotgg merged 1 commit into
mainfrom
fix/claude-command-expansion-with-attachments

Conversation

@t3dotgg

@t3dotggt3dotgg commented Sep 1, 2026

Copy link
Copy Markdown
Member

On the Claude provider, /skill args expanded normally on its own but was sent as literal text whenever the same message carried an image. The Claude CLI only treats a streamed user message as a slash command when the final content block is text, and the adapter put the text block first and appended image blocks after it.

buildUserMessageEffect now emits image blocks first and the text block last, so the command survives the attachment. Non-image file attachments never become content blocks, they reach the agent through the path line ProviderService writes into the prompt, and the regression test now covers that case too.

Supersedes #8271 by @lnieuwenhuis, rebased onto main. The rebase also needed a small test fix because attachmentRelativePath now returns string | null.

Closes#8013

Built by Claude Opus 5 in the Claude Code harness.


Note

Low Risk
Localized prompt assembly change in the Claude adapter with regression tests; affects message ordering to the SDK but not auth or persistence.

Overview
Fixes a regression where /skill args and similar slash commands were sent as literal text whenever the same user message included an image. The Claude CLI only treats a streamed user message as a command when the last content block is text; the adapter had been putting text first and appending image blocks after it.

buildUserMessageEffect now builds SDK content as optional leading prose (from $skill dispatch), then image blocks, then the final text block (command or full prompt). Non-image file attachments are unchanged—they still reach the agent via path lines in the prompt, not as content blocks.

Tests add readPromptMessages for multi-turn assertions, update the image-embedding expectation to image-then-text order, and cover slash commands with no attachment, with an image, and with a file attachment.

Reviewed by Cursor Bugbot for commit c02168a. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Fix slash command expansion on messages with image attachments in ClaudeAdapter

  • Reorders content-block construction in buildUserMessageEffect so image blocks are emitted before the final command or ordinary prompt text block, preventing attachments from suppressing slash command expansion.
  • Adds test helpers and assertions in ClaudeAdapter.test.ts to read multiple queued prompt messages and verify image blocks precede the text block while non-image attachments remain text-only.
  • Behavioral Change: buildUserMessageEffect now appends dispatched text after image blocks instead of before; messages without image blocks are unchanged.

Macroscope summarized c02168a.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:S 10-29 changed lines (additions + deletions). labels Sep 1, 2026
@github-actions

github-actionsBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.6 KiB13.6 KiB−17 B (−0.1%)15.1 KiB
CodexThread snapshot wire7.0 KiB7.0 KiB+8 B (+0.1%)7.3 KiB
CodexLive turn WebSocket wire6.6 KiB6.6 KiB−25 B (−0.4%)7.8 KiB
CodexLive turn WebSocket decoded57.1 KiB57.1 KiB0 B (0.0%)66.4 KiB
CodexLive turn messages10100 (0.0%)21
ClaudeTotal thread wire13.5 KiB13.6 KiB+66 B (+0.5%)15.1 KiB
ClaudeThread snapshot wire7.0 KiB7.0 KiB−3 B (−0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.5 KiB6.6 KiB+69 B (+1.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.9 KiB+88 B (+0.1%)66.4 KiB
ClaudeLive turn messages810+2 (+25.0%)21

Baseline: 4b26132 · PR result: c02168a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 113.8 KiB
  • Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

macroscopeappBot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at c02168a

Macroscope's review found this PR approvable — This is a focused Claude adapter bug fix that reorders image and text blocks so existing slash-command expansion continues to work with attachments. The production impact is confined to prompt construction, with targeted regression coverage and no defaults, schema, infrastructure, or sensitive-package changes.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeappBot previously approved these changes Sep 1, 2026
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 1ac4d62 to 02ccc26CompareSeptember 2, 2026 00:04
The Claude CLI only treats a streamed user message as a slash-command
invocation when the final content block is text; earlier blocks ride along
as preceding input blocks and survive the expansion. The adapter appended
image blocks after the text, so any turn carrying an attachment lost the
command silently.
Send the text block last so an image never displaces it.
@t3dotgg
t3dotggforce-pushed the fix/claude-command-expansion-with-attachments branch from 02ccc26 to c02168aCompareSeptember 3, 2026 09:22
@macroscopeapp
macroscopeappBot dismissed their stale reviewSeptember 3, 2026 09:22

Dismissing prior approval to re-evaluate c02168a

@t3dotgg
t3dotgg merged commit 18573d6 into mainSep 3, 2026
26 checks passed
@t3dotgg
t3dotgg deleted the fix/claude-command-expansion-with-attachments branch September 3, 2026 09:28
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* fix(web): keep trailing tool groups out of "Worked for" accordion by @Yash-Singh1 in pingdotgg/t3code#9384
* feat(marketing): put named-developer quotes on the landing page by @t3dotgg in pingdotgg/t3code#9385
* fix(claude): expand slash commands when a message has attachments by @t3dotgg in pingdotgg/t3code#9122
* fix(web): stop the resting composer layout loop by @t3dotgg in pingdotgg/t3code#9393
* fix(web): render assistant images inline in chat by @t3dotgg in pingdotgg/t3code#9126
* feat(providers): add Google Antigravity via the official ACP agent by @t3dotgg in pingdotgg/t3code#9348
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1267...v0.0.39-nightly.20260903.1268
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1268
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S10-29 changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Attaching an image silently disables slash-command/skill expansion for the whole message (Claude provider)

2 participants

@t3dotgg@lnieuwenhuis