chore: remove unused code and brittle tests by t3dotgg · Pull Request #9150 · pingdotgg/t3code

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

t3dotgg · 2026-09-02T00:48:53Z

The codebase still had unused helpers, compatibility aliases, and tests that exercised dead code or repeated markup and class strings.

This cleanup removes the unused code, stale setup, redundant direct dependencies, old release comments, and tests for dead paths. It removes selected class-string assertions and circular mock assertions while keeping tests for observable behavior.

This deletes five unreferenced marketing assets, totaling 1,255,570 bytes. No repository code references these files, but unknown external links to their public URLs can still exist.

Verification:

561 focused tests passed across 21 files: 419 web tests, 92 server tests, and 50 desktop WSL tests.
Web, server, mobile, and desktop package typechecks passed.
Targeted lint passed for the changed TypeScript and TSX files.
vp fmt --check passed for 31 changed text and config files.
git diff origin/main...HEAD --check passed.

Changes made by GPT-5.6 Sol in Codex.

Note

Low Risk
Mostly deletions and test loosening; the only API surface change is ProviderAdapterRegistryShape, which could affect external consumers but in-tree call sites were updated.

Overview
This PR is a repo-wide dead-code and test-hygiene pass: it deletes unreferenced helpers, migration-era provider APIs, mobile terminal bootstrap logic, marketing tweet links, and a few direct dependencies that nothing imports anymore.

On the server, ProviderAdapterRegistry drops listProviders and streamChanges, docs narrow to instance-id routing only, and mocks/tests follow. TextGenerationShape / TextGenerationService go away in favor of TextGeneration["Service"]. @effect/platform-node-shared is removed from apps/server.

Mobile loses resolveTerminalRouteBootstrap (module + tests) and @noble/hashes. Release workflow drops a large block of commented Windows updater manifest merge steps. Web removes many unused exports (cloud link helpers, provider UI helpers, keybinding shortcuts, draft finalization batch helper, etc.) and trims tests that asserted Tailwind class strings or layout implementation details while keeping behavioral checks. Desktop WSL install-script tests drop assertions tied to removed script behavior (effect package check, lock PID/sleep). apps/marketing/tweets.md is deleted; vite.config.ts stops ignoring mockServiceWorker.js in format checks.

^{Reviewed by Cursor Bugbot for commit ea2122a. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Remove unused exports, legacy registry methods, and brittle markup tests

Removes unused helpers and exports across apps/web, apps/server, and apps/mobile (e.g. readPrimaryCloudLinkTarget, listCloudDevices, resolveTerminalRouteBootstrap, shouldHighlightDesktopUpdateError, isPreviewToggleShortcut)
Removes legacy listProviders and streamChanges from ProviderAdapterRegistryShape and its facade, mocks, and tests; the registry still provides instance lookup, metadata, listing, and sync change subscriptions
Replaces the deprecated TextGenerationShape alias with the TextGeneration service type in server tests and the harness; deletes the separate TextGenerationService interface
Drops direct @noble/hashes and @effect/platform-node-shared catalog dependencies from apps/mobile and apps/server
Removes over-specified markup/layout tests in ComposerCommandMenu, ComposerPrimaryActions, MessagesTimeline, ChangedFilesCard, and the hosted onboarding header suite so tests stop asserting brittle CSS and ordering details
Risk: out-of-tree consumers of the removed listProviders/streamChanges members or deleted exports will break; verify no remaining imports in ProviderAdapterRegistry.ts, providerModels.ts, composer-logic.ts, and the other removed-export modules

^{Macroscope summarized ea2122a.}

github-actions · 2026-09-02T00:51:05Z

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.3 KiB	13.3 KiB	−17 B (−0.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	6.9 KiB	6.9 KiB	+2 B (+0.0%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−19 B (−0.3%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	55.6 KiB	55.6 KiB	0 B (0.0%)	66.4 KiB	✅
Codex	Live turn messages	10	10	0 (0.0%)	21	✅
Claude	Total thread wire	13.3 KiB	13.3 KiB	−10 B (−0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	6.9 KiB	6.9 KiB	−7 B (−0.1%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.4 KiB	6.4 KiB	−3 B (−0.0%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	56.4 KiB	56.4 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	10	10	0 (0.0%)	21	✅

Baseline: 716069f · PR result: ea2122a · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

Codex decoded thread snapshot: 109.4 KiB
Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

macroscopeapp

All findings are inline. Common thread: the removals in apps/web/src correctly delete unreferenced exports (verified no remaining consumers at head), but several deleted test blocks were the only coverage of virtualized-scroll and stateful-styling contracts that the production components still implement.

^{Posted via Macroscope — UI Consistency}

macroscopeapp · 2026-09-02T00:55:45Z

Approvability

Verdict: Approved at ea2122a

Macroscope's review found this PR approvable — This is a deletion-focused cleanup with production components, defaults, workflows, and wire contracts left unchanged; active provider-instance behavior is preserved. The main tradeoff is reduced implementation-level test coverage, with only limited compatibility risk for unsupported out-of-tree imports.

^{You can add or adjust custom eligibility rules. Learn more.}

t3dotgg · 2026-09-02T01:30:43Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope Please re-evaluate approvability on head ea2122aa0a259ff80f317e6db5425214bfe5a356. We verified each prior UI finding against the source, replied with the evidence, and resolved all four threads. The latest UI review reports no new findings and accepts the stated reasons. Please use those resolved threads and the latest UI review when you assess this revision.

macroscopeapp · 2026-09-02T01:31:31Z

Just FYI for future @mentions, I'm Macroscope-App, not Macroscope.

Re-evaluated at ea2122a: not approved. The removed assertions remain the only coverage for timeline anchoring/fade and composer-menu/send-button contracts; the remaining tests do not exercise equivalent behavior. The resolved UI findings do not change that coverage gap.

t3dotgg · 2026-09-02T01:34:58Z

Note

🤖 GPT-5.6 Sol responding on behalf of Theo

@macroscope-app Please rerun the Approvability check on head ea2122a and assess this intentional test cleanup under the repository's committed policy. AGENTS.md line 107 prohibits static markup assertions for props or attributes, callback-wiring-only tests, and tests that mirror implementation. This PR removes those tests without changing the runtime components or CSS. Equivalent class and mock assertions are therefore not the required outcome.

macroscopeapp · 2026-09-02T01:35:10Z

Manual reviews triggered for commit ea2122a:

^{All prior checks · these links stay valid even if you push more commits.}

macroscopeapp · 2026-09-02T01:35:41Z

Rerun initiated. The cited policy does prohibit the static-markup, attribute, callback-wiring, and implementation-mirroring assertions removed here; the Approvability result will update when the check completes.

…e skill snapshots, sticky model defaults, code-block copy fix, tool group scrolling, error report copy) Upstream b8262b4..827345a. Conflicts resolved keep-both: - ProviderCommandReactor: keep fork's model-changed notice + handedOff return, add upstream's refreshWorkspaceSnapshot on session reuse. - Migrations: upstream 044_ClearAutomaticProjectModelDefaults registered as fork id 48 (behind 041-047); its 016 test renumbered 43/44 -> 47/48. - contracts/server + ProviderDriver + ProviderRegistry.test: fork's on-demand listWorkspaceCapabilities coexists with upstream's cached workspaceSnapshots / snapshotForCwd. - composerProviderState: MT Auto guard kept; available branch now uses upstream's buildExplicitProviderOptionSelectionsFromDescriptors. - SidebarChrome: BrandWordmark (MT mark) kept, renders upstream's shared T3Wordmark component for the T3 distro. - markdown-clipboard.test: FakeElement.querySelector handles both the fork's KaTeX annotation selector and upstream's :scope/checkbox forms. - TextGeneration: drop the unused Promise-based TextGenerationService (upstream pingdotgg#9150), keep PullRequestRanking types. Drops fixed: cli/project.ts still called the deleted getAutoBootstrapDefaultModelSelection (project.create no longer seeds a model, per upstream pingdotgg#9164). build-desktop-artifact.test: the winWithoutWslPrebuild expectation now lists the fork's t3-desktop-mcp and app-icons resources like the win case. Backup: backup/mtcode-pre-upstream-sync-20260902.

The nightly merge resolution restored three tests and a block of LegendList mock surface that upstream deleted in pingdotgg#9150 as brittle and unused. None of them is fork work, and no remaining assertion touches the restored mock, so carrying them forward only guarantees the same conflict next nightly in the file that holds the fork's reply-to-block tests. Yield to upstream there. The fork's reply tests are untouched.

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

github-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:L 100-499 changed lines (additions + deletions). labels Sep 2, 2026

macroscopeappBot reviewed Sep 2, 2026
View reviewed changes

chore: remove unused code and brittle tests
ea2122a

t3dotgg force-pushed the t3code/audit-codebase-slop-1 branch from 4eb248b to ea2122aCompare September 2, 2026 01:26

macroscopeappBot approved these changes Sep 2, 2026
View reviewed changes

juliusmarminge merged commit db4bf94 into mainSep 2, 2026
27 checks passed

juliusmarminge deleted the t3code/audit-codebase-slop-1 branch September 2, 2026 04:43

berghtho mentioned this pull request Sep 2, 2026
chore(upstream): sync 2026-09-02 berghtho/t3code#20
Draft

Uh oh!

Conversation

t3dotgg commented Sep 2, 2026• edited by macroscopeapp BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Remove unused exports, legacy registry methods, and brittle markup tests

Uh oh!

github-actionsBot commented Sep 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thread transfer impact

Uh oh!

macroscopeappBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeappBot commented Sep 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

t3dotgg commented Sep 2, 2026

Uh oh!

macroscopeappBot commented Sep 2, 2026

Uh oh!

t3dotgg commented Sep 2, 2026

Uh oh!

macroscopeappBot commented Sep 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeappBot commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

t3dotgg commented Sep 2, 2026• edited by macroscopeapp BotLoading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Remove unused exports, legacy registry methods, and brittle markup tests

Uh oh!

github-actionsBot commented Sep 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Thread transfer impact

Uh oh!

macroscopeappBot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

macroscopeappBot commented Sep 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Approvability

Uh oh!

t3dotgg commented Sep 2, 2026

Uh oh!

macroscopeappBot commented Sep 2, 2026

Uh oh!

t3dotgg commented Sep 2, 2026

Uh oh!

macroscopeappBot commented Sep 2, 2026• edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

macroscopeappBot commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

t3dotgg commented Sep 2, 2026•
edited by macroscopeapp Bot
Loading

github-actionsBot commented Sep 2, 2026•
edited
Loading

macroscopeappBot commented Sep 2, 2026•
edited
Loading

macroscopeappBot commented Sep 2, 2026•
edited
Loading

t3dotgg commented Sep 2, 2026•
edited by macroscopeapp Bot
Loading

github-actionsBot commented Sep 2, 2026•
edited
Loading

macroscopeappBot commented Sep 2, 2026•
edited
Loading

macroscopeappBot commented Sep 2, 2026•
edited
Loading

t3dotgg commented Sep 2, 2026•
edited by macroscopeapp Bot
Loading

github-actionsBot commented Sep 2, 2026•
edited
Loading

macroscopeappBot commented Sep 2, 2026•
edited
Loading

macroscopeappBot commented Sep 2, 2026•
edited
Loading

t3dotgg commented Sep 2, 2026•
edited by macroscopeapp Bot
Loading

github-actionsBot commented Sep 2, 2026•
edited
Loading