chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

chore: bump vendored GhosttyKit and update terminal integration - #9155

Merged
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump
Sep 2, 2026
Merged

chore: bump vendored GhosttyKit and update terminal integration#9155
Yash-Singh1 merged 1 commit into
mainfrom
yash/ghostty-bump

Conversation

@Yash-Singh1

@Yash-Singh1Yash-Singh1 commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

What Changed

  • Bumped the vendored GhosttyKit to revision cf8edc23f3a6a87a96e41a90013e89e987d34980.
  • Updated the iOS terminal build script, native headers, Swift integration, and third-party notices for the new Ghostty API and Zig 0.16.0.
  • Added mobile terminal panel support and related file, review, settings, connection, and state updates.
  • Simplified desktop update release-note normalization by removing omitted-count metadata and improving boilerplate filtering.
  • Added cursor-following preview label positioning logic with viewport clamping and flipping.
  • Updated supporting server, web, client-runtime, tests, and documentation to match the revised contracts and runtime behavior.

Why

The vendored GhosttyKit needs to be refreshed to incorporate the newer custom-I/O and live-padding implementation used by the mobile terminal. The integration changes keep the native terminal contract aligned with the updated library while enabling the associated mobile terminal experience.

The accompanying client and server changes update consumers of revised state and API contracts, remove obsolete release-note metadata, and improve behavior around previews, reviews, settings, and remote runtime state.

UI Changes

  • Added the mobile thread terminal panel.
  • Added cursor-following element-picker labels with edge clamping and vertical flipping.
  • Updated mobile settings, file/review surfaces, and related web update/sidebar behavior.

Before/after screenshots and interaction video are not included.

Checklist

  • This PR is small and focused
  • I explained what changed and why
  • I included before/after screenshots for any UI changes
  • I included a video for animation/interaction changes

Note

Medium Risk
Replaces the native iOS terminal binary and C ABI (clipboard/runtime callbacks); regression risk is mainly rendering, input, and resize on device/simulator rather than app-layer JS.

Overview
Refreshes the mobile iOS terminal’s vendored GhosttyKit.xcframework to revision cf8edc23, sourced from VVTerm’s custom-I/O and live-padding Ghostty lineage (t3code/custom-io-ordered-feed), and documents the new pin in README.md, THIRD_PARTY_NOTICES.md, and Vendor/libghostty/VERSION.

The iOS rebuild path now targets Zig 0.16.0, copies libghostty-internal.a from the upstream xcframework (still installed as libghostty-fat.a in vendor), syncs updated headers, and strips trailing whitespace on ghostty.h. The vendored framework drops bundled ghostty/vt/* headers that shipped inside the xcframework previously.

ghostty.h moves to a newer internal embedder ABI (richer clipboard types, new runtime actions, ghostty_config_key_is_binding on config instead of app). T3TerminalView is updated so the runtime read_clipboard_cb matches the new signature and reports GHOSTTY_CLIPBOARD_READ_UNSUPPORTED, since selection clipboard is not supported on mobile.

Reviewed by Cursor Bugbot for commit b0a87f5. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Bump vendored GhosttyKit and update t3-terminal integration

  • Updates the vendored ghostty.h headers and static libraries to a new pinned revision from VVTerm's custom-I/O/live-padding branch
  • Expands the clipboard API with PRIMARY kind, explicit byte lengths, Kitty read/write and list request kinds, completion/confirmation payloads, and ghostty_surface_deny_clipboard_request; the read callback now receives MIME types and a permission flag and returns a ghostty_clipboard_read_result_e
  • Adds ExportTerminalIO action type plus set-window-title, selection-changed, move-tab-to-new-window, and open-config action tags; adds new-tab and toggle-quick-terminal IPC action tags
  • Moves key-binding queries from ghostty_app_key_is_binding to ghostty_config_key_is_binding; removes the translated-key member from the input trigger payload union
  • Updates T3TerminalView.swift to return the explicit unsupported clipboard-read result; updates build-libghostty-ios16.sh to Zig 0.16.0 and internal archive names
  • Risk: callers of the removed ghostty_app_key_is_binding and the old clipboard-read/confirmation callback signatures will fail to compile; the deleted ghostty/vt/osc.h header may break in-tree consumers that include it directly

Macroscope summarized b0a87f5.

- Update GhosttyKit binaries and headers
- Document the new Ghostty revision and build toolchain
@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XXL 1,000+ changed lines (additions + deletions). 📱 Native Change Changes the native fingerprint; merging blocks production OTAs until a new store build ships. labels Sep 2, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

ProviderMetricMain baselineThis PRImpactPR ceiling
CodexTotal thread wire13.1 KiB13.3 KiB+154 B (+1.1%)15.1 KiB
CodexThread snapshot wire6.9 KiB6.9 KiB−3 B (−0.0%)7.3 KiB
CodexLive turn WebSocket wire6.2 KiB6.4 KiB+157 B (+2.5%)7.8 KiB
CodexLive turn WebSocket decoded54.7 KiB55.6 KiB+910 B (+1.6%)66.4 KiB
CodexLive turn messages810+2 (+25.0%)21
ClaudeTotal thread wire13.4 KiB13.5 KiB+6 B (+0.0%)15.1 KiB
ClaudeThread snapshot wire6.9 KiB6.9 KiB+3 B (+0.0%)7.3 KiB
ClaudeLive turn WebSocket wire6.6 KiB6.6 KiB+3 B (+0.0%)7.8 KiB
ClaudeLive turn WebSocket decoded57.8 KiB57.8 KiB0 B (0.0%)66.4 KiB
ClaudeLive turn messages10100 (0.0%)21

Baseline: 8efd4e9 · PR result: b0a87f5 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

  • Codex decoded thread snapshot: 109.4 KiB
  • Claude decoded thread snapshot: 110.1 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

@macroscopeapp

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR replaces the production iOS terminal engine with a new fork-specific native binary and updates several ABI contracts, including clipboard callbacks. Rendering, input, resizing, and clipboard behavior inside the opaque replacement library cannot be fully verified from the repository diff.

You can add or adjust custom eligibility rules. Learn more.

@Yash-Singh1Yash-Singh1 changed the title Bump vendored GhosttyKit and update terminal integrationchore: bump vendored GhosttyKit and update terminal integrationSep 2, 2026
@Yash-Singh1
Yash-Singh1 merged commit f9d1c65 into mainSep 2, 2026
22 checks passed
@Yash-Singh1
Yash-Singh1 deleted the yash/ghostty-bump branch September 2, 2026 05:57
@Yash-Singh1
Yash-Singh1 restored the yash/ghostty-bump branch September 2, 2026 05:57
q1 added a commit to q1/q1code that referenced this pull request Sep 3, 2026
The carried PR head compiles against the GhosttyKit.xcframework it links
from apps/mobile/modules/t3-terminal/Vendor/libghostty, and upstream's
GhosttyKit bump (pingdotgg#9155) changed ghostty_runtime_config_s.read_clipboard_cb
from a three-argument Bool callback to a six-argument callback returning
ghostty_clipboard_read_result_e. TerminalSurfaceView still passed the old
closure, so the T3Code target failed to compile:
TerminalSurfaceView.swift:744: contextual closure type ... expects 6
arguments, but 3 were used in closure body
Return GHOSTTY_CLIPBOARD_READ_UNSUPPORTED with the new signature, matching
apps/mobile/modules/t3-terminal/ios/T3TerminalView.swift. The iOS app never
serves clipboard reads to the terminal, so behavior is unchanged.
Fork-Feature: swift-ios
Upstream: candidate
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

📱 Native ChangeChanges the native fingerprint; merging blocks production OTAs until a new store build ships.size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@Yash-Singh1