fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

fix(pull-requests): missing features & better behaviour - #9188

Merged
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states
Sep 3, 2026
Merged

fix(pull-requests): missing features & better behaviour#9188
maria-rcks merged 1 commit into
pingdotgg:mainfrom
maria-rcks:t3code/complete-pr-merge-states

Conversation

@maria-rcks

@maria-rcksmaria-rcks commented Sep 2, 2026

Copy link
Copy Markdown
Collaborator

pull request actions were incomplete while ci was blocked, fork workflow approvals were invisible, merged controls disappeared, and list state reset during navigation. this adds provider-backed auto-merge strategies, github workflow approval and revert actions, truthful action-required checks, persistent merged and closed controls, combined comment-and-close/reopen actions, saved list preferences, stable right-panel selection while the list changes, and a default merge-readiness order that puts green approved work first, breaks readiness ties by the smallest diff, and puts conflicts last. github merge commits no longer show line counts that include base-branch history.

verified with 519 focused assertions, contract/server/web typechecks, targeted lint, a production web build, and a live github-provider pass.

workflow approval

workflow approval action and four workflows awaiting approval

pending checks and auto-merge strategy

auto-merge squash action while checks are running

merged state and revert

persistent merged state and revert action

close or reopen with a comment

close with comment on an open pull request

reopen with comment on a closed pull request

default merge-readiness order

approved, passing pull requests ordered from the smallest diff upward

merge commits without imported base stats

merge-from-main timeline entry without misleading imported line counts

panel stays open across list changes

selected pull request retained after the authored filter removes it from the list

filters and project restored after leaving and returning

restored pull request filters and t3code project with a neutral count badge

sort restored after leaving and returning

restored largest-first sort

generated with gpt-5.6-sol in T3 Code through the Codex harness.


Note

Medium Risk
New GitHub workflow-approval paths depend on head-SHA scoping and refusal logic; mistakes could approve wrong runs or hide blocked CI. Default list sort and persisted filters change behavior for all users.

Overview
GitHub pull requests gain revert (GraphQL) and approve-workflows, which finds action_required Actions runs on fork heads, refuses unsafe scopes (ambiguous head, huge lists, head moved), and POSTs approvals. Detail reads now include isCrossRepository, headRefOid, and autoMergeMethod; fork workflows missing from the rollup are merged into checks with workflowApprovalsRequired.

Azure DevOps / GitLab / shared models surface autoMergeMethod when the host reports it; Azure enable-auto-merge only sends --squash when a merge method is chosen.

Web UI retools the header merge slot (resolvePullRequestPrimaryControl: auto-merge when checks aren’t green, armed badge, merged/closed state), adds Approve workflows, Revert, Merge now, comment close/reopen, and clearer action-required check copy. List filters/sort persist in localStorage; default sort ready ranks green+approved first, smallest diff within a tier, conflicts last. Sidebar navigation restores saved list prefs.

Check/decoding fixes:ACTION_REQUIRED is no longer treated as failure; merge commits drop misleading line stats in review threads.

Reviewed by Cursor Bugbot for commit 051cf03. Bugbot is set up for automated code reviews on this repo. Configure here.

Note

Add revert and approve-workflows actions and readiness sort to PRs

  • Added revert and approve-workflows to the pull request action contract and implemented them for GitHub. Revert calls the GitHub revertPullRequest mutation. Approve-workflows finds and approves action-required workflow runs for fork pull requests.
  • Added autoMergeMethod and workflowApprovalsRequired to pull request details. Azure DevOps, GitHub, and GitLab providers now decode and report the host's auto-merge strategy.
  • Added action-required to check statuses. Checks with this status roll up as pending in the web UI, and workflow approval checks display as "awaiting approval".
  • Added merge-readiness as the default list sort in the web UI and persisted list preferences using local storage.
  • Risk: GitHub merge commits no longer contribute to commit stats. Azure DevOps auto-merge without a method no longer sends squash=false. CLI argument builders throw for unsupported revert or approve-workflows actions.

Macroscope summarized 051cf03.

@github-actionsgithub-actionsBot added vouch:trusted PR author is trusted by repo permissions or the VOUCHED list. size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/sidebar/SidebarChrome.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.test.ts Outdated
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Not approved

Macroscope's review found this PR not approvable — This PR introduces several production-facing pull-request capabilities and external mutations, while also changing the default list ordering and adding static-analysis suppressions in tests. The breadth and persistent behavior changes warrant human review.

Not approved because:

  • Per-PR cost limit exceeded (workspace setting). Approvability relies on correctness review in order to determine eligibility

Review your spending limits in Billing settings, or comment @macroscope-app review this PR to bypass the limit and review now. You can add or adjust custom eligibility rules. Learn more.

@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 3f003d3 to d270d9cCompareSeptember 2, 2026 07:50
@maria-rcksmaria-rcks changed the title feat(pull-requests): complete merge and workflow statesfix(pull-requests): missing features & better behaviourSep 2, 2026
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts Outdated
Comment threadapps/web/src/components/pullRequest/pullRequestPresentation.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from d270d9c to c33b2ffCompareSeptember 2, 2026 07:54
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/AzureDevOpsPullRequestCli.ts
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 31fd045 to fdfacafCompareSeptember 2, 2026 08:02
Comment threadapps/server/src/pullRequest/azureDevOpsPullRequestJson.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fdfacaf to 8642f08CompareSeptember 2, 2026 08:07
Comment threadapps/web/src/components/pullRequest/pullRequestDetail.logic.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 8642f08 to 81e974cCompareSeptember 2, 2026 08:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 81e974c to 6bd215aCompareSeptember 2, 2026 08:12
Comment threadapps/server/src/pullRequest/gitLabMergeRequestJson.ts Outdated
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 6bd215a to aa244e6CompareSeptember 2, 2026 08:21
@github-actionsgithub-actionsBot added size:XXL 1,000+ changed lines (additions + deletions). and removed size:XL 500-999 changed lines (additions + deletions). labels Sep 2, 2026
Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
Comment threadapps/web/src/routes/_chat.pull-requests.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ac1a4d7 to ea4a56cCompareSeptember 2, 2026 09:55
Comment threadapps/web/src/components/pullRequest/pullRequestListPreferences.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from ea4a56c to fed464bCompareSeptember 2, 2026 10:09
Comment threadapps/server/src/pullRequest/GitHubPullRequestProvider.ts Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from fed464b to 1a17c3fCompareSeptember 2, 2026 10:21
Comment threadapps/server/src/pullRequest/GitHubPullRequestCli.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 1a17c3f to d454c30CompareSeptember 2, 2026 10:36
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from c3664ce to 76d5051CompareSeptember 2, 2026 21:42
@macroscopeapp

macroscopeappBot commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Macroscope skipped reviewing this pull request. Per-PR cost limit exceeded (workspace setting).

Reviews on this PR have cost $49.04 so far. This review would add an estimated $4.62, bringing the total to $53.66 — above your per-PR limit of $50.00.

Tip

To get this pull request reviewed, you can:

  1. Comment @macroscope-app on this PR to request a manual review (monthly spend limits still apply).
  2. Exclude large or generated files from review by adding a pattern to your .macroscope/ignore.md — note that creating this file replaces Macroscope's built-in default ignores rather than extending them.
  3. Raise your cost limit in your workspace billing settings.

Turn off this reminder going forward

Comment threadapps/web/src/components/pullRequest/PullRequestDetailPanel.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 033b064 to 82a6572CompareSeptember 2, 2026 22:17
Comment threadapps/web/src/components/pullRequest/PullRequestSummaryTab.tsx Outdated
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 3 times, most recently from 02d0abc to 211f305CompareSeptember 2, 2026 22:36
Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch 2 times, most recently from 42019e1 to 7fa1d8cCompareSeptember 2, 2026 22:57

@cursorcursorBot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7fa1d8c. Configure here.

Comment threadapps/web/src/components/pullRequest/pullRequestList.logic.ts
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from 7fa1d8c to a45732fCompareSeptember 2, 2026 23:10
@maria-rcks
maria-rcksforce-pushed the t3code/complete-pr-merge-states branch from a45732f to 051cf03CompareSeptember 2, 2026 23:13
@maria-rcks
maria-rcks merged commit 443b4eb into pingdotgg:mainSep 3, 2026
27 checks passed
github-actionsBot added a commit to omarcresp/t3code-flake that referenced this pull request Sep 3, 2026
## What's Changed
* feat(desktop): browser profiles for the preview browser by @juliusmarminge in pingdotgg/t3code#7254
* refactor(shared): move the node:sqlite Effect SQL client into shared by @juliusmarminge in pingdotgg/t3code#7272
* feat(web): add opt-in panel animations by @maria-rcks in pingdotgg/t3code#8830
* feat(projects): automatically pull clean default branches by @maria-rcks in pingdotgg/t3code#9277
* fix(web): show pull request state icons in tabs by @flamboh in pingdotgg/t3code#9112
* feat(providers): add context compaction across harnesses by @maria-rcks in pingdotgg/t3code#8808
* feat(web): add proactive panels by @maria-rcks in pingdotgg/t3code#9276
* fix(web): unify control sizing across settings pages by @juliusmarminge in pingdotgg/t3code#9281
* fix(web): offer browser profiles from the empty-panel launcher by @juliusmarminge in pingdotgg/t3code#9279
* Revert "feat(providers): add context compaction across harnesses" by @maria-rcks in pingdotgg/t3code#9284
* fix(web): show scroll-to-end as soon as the last message slips under the composer by @juliusmarminge in pingdotgg/t3code#9280
* fix(cursor): honor auto and full access modes by @maria-rcks in pingdotgg/t3code#9283
* fix(desktop): detect installed Spectre libs for Windows builds by @juliusmarminge in pingdotgg/t3code#9285
* fix(pull-requests): missing features & better behaviour by @maria-rcks in pingdotgg/t3code#9188
* fix(providers): discover workspace skills everywhere by @maria-rcks in pingdotgg/t3code#9180
* fix(server): preserve automatic settlement timestamps by @eimexdev in pingdotgg/t3code#9254
* fix(opencode): show Reasoning selector for OpenCode models by @maria-rcks in pingdotgg/t3code#9287
* feat(web): preview document attachments in the file viewer by @juliusmarminge in pingdotgg/t3code#9292
* chore(ci): narrow the UI consistency check-run agent by @juliusmarminge in pingdotgg/t3code#9297
**Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260902.1261...v0.0.39-nightly.20260903.1262
Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1262
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XXL1,000+ changed lines (additions + deletions).vouch:trustedPR author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@maria-rcks