fix(web): stablize merge button with merged chip

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!

[flamboh]

Note

🤖 Fable 5 on behalf of Oliver

What Changed

The Merge button now stays pending until refreshed PR data confirms the merge, then becomes a solid violet "Merged" marker that persists on every merged PR, so opening one shows the outcome where the action used to be (thanks @Bil0000!). The merge success toast only fires as a fallback on hosts that confirm merges asynchronously (e.g. Azure DevOps), where the marker has to yield before the host catches up.

The action lifecycle lives in packages/client-runtime/src/state/pullRequestActionState.ts with transitions tracked by per-PR atoms.

Why

The merge command finished before the detail refresh, so stale open-state data briefly made the Merge button clickable again.

UI Changes

Before

prb_before.mp4

After

prb_after.mp4

Checklist

• This PR is small and focused
• I explained what changed and why
• I included before/after screenshots for any UI changes
• I included a video for animation/interaction changes

---

Built by GPT-5.6-sol (Codex CLI) and Claude Fable 5 (Claude Code) in T3 Code, with the merged-button presentation contributed by @Bil0000.

Note

Stabilize PR merge button with merged chip via shared action state

• Adds a per-pull-request action state atom family in pullRequestActionState.ts that tracks pending action and a merge hold, reconciled by observePullRequestDetail from incoming detail reads.
• Introduces usePullRequestActionState and pullRequestMergeButtonPresentation so PullRequestDetailPanel.tsx shows a disabled, violet-toned "Merged" chip during merge hold or once the host reports merged, and "Merging..." only while the merge is in-flight.
• Defers the merge success toast until the merge hold clears for the same PR; non-merge action toasts stay immediate.
• Risk: merge hold clears only when observePullRequestDetail sees detail state leave open or settle open after a pending read; if the host never delivers such a read, the hold persists — verify the reconciliation logic in observePullRequestDetail.

^{Macroscope summarized 4ae02b4.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Team

Run ID: 0d1a64f8-9abb-4f83-9678-afda7307e213

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

Warning

Your free Security trial is over. An organization admin can upgrade to Advanced for continuous pull request security review or dismiss this notice.

---

_{Comment @coderabbitai help to get the list of available commands.}

[macroscopeapp]

Approvability

Verdict: Approved at 4ae02b4

Macroscope's review found this PR approvable — This is a focused client-side fix that stabilizes the existing merge control and shows a confirmed merged state. Its finite per-PR state tracking and presentation logic are tested, while merge RPC behavior, schemas, and deployment remain unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

Dismissing prior approval to re-evaluate 3c20061

Dismissing prior approval to re-evaluate 592e3b9

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

Two findings on the new pending lifecycle. The state-scoping and the awaiting-detail effect themselves look sound: pendingAction is keyed by pullRequestKey like the other panel scopes, each predicate is false in the state its action is offered from, and the manual Refresh menu item stays enabled, so the pending window cannot be wedged with no way out.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate 9fdf68d

[macroscopeapp]

One finding on the extended pending window introduced for merge. Everything else in the diff (per-pull-request keying of pendingAction, identity-guarded clears, the activePendingAction label read) is consistent with the panel's existing "only the pressed control speaks" contract.

^{Posted via Macroscope — UI Consistency}

[macroscopeapp]

One finding on the merge-completion suppression: the header's primary control is unmounted rather than shown in a resolved state, and the suppression only lifts on a non-open detail, so a host that keeps reporting the pull request as open leaves the slot permanently empty.

^{Posted via Macroscope — UI Consistency}

Dismissing prior approval to re-evaluate c2a2401

[maria-rcks]

pls never record the videos like that, NEVER; they make it hard to see what actually changed

[flamboh]

@maria-rcks yeah sorry you're definitely right, I'll put new ones in a sec

[flamboh]

@maria-rcks fixed, should be pretty clear now. Again, sorry. Got carried away with the Cap default edits on the vid.

[macroscopeapp]

One finding on the new merged-button tone. The lifecycle rework itself reads consistently with the panel's contracts: the hold is per-pull-request, only the Merge control is suppressed while it is held, and detailQuery.isPending is the waiting flag of the AsyncResult (true on a refresh() refetch that already has data), so the post-merge read does arm and then clear the bound.

^{Posted via Macroscope — UI Consistency}

[Bil0000]

@flamboh would be cool if you update your vid/img in the desc too 🫡

[flamboh]

@Bil0000 working on that already!

[macroscopeapp]

The reworked hold itself checks out: useEnvironmentQuery.isPending maps to AsyncResult.waiting, so the refreshDetail() a merge takes does flip it true and then false, and observePullRequestDetail bounds the hold on that read regardless of which refresh path ran — the earlier unbounded-hold and per-PR-overwrite findings are addressed. Two findings on how the completed state is presented once it clears, inline.

^{Posted via Macroscope — UI Consistency}

[flamboh]

@Bil0000 is it intended that the "Merged" button is only shown briefly?

I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

[Bil0000]

@Bil0000 is it intended that the "Merged" button is only shown briefly? I'd expect something similar to the above, so there's a bit more clarity that the PR is merged. Right now the only part of the UI showcasing the successful merge is the small merged icon, and the lack of the button to merge.

Change it however you like, & add some after media, will take a look then & let you know my thoughts ;)

[flamboh]

@Bil0000 see new after video, macroscope approved as well!

[maria-rcks]

closed because of #9188 (sorry)

[flamboh]

@maria-rcks LOL no it's all good. Glad it got fixed!!