Uh oh!
There was an error while loading. Please reload this page.
fix(web): settled banner un-settles threads again - #9455
Closed
RakshithBhat03 wants to merge 1 commit into
Closed
Conversation
Contributor
ApprovabilityVerdict: Approved at Macroscope's review found this PR approvable — This is a narrowly scoped web event-handling fix that reuses the existing composer control boundary to prevent banner actions from triggering unwanted expansion. The focused regression test covers the new selector behavior, and no broader API, schema, configuration, or deployment behavior is changed. You can add or adjust custom eligibility rules. Learn more. |
juliusmarminge
commented
Sep 3, 2026
Member
Superseded by #9452 (merged) — same fix for banner actions (Un-settle / Wake now) expanding the resting composer instead of running. Closing this duplicate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking
Un-settlein the banner above a resting composer only expanded the composer. The thread stayed settled and the button remained visible, even though the same action worked from the sidebar and thread menu.The banner button receives focus during pointer-down. On desktop, the resting composer treated that focus as an intent to start typing, expanded synchronously, and moved the button before the click could finish. The banner already marks its controls as safe to use while the composer is collapsed. This change includes that marker in the shared resting-control event scope, so focus stays on the action and its click dispatches
thread.unsettle.This keeps the existing mobile behavior while replacing its one-off check with the shared rule. The same rule covers
Wake nowin the snoozed-thread banner, which had the same focus race. The thread command and settlement state handling are unchanged.Tests: 6 focused tests, web typecheck, targeted lint, formatting.
Screenshot
The highlighted
Un-settleaction is the banner control affected by the pointer and focus race.Built by GPT-5.6 Sol in T3 Code through the Codex harness.