fix(web): banner buttons no longer expand the resting composer

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}

[juliusmarminge]

Problem

With the composer resting (blurred, desktop) and a banner docked above it, clicking a button on the banner — "Un-settle", "Wake now", "Restore branch", dismiss, etc. — expanded the composer instead of running the button. The banner stack renders inside the composer <form>, so the button taking focus fired the form's onFocusCapture, which treated it as a request to expand. The surface grew under the pointer and the click never landed on the button.

Fix

The data-chat-composer-collapsed-controls scope was already exempt from that focus capture, but only when the composer was collapsed on mobile. isInsideCollapsedComposerControls in composerEventScope.ts now applies that exemption on every viewport, and the form's onPointerDownCapture skips the same scope so pressing a banner does not steal focus into the editor either. Banners, the approval row, pending-input panel, and the tasks badge all already carry the marker.

Web/desktop only; mobile has its own composer.

Demo

Resting composer on a settled thread, real pointer click on Un-settle.

Before — the composer expands and the thread stays settled:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/d7ee41ed34918b89/before-banner-click-expands-composer.mp4

After — the thread un-settles, the banner leaves, the composer stays at rest:

https://gh-file-drop-api-prod-mi5fy3sowv63ufte.pinglabs.workers.dev/f/2a719c16f1d047dc/after-banner-click-unsettles.mp4

Verification

• vp test run apps/web/src/components/chat/composerEventScope.test.ts
• lint on the touched files, vpr typecheck in apps/web
• Browser pass against a snapshot of real data, recorded above

Claude Fable 5 via Claude Code.

🤖 Generated with Claude Code

---

Note

Low Risk
Localized composer event-guard change with tests; no auth, data, or API impact.

Overview
Fixes a desktop bug where clicking banner actions (e.g. Un-settle, Wake now) on a resting composer expanded the input instead of running the control, because those elements sit inside the composer <form> and triggered expand-on-focus/pointer handlers.

Adds shared isInsideCollapsedComposerControls in composerEventScope.ts for targets under data-chat-composer-collapsed-controls (banners, approval row, pending-input chrome, tasks badge). ChatComposer now skips scroll-collapse and resting expansion on pointer down and focus capture for that scope on all viewports, replacing the previous mobile-collapsed-only focus check. Unit tests cover the helper.

^{Reviewed by Cursor Bugbot for commit bfe1108. Bugbot is set up for automated code reviews on this repo. Configure here.}

Note

Fix banner buttons expanding the resting ChatComposer

• Adds isInsideCollapsedComposerControls helper in composerEventScope.ts to detect event targets inside elements marked with the collapsed-controls data attribute
• Updates pointer-down and focus capture handlers in ChatComposer.tsx to ignore events from that scope so the composer no longer expands or clears scroll-collapse state
• Adds test coverage for the new helper in composerEventScope.test.ts

^{Macroscope summarized bfe1108.}

[github-actions]

Thread transfer impact

✅ Thread transfer remains within every enforced ceiling.

Provider	Metric	Main baseline	This PR	Impact	PR ceiling
Codex	Total thread wire	13.6 KiB	13.4 KiB	−157 B (−1.1%)	15.1 KiB	✅
Codex	Thread snapshot wire	7.0 KiB	7.0 KiB	+4 B (+0.1%)	7.3 KiB	✅
Codex	Live turn WebSocket wire	6.6 KiB	6.4 KiB	−161 B (−2.4%)	7.8 KiB	✅
Codex	Live turn WebSocket decoded	57.1 KiB	56.2 KiB	−910 B (−1.6%)	66.4 KiB	✅
Codex	Live turn messages	10	8	−2 (−20.0%)	21	✅
Claude	Total thread wire	13.5 KiB	13.5 KiB	+7 B (+0.1%)	15.1 KiB	✅
Claude	Thread snapshot wire	7.0 KiB	7.0 KiB	+1 B (+0.0%)	7.3 KiB	✅
Claude	Live turn WebSocket wire	6.5 KiB	6.5 KiB	+6 B (+0.1%)	7.8 KiB	✅
Claude	Live turn WebSocket decoded	57.8 KiB	57.8 KiB	0 B (0.0%)	66.4 KiB	✅
Claude	Live turn messages	8	8	0 (0.0%)	21	✅

Baseline: 2120fbc · PR result: bfe1108 · Source CI: success

Scenario and decoded snapshot size

10 historical turns, 5 command tools per turn, 878.9 KiB retained MCP result per historical turn, and a 1.05 MiB retained result in the measured turn.

• Codex decoded thread snapshot: 113.8 KiB
• Claude decoded thread snapshot: 114.5 KiB

Updated in place by a trusted workflow. PR artifacts are strictly validated and never executed.

[macroscopeapp]

Approvability

Verdict: Approved at bfe1108

Macroscope's review found this PR approvable — This is a localized web bug fix that adds a tested event guard for existing banner and drawer controls, preventing unintended composer expansion without affecting unrelated paths. It changes no product defaults, schemas, sensitive code, deployment configuration, or static-analysis directives.

^{You can add or adjust custom eligibility rules. Learn more.}