Uh oh!
There was an error while loading. Please reload this page.
fix(web): make project icons the default - #9457
Merged
Merged
Conversation
Contributor
ApprovabilityVerdict: Not approved Macroscope's review found this PR not approvable — This PR changes the default project icon experience from emoji to Lucide icons, affecting automatic fallbacks and the initial icon-picker mode across existing user flows. The change is localized and tested, but product-default changes require human review. Notes:
You can add or adjust custom eligibility rules. Learn more. |
Uh oh!
There was an error while loading. Please reload this page.
github-actionsBot
added a commit
to omarcresp/t3code-flake
that referenced
this pull request
Sep 3, 2026
## What's Changed * fix(web): send cited messages with Cmd+Enter by @extoci in pingdotgg/t3code#9307 * fix(web): preserve explicit preview navigation URLs by @nateEc in pingdotgg/t3code#8902 * fix(web): prevent loading ssh environments from overriding navigation by @flamboh in pingdotgg/t3code#9168 * fix(mobile): skip unsupported shared settings targets by @Lucenx9 in pingdotgg/t3code#9381 * fix(web): avoid duplicate Antigravity install status by @RakshithBhat03 in pingdotgg/t3code#9419 * fix(composer): mute fast icon when collapsed by @maria-rcks in pingdotgg/t3code#9451 * fix(web): unify skeleton loading animations on one pulse by @maria-rcks in pingdotgg/t3code#9448 * fix(web): prioritize authored pull requests by @maria-rcks in pingdotgg/t3code#9453 * fix(web): make project icons the default by @maria-rcks in pingdotgg/t3code#9457 * fix(server): reuse pr state when settling threads by @maria-rcks in pingdotgg/t3code#9459 * fix(web): keep agent images collapsed by @maria-rcks in pingdotgg/t3code#9460 * fix(web): banner buttons no longer expand the resting composer by @juliusmarminge in pingdotgg/t3code#9452 * fix(web): stop clipping the traits chevron on long Codex effort labels by @zortos293 in pingdotgg/t3code#9433 **Full Changelog**: pingdotgg/t3code@v0.0.39-nightly.20260903.1270...v0.0.39-nightly.20260903.1272 Upstream release: https://github.com/pingdotgg/t3code/releases/tag/v0.0.39-nightly.20260903.1272
sheehanmunim added a commit
to munimtechnologies/mtcode
that referenced
this pull request
Sep 4, 2026
…ity ACP, browser import, settings reorg, limits tab) Brings the fork up to upstream/main fee2e0f. Highlights: Google Antigravity via the official ACP agent (pingdotgg#9348) + model manifest refreshes, browser-cookie import (Chrome/Edge/Brave/Firefox, pingdotgg#7255/pingdotgg#7260/pingdotgg#7261), settings page reorg (pingdotgg#9354), Codex/Claude subscription Limits tab (pingdotgg#9507, pingdotgg#9534), context compaction command (pingdotgg#9293), async Codex questions (pingdotgg#9512), full-access OpenCode threads skip approvals (pingdotgg#9282), project icons default (pingdotgg#9457). Unification decisions (keep-both unless noted): - BrowserImport: upstream implementation wins (Linux libsecret, Windows DPAPI unwrap, writeCookies); fork's Safari engine ported in (jar definition, candidate path, profile listing, running check, count skip, import branch, FullDiskAccess wizard step + SafariCookies kept, domain widened only for dotted hosts). - Antigravity: upstream ACP provider/adapter/driver/textgen win; fork branding ported (providerDisabledMessage), AntigravitySettings unified (fork fields + upstream auth fields; enabled stays default-on). - contracts/model: Antigravity defaults follow upstream's manifest model. - ClaudeAdapter compact_boundary: fork's resolve helper kept, renamed to upstream's compactedUsage to match downstream. - Claude capabilities probe: fork's timeout races kept; upstream's raw usage fetch added under the same timeout so stalled usage still degrades. - Codex provider: upstream's withCodexAppServerClient + enriched rate-limits probe win (fork title branding already inside buildCodexInitializeParams). - ProviderCommandReactor: fork goal-continuation + correction-aware first-turn kept; upstream compact-command exclusion added. - OpenCodeAdapter ask path: fork's pendingGate/acceptingRequests gate kept; upstream full-access autoReply + terminal guard + emitUnsafe added. - makeManagedServerProvider: fork probe-timeout protection kept; upstream usage-limits reconciliation applied to the checked snapshot. - Manager.ts preview CDP: fork reuse-if-attached + detach resilience kept; upstream wcDebugger hardening applied. - mobile threadSyncPhase pill dropped (upstream ThreadDetail redesign covers loading/sync presentation); outbox deliveryMode + goal handling kept. - Usage: fork client-version projection kept; upstream pricing()/refreshRates adopted on both clients. - Settings: fork sections (MT Teams+badge, voice, notifications, account sign-in) kept; upstream reorg (ids, submenus, behaviour section) adopted. - README: fork copy kept; Antigravity added to provider lists. - Cursor skill test macOS /var-vs-/private/var path failure is pre-existing upstream breakage, unrelated to this merge. Fork guard script OK.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatic project fallbacks now use deterministic colored Lucide icons, while detected or uploaded images and saved emoji or icon overrides are unchanged. The picker opens on Icons, preserves each saved mode, and still supports Lucide search and color plus curated or pasted emoji selection. Verified with web typecheck, targeted lint, a production build, and browser e2e at desktop and 390px in light and dark; the three targeted tests are currently blocked before execution by Vite+ 0.3's
undefined.configrunner failure. Built bygpt-5.6-solin T3 Code through the Codex harness.evidence
before: automatic emoji fallback
after: automatic Lucide fallback
before: picker defaults to emoji
after: picker defaults to icons
browser e2e: icon search, green selection, save and reopen, custom emoji save and reopen, then reset
Note
Low Risk
UI-only default change for automatic icons and picker state; no auth, data, or API behavior changes.
Overview
Automatic project icon fallbacks no longer map classified names to emojis.
selectProjectIconnow returns{ kind: "lucide", icon }only, and the emoji lookup table was removed. Name-based classification and stable generic icons are unchanged; saved emoji/Lucide overrides and uploaded favicons are unaffected.The Choose project icon dialog defaults to Icons (Lucide + color) for new/automatic projects, puts the Icons toggle before Emoji, and updates the helper copy. Tests and user docs were updated to match icon-first behavior and
ProjectFaviconfallback expectations (icon component + color class instead of emoji props).Reviewed by Cursor Bugbot for commit eac0186. Bugbot is set up for automated code reviews on this repo. Configure here.
Note
Make Lucide project icons the default instead of emojis
selectProjectIconin projectIconModel.ts to return Lucide icon selections for classified and generic project names, removing thePROJECT_ICON_EMOJISlookup table.ProjectIconPickerDialogin ProjectIconPickerDialog.tsx to open in Icons mode by default (unless an emoji override exists), reorder mode toggles to show Icons first, and revise the description text.Macroscope summarized eac0186.