Uh oh!
There was an error while loading. Please reload this page.
No events v1 - #90
Conversation
Fix python 3.7 build
Improve ignores & setup.py
prepublish -> prepare / prepublishOnly.
Remove events
| "external_url": ( | ||
| "https://unpkg.com/{}@{}/{}/{}.min.js" | ||
| ).format(js_package_name, js_version, py_package_name, py_package_name), | ||
| "namespace": py_package_name |
There was a problem hiding this comment.
@Marc-Andre-Rivet to get test_imports to pass (and therefore to keep package contents clean). I guess these tests hadn't been run since fix release, alpha 2cf1256c?
| ## [0.13.4] - 2018-12-17 | ||
| ### Fixed | ||
| - Fix build from wrong dash version. | ||
There was a problem hiding this comment.
Not sure what the good practice would be here but I'd like something to let me know there is something unreleased in this v1.x branch so I can keep track of v1 releases states vs v0 if there's a need for it.
Maybe adding [Unreleased] entry at the top, referring to the 0.13.4 & 0.13.5 version bumps?
There was a problem hiding this comment.
Oh right I meant to bring up the changelog - it's a little funny since the history isn't quite linear but your idea seems like the most useful approach -> be67099
To be removed/cleaned up once we have a new rc release.
There was a problem hiding this comment.
@alexcjohnson Yes exactly. Once in rc, we can collapse the entire alpha history, same thing happens to the rc's once we do an official release.
Marc-Andre-Rivet
left a comment
There was a problem hiding this comment.
Looks good. Only one small thing here https://github.com/plotly/dash-html-components/pull/90/files#r248071252
Merging no-events #89 and a few more things into release-v1