Uh oh!
There was an error while loading. Please reload this page.
This repository was archived by the owner on Aug 29, 2025. It is now read-only.
Issue 284 - Add source map to NPM and PyPi packages - #285
Merged
Conversation
| "no-console": false | ||
| }, | ||
| "rulesDirectory": [] | ||
| } No newline at end of file |
ContributorAuthor
There was a problem hiding this comment.
Solving small issues with tslint rules in toolchain subfolders. Not related to main issue.. want to be able to use console.log in toolchain!
| library: dashLibraryName, | ||
| libraryTarget: 'umd' | ||
| }, | ||
| devtool: 'source-map', |
ContributorAuthor
There was a problem hiding this comment.
All is tslint fixes except for this. This setting is slower but more accurate than other mappings. See here: https://webpack.js.org/configuration/devtool/
| @@ -1,4 +1,5 @@ | |||
| include dash_table/bundle.js | |||
| include dash_table/bundle.js.map | |||
| 'external_url': ( | ||
| 'https://unpkg.com/dash-table@{}/dash_table/bundle.js.map' | ||
| ).format(__version__), | ||
| 'namespace': package_name |
| { | ||
| "name": "dash-table", | ||
| "version": "3.1.8", | ||
| "version": "3.1.9", |
| }, | ||
| "files": [ | ||
| "/dash_table/bundle*.js" | ||
| "/dash_table/bundle*{.js,.map}" |
ContributorAuthor
There was a problem hiding this comment.
pickup both js and map files for the NPM package
valentijnnieman
approved these changes
Dec 6, 2018
| 'external_url': ( | ||
| 'https://unpkg.com/dash-table@{}/dash_table/bundle.js.map' | ||
| ).format(__version__), | ||
| 'namespace': package_name |
…-map # Conflicts: # CHANGELOG.md # dash_table/bundle.js # dash_table/demo.js # dash_table/package-info.json # package-lock.json # package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes#284
Relates to plotly/dash#478
Relates to plotly/dash-renderer#104
Relates to plotly/dash-core-components#404