Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
- Notifications
You must be signed in to change notification settings - Fork 72
Issue 284 - Add source map to NPM and PyPi packages#285
Uh oh!
There was an error while loading. Please reload this page.
Changes from all commits
134e1f10a4ec4cb7411db375a9307ef8045829cf5eFile filter
Filter by extension
Conversations
Uh oh!
There was an error while loading. Please reload this page.
Jump to
Uh oh!
There was an error while loading. Please reload this page.
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| { | ||
| "defaultSeverity": "error", | ||
| "extends": "./../tslint.json", | ||
| "jsRules": { | ||
| "no-console": false | ||
| }, | ||
| "rules": { | ||
| "no-console": false | ||
| }, | ||
| "rulesDirectory": [] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -12,7 +12,7 @@ module.exports = (preprocessor = {}, mode = 'development') => { | ||
| return { | ||
| entry: { | ||
| bundle: './src/dash-table/index.ts', | ||
| demo: ['./demo/index.js', './demo/index.html'], | ||
| demo: ['./demo/index.js', './demo/index.html'] | ||
| }, | ||
| mode: mode, | ||
| output: { | ||
| @@ -21,18 +21,19 @@ module.exports = (preprocessor = {}, mode = 'development') => { | ||
| library: dashLibraryName, | ||
| libraryTarget: 'umd' | ||
| }, | ||
| devtool: 'source-map', | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. All is tslint fixes except for this. This setting is slower but more accurate than other mappings. See here: https://webpack.js.org/configuration/devtool/ | ||
| externals: { | ||
| react: { | ||
| commonjs: "react", | ||
| commonjs2: "react", | ||
| amd: "React", | ||
| root: "React" | ||
| commonjs: 'react', | ||
| commonjs2: 'react', | ||
| amd: 'React', | ||
| root: 'React' | ||
| }, | ||
| "react-dom": { | ||
| commonjs: "react-dom", | ||
| commonjs2: "react-dom", | ||
| amd: "ReactDOM", | ||
| root: "ReactDOM" | ||
| 'react-dom': { | ||
| commonjs: 'react-dom', | ||
| commonjs2: 'react-dom', | ||
| amd: 'ReactDOM', | ||
| root: 'ReactDOM' | ||
| }, | ||
| 'plotly.js': 'Plotly' | ||
| }, | ||
| @@ -58,25 +59,25 @@ module.exports = (preprocessor = {}, mode = 'development') => { | ||
| use: [ | ||
| { loader: 'style-loader' }, | ||
| { loader: 'css-loader' } | ||
| ], | ||
| ] | ||
| }, | ||
| { | ||
| test: /\.less$/, | ||
| use: [ | ||
| { loader: 'style-loader' }, | ||
| { loader: 'css-loader' }, | ||
| { loader: 'less-loader' } | ||
| ], | ||
| }, | ||
| ], | ||
| ] | ||
| } | ||
| ] | ||
| }, | ||
| resolve: { | ||
| alias: { | ||
| 'cypress': path.resolve('./tests/cypress/src'), | ||
| cypress: path.resolve('./tests/cypress/src'), | ||
| 'dash-table': path.resolve('./src/dash-table'), | ||
| 'demo': path.resolve('./demo'), | ||
| 'core': path.resolve('./src/core'), | ||
| 'tests': path.resolve('./tests') | ||
| demo: path.resolve('./demo'), | ||
| core: path.resolve('./src/core'), | ||
| tests: path.resolve('./tests') | ||
| }, | ||
| extensions: ['.js', '.ts', '.tsx'] | ||
| } | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| include dash_table/bundle.js | ||
| include dash_table/bundle.js.map | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. PyPi addition | ||
| include dash_table/metadata.json | ||
| include dash_table/package-info.json | ||
| include README.md | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| from .DataTable import DataTable | ||
| __all__ = [ | ||
| "DataTable", | ||
| ] | ||
| "DataTable" | ||
| ] |
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
Large diffs are not rendered by default.
Uh oh!
There was an error while loading. Please reload this page.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,6 @@ | ||
| { | ||
| "name": "dash-table", | ||
| "version": "3.1.9-rc1", | ||
| "version": "3.1.9", | ||
ContributorAuthor There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. bump version | ||
| "description": "Dash table", | ||
| "main": "dash_table/bundle.js", | ||
| "scripts": { | ||
| @@ -44,14 +44,14 @@ | ||
| "@babel/preset-react": "^7.0.0", | ||
| "@cypress/webpack-preprocessor": "^4.0.2", | ||
| "@percy-io/percy-storybook": "^2.1.0", | ||
| "@storybook/cli": "^4.0.11", | ||
| "@storybook/react": "^4.0.11", | ||
| "@storybook/cli": "^4.0.12", | ||
| "@storybook/react": "^4.0.12", | ||
| "@types/ramda": "^0.25.42", | ||
| "@types/react": "^16.7.13", | ||
| "@types/react-select": "^1.3.4", | ||
| "babel-loader": "^8.0.4", | ||
| "core-js": "^2.6.0", | ||
| "css-loader": "^1.0.1", | ||
| "css-loader": "^2.0.0", | ||
| "cypress": "^3.1.3", | ||
| "file-loader": "^2.0.0", | ||
| "http-server": "^0.11.1", | ||
| @@ -68,15 +68,15 @@ | ||
| "style-loader": "^0.23.1", | ||
| "ts-loader": "^5.3.1", | ||
| "tslint": "^5.11.0", | ||
| "typescript": "^3.2.1", | ||
| "typescript": "^3.2.2", | ||
| "wait-on": "^3.2.0", | ||
| "webpack": "^4.27.0", | ||
| "webpack": "^4.27.1", | ||
| "webpack-cli": "^3.1.2", | ||
| "webpack-dev-server": "^3.1.10", | ||
| "webpack-preprocessor": "^0.1.12" | ||
| }, | ||
| "files": [ | ||
| "/dash_table/bundle*.js" | ||
| "/dash_table/bundle*{.js,.map}" | ||
| ], | ||
| "peerDependencies": { | ||
| "react": ">=0.14", | ||
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Solving small issues with tslint rules in toolchain subfolders. Not related to main issue.. want to be able to use console.log in toolchain!