Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Autoset routes and requests pathname prefixes if DASH_APP_NAME is set by rpkyle · Pull Request #165 · plotly/dashR · GitHub
Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet
, 'i'); if (__m === '*' || __re.test(location.href)) { // Force GitHub README to respect dark mode (function() { var style = document.createElement('style'); style.textContent = ' .markdown-body { color-scheme: dark light; } .markdown-body pre { background: #161b22 !important; } .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; } .markdown-body table th, .markdown-body table td { border-color: #30363d !important; } .markdown-body img { background: #0d1117; } .markdown-body blockquote { border-left-color: #8b949e; } .markdown-body hr { border-color: #30363d; } '; document.head.appendChild(style); })(); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Autoset routes and requests pathname prefixes if DASH_APP_NAME is set by rpkyle · Pull Request #165 · plotly/dashR · GitHub
Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet
, 'i'); if (__m === '*' || __re.test(location.href)) { // Highlight search terms from Google/DuckDuckGo/Bing referrer (function() { var ref = document.referrer; var terms = []; if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) { var url = new URL(ref); var q = url.searchParams.get('q') || url.searchParams.get('p'); if (q) { terms = q.split(/\s+/).filter(function(t) { return t.length > 2; }); } } if (terms.length === 0) return; var style = document.createElement('style'); style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }'; document.head.appendChild(style); function highlight(node) { if (node.nodeType === 3) { // text node var text = node.textContent; var found = false; terms.forEach(function(term) { var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Autoset routes and requests pathname prefixes if DASH_APP_NAME is set by rpkyle · Pull Request #165 · plotly/dashR · GitHub
Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet
, 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ' Autoset routes and requests pathname prefixes if DASH_APP_NAME is set by rpkyle · Pull Request #165 · plotly/dashR · GitHub
Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet
, 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Autoset routes and requests pathname prefixes if DASH_APP_NAME is set by rpkyle · Pull Request #165 · plotly/dashR · GitHub
Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet
, 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ' Autoset routes and requests pathname prefixes if DASH_APP_NAME is set by rpkyle · Pull Request #165 · plotly/dashR · GitHub
Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet
, 'i'); if (__m === '*' || __re.test(location.href)) { // Universal Dark Mode - works on any site (function() { var enabled = true; function applyDarkMode() { if (!enabled) return; // Create style element if it doesn't exist var style = document.getElementById('universal-dark-mode-style'); if (!style) { style = document.createElement('style'); style.id = 'universal-dark-mode-style'; document.head.appendChild(style); } // Dark mode CSS - inverts colors but preserves images/video style.textContent = ' /* Invert everything except media */ html { filter: invert(1) hue-rotate(180deg) !important; background: #1a1a2e !important; } /* Restore images, videos, iframes, canvas */ img, video, iframe, canvas, svg, picture, [style*="background-image"] { filter: invert(1) hue-rotate(180deg) !important; } /* Preserve specific elements that should not be inverted */ .no-dark-mode, .no-dark-mode *, [data-theme="light"], [data-theme="light"], .ace_editor, .ace_editor *, .CodeMirror, .CodeMirror *, .monaco-editor, .monaco-editor *, .markdown-body pre, .markdown-body pre *, .highlight, .highlight *, pre code, pre code * { filter: none !important; } /* Fix common UI elements */ .modal, .popup, .dropdown-menu, .tooltip, .popover { filter: invert(1) hue-rotate(180deg) !important; background: #2d2d44 !important; border-color: #444 !important; } /* Scrollbars */ ::-webkit-scrollbar { background: #1a1a2e !important; } ::-webkit-scrollbar-thumb { background: #444 !important; } ::-webkit-scrollbar-thumb:hover { background: #555 !important; } /* Selection */ ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; } ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; } '; } function removeDarkMode() { var style = document.getElementById('universal-dark-mode-style'); if (style) style.remove(); } // Toggle with Alt+Shift+D document.addEventListener('keydown', function(e) { if (e.altKey && e.shiftKey && e.key === 'D') { e.preventDefault(); enabled = !enabled; if (enabled) { applyDarkMode(); console.log('[Universal Dark Mode] Enabled'); } else { removeDarkMode(); console.log('[Universal Dark Mode] Disabled'); } } }); // Apply on load applyDarkMode(); // Re-apply on dynamic content var observer = new MutationObserver(function(mutations) { if (enabled && !document.getElementById('universal-dark-mode-style')) { applyDarkMode(); } }); observer.observe(document.head, { childList: true }); console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle'); })(); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })(); Autoset routes and requests pathname prefixes if DASH_APP_NAME is set by rpkyle · Pull Request #165 · plotly/dashR · GitHub
Skip to content

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set - #165

Merged
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes
Jan 14, 2020
Merged

Autoset routes and requests pathname prefixes if DASH_APP_NAME is set#165
rpkyle merged 3 commits into
devfrom
164-autoset-prefixes

Conversation

@rpkyle

Copy link
Copy Markdown
Contributor

This PR proposes to modify the resolution logic for resolve_prefix, which is called by Dash when setting self$routes_pathname_prefix and self$requests_pathname_prefix:

  • check if routes_pathname_prefix or requests_pathname_prefix has been passed to Dash for R directly, and use if available
  • check if DASH_ROUTES_PATHNAME_PREFIX or DASH_REQUESTS_PATHNAME_PREFIX have been set in current environment, and use if available
  • check if DASH_APP_NAME has been set in environment, and use if available
  • check if DASH_URL_BASE_PATHNAME has been set in environment, and use if available
  • return the value of base_pathname if resolution fails as directed above

In addition, the function name is camelCased instead of using snake case.

@rpkylerpkyle self-assigned this Jan 13, 2020
@rpkyle
rpkyle changed the base branch from master to devJanuary 13, 2020 18:31
Comment threadR/utils.R Outdated
Fixes conditional statement to resolve installation error.
Comment threadR/utils.R
env_base_pathname <- Sys.getenv("DASH_URL_BASE_PATHNAME")
app_name <- Sys.getenv("DASH_APP_NAME")

if (prefix_env != "")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a slight change here to fix the conditional statement.

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤦‍♂ Yep, one too many else if statements here.

@HammadTheOneHammadTheOne left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey Ryan,

After checking out the changes and testing out a couple of deployments to DE, it looks like the changes work well and the autoset prefixes add a bit of convenience as a first step to making the apps easier to deploy on DE.

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

💃

@rpkyle

Copy link
Copy Markdown
ContributorAuthor

There was a slight issue with a conditional but that's been sorted out with the last commit. I did notice however, that the changes aren't backwards compatible, I had to remove the references to some of the environment variables declared in previous versions of the deployment template, but I think (based on our discussion earlier) that that's by design and should be fine going forward with future apps/deployments.

Thanks @HammadTheOne. There are definitely some changes introduced as a result of all this work, but the end effect is a smoother, simpler deployment process overall.

@chriddyp

Copy link
Copy Markdown
Member

I did notice however, that the changes aren't backwards compatible

I find this surprising. Which line of code is backwards incompatible? I would've expected that if these variables are already set (as in our current examples), they would continue to be used.

@HammadTheOne

HammadTheOne commented Jan 14, 2020

Copy link
Copy Markdown
Contributor

I believe the line setting the pathPrefix was the one, here's the logs that popped up before I removed those lines:

 R version 3.6.2 (2019-12-12) -- "Dark and Stormy Night"
Copyright (C) 2019 The R Foundation for Statistical Computing
Platform: x86_64-pc-linux-gnu (64-bit)
R is free software and comes with ABSOLUTELY NO WARRANTY.
You are welcome to redistribute it under certain conditions.
Type 'license()' or 'licence()' for distribution details.
R is a collaborative project with many contributors.
Type 'contributors()' for more information and
'citation()' on how to cite R or R packages in publications.
Type 'demo()' for some demos, 'help()' for on-line help, or
'help.start()' for an HTML browser interface to help.
Type 'q()' to quit R.
> appName <- Sys.getenv("DASH_APP_NAME")
> > if (appName != "") {
+ pathPrefix <- sprintf("/%s/", appName)
+ + Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix,
+ DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix,
+ )
+ }
Error in Sys.setenv(DASH_ROUTES_PATHNAME_PREFIX = pathPrefix, DASH_REQUESTS_PATHNAME_PREFIX = pathPrefix, : argument is missing, with no default
Execution halted
=====> end ctest web container output

This was referenced Feb 6, 2020
rpkyle added a commit that referenced this pull request Feb 13, 2020
* Autoset routes and requests pathname prefixes (#165)
* Inspect environment variables for host & port (#167)
* Support for index page templating (#168)
* Add support for config-aware relative paths (#172)
* Add unit tests for index customization (#176)
* Send status code of 1 when unit tests fail (#177)
@rpkyle
rpkyle deleted the 164-autoset-prefixes branch May 4, 2020 06:04
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

@rpkyle@chriddyp@HammadTheOne@Marc-Andre-Rivet