Uh oh!
There was an error while loading. Please reload this page.
Import CSS deps into package map - #94
Conversation
| dep$script) | ||
| dep_path <- ifelse(!is.null(dep$script), | ||
| file.path(dep$src$file, dep$script), | ||
| file.path(dep$src$file, dep$stylesheet)) |
There was a problem hiding this comment.
| dep$name, | ||
| "/", | ||
| basename(dep[["stylesheet"]]), | ||
| sprintf("?v=%s&m=%s", dep$version, modified)) |
There was a problem hiding this comment.
🐄 seems funny to combine sprintf and paste0 - I guess that's because modified isn't a string, and I see this is used above too... but it would be easier to read if we pick one for any given concatenation.
| dep$version) | ||
| if(!is.null(dep$package)) { | ||
| html <- sprintf("<link href=\"%s?v=%s\" rel=\"stylesheet\" />", file.path(dep[["stylesheet"]]), | ||
| dep$version) |
There was a problem hiding this comment.
why is dep$version appearing both here and above where you define dep[["stylesheet"]]?
* ✨ initial support for stack tracing * ✨ capture errors as warnings in debug mode * ✨ initial support for dash-renderer v23 * ✨ add options for dev_tools_ui and dev_tools_props_check * ✨ initial support for callback context * ✨ add support for debug mode tracebacks * ✋ only send tracebacks in debug mode * ✋ warn if callback_context is undefined * 🚚 add dependency on crayon 📦
| as_is = FALSE) { | ||
| if (!(local)) { | ||
| if (grepl("^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]+$", href, perl=TRUE)) { | ||
| if (grepl("^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w\\.-]+)+[\\w\\-\\._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]+$", |
There was a problem hiding this comment.
This is just a formatting change to decrease the width of the line.
| # states=setCallbackContext(state), | ||
| # triggered=list(), | ||
| # inputs=getContextElements(inputs) | ||
| # ) |
There was a problem hiding this comment.
what's this commented block?
There was a problem hiding this comment.
When I initially implemented callback_context, I thought it would make sense for the object holding the details to exist before the callback was fired. I've since come to the conclusion (realization?) that callback_context should be NULL until the callback is invoked.
I had not yet removed the lines because it could simplify formatting the context if the object existed already, but I identified a workaround and users report that callback_context is fully functional.
I've removed the inactive statements.
fixed in ba8ecf3
rpkyle
commented
Jun 17, 2019
🙏 |
This PR proposes to implement registration of CSS assets within R packages via the package map.
Previously, importing via
external_stylesheetsandassetswas supported, and in-package CSS loading was incompletely supported.Partly addresses #91.