') + ')', 'gi'); if (regex.test(text)) { found = true; var frag = document.createDocumentFragment(); var parts = text.split(regex); parts.forEach(function(part, i) { if (i % 2 === 0) { frag.appendChild(document.createTextNode(part)); } else { var span = document.createElement('span'); span.className = 'userscript-highlight'; span.textContent = part; frag.appendChild(span); } }); node.parentNode.replaceChild(frag, node); } }); } else if (node.nodeType === 1 && node.childNodes) { // element var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT']; if (!skipTags.includes(node.tagName)) { Array.from(node.childNodes).forEach(highlight); } } } highlight(document.body); // Re-highlight on dynamic content var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1 || node.nodeType === 3) highlight(node); }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Strip utm_, fbclid, gclid, etc. from all links on page (function() { var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content', 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid', 'ref', 'ref_src', 'source', 'medium', 'campaign']; function cleanUrl(url) { try { var u = new URL(url, window.location.origin); var changed = false; trackingParams.forEach(function(p) { if (u.searchParams.has(p)) { u.searchParams.delete(p); changed = true; } }); return changed ? u.toString() : url; } catch (e) { return url; } } function cleanLinks() { document.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } cleanLinks(); var observer = new MutationObserver(function(mutations) { mutations.forEach(function(m) { m.addedNodes.forEach(function(node) { if (node.nodeType === 1) { if (node.tagName === 'A') cleanLinks(); node.querySelectorAll('a[href]').forEach(function(a) { var clean = cleanUrl(a.href); if (clean !== a.href) a.href = clean; }); } }); }); }); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Auto-enable theater mode on YouTube (function() { function tryTheater() { var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]'); if (btn && !btn.classList.contains('activated')) { btn.click(); } } // Try immediately tryTheater(); // Try after navigation (SPA) var lastUrl = location.href; setInterval(function() { if (location.href !== lastUrl) { lastUrl = location.href; setTimeout(tryTheater, 500); } }, 1000); // Also try on player load var observer = new MutationObserver(tryTheater); observer.observe(document.body, { childList: true, subtree: true }); })(); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + ', 'i'); if (__m === '*' || __re.test(location.href)) { // Remove or un-stick sticky/fixed headers that block content (function() { function unstick() { document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) { if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') { el.style.position = 'static'; el.style.top = 'auto'; el.style.zIndex = 'auto'; } }); } unstick(); var observer = new MutationObserver(unstick); observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] }); })(); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); })(); Adding third container for jasmine tests to avoid flaky fails by archmoj · Pull Request #3599 · plotly/plotly.js · GitHub
Skip to content

Adding third container for jasmine tests to avoid flaky fails - #3599

Merged
archmoj merged 5 commits into
masterfrom
flaky-less
Mar 5, 2019
Merged

Adding third container for jasmine tests to avoid flaky fails#3599
archmoj merged 5 commits into
masterfrom
flaky-less

Conversation

@archmoj

@archmojarchmoj commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

Fixes#3587.
@plotly/plotly_js

@etpinard

etpinard commented Mar 4, 2019

Copy link
Copy Markdown
Contributor

Have you tried re-running the tests a few times to see if it actually helps?

@archmoj

archmoj commented Mar 4, 2019

Copy link
Copy Markdown
ContributorAuthor

Have you tried re-running the tests a few times to see if it actually helps?

Good call. It quickly passed the very first time; but then I see it may not pass.
So I will try the second step described here: #3587.

etpinard
etpinard reviewed Mar 4, 2019
View reviewed changes
Comment thread.circleci/test.sh Outdated
SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

for s in ${SHARDS[@]}; do
retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI

@etpinardetpinardMar 4, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be:

 retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI

@etpinard

etpinard commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Any updates on this thing?

Even if the tests in test-jasmine3 (still) fail from time to time, this PR will make our rebuild faster as we won't have to re-test all the non-flaky jasmine tests when we have to rebuild.

@archmoj

archmoj commented Mar 5, 2019

Copy link
Copy Markdown
ContributorAuthor

Yes. I think it is ready to go.

@etpinard

etpinard commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

💃

@antoinerg

antoinerg commented Mar 5, 2019

Copy link
Copy Markdown
Contributor

Looks good to me 💃

@archmoj
archmoj merged commit 3a63b18 into masterMar 5, 2019
@archmoj
archmoj deleted the flaky-less branch March 5, 2019 22:45
@archmojarchmoj mentioned this pull request Mar 23, 2019
Merged
3 tasks
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@etpinardetpinardetpinard left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@archmoj@etpinard@antoinerg