Skip to content

Adding third container for jasmine tests to avoid flaky fails#3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
archmoj merged 5 commits into from
Mar 5, 2019
Merged

Adding third container for jasmine tests to avoid flaky fails #3599

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
61bdc63
less flaky - step 1
archmoj Mar 4, 2019
6c8804f
trying shards in jasmine3 test
archmoj Mar 4, 2019
97df9d6
double double-click delay
archmoj Mar 4, 2019
596df64
use loop variable
archmoj Mar 4, 2019
b05d15c
lower bouble click delay
archmoj Mar 5, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 16 additions & 0 deletions .circleci/config.yml
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,19 @@ jobs:
name: Run jasmine tests (batch 2)
command: ./.circleci/test.sh jasmine2

test-jasmine3:
docker:
# need '-browsers' version to test in real (xvfb-wrapped) browsers
- image: circleci/node:10.9.0-browsers
working_directory: ~/plotly.js
steps:
- checkout
- attach_workspace:
at: ~/plotly.js
- run:
name: Run jasmine tests (batch 3)
command: ./.circleci/test.sh jasmine3

test-image:
docker:
- image: plotly/testbed:latest
Expand DownExpand Up@@ -165,6 +178,9 @@ workflows:
- test-jasmine2:
requires:
- build
- test-jasmine3:
requires:
- build
- test-image:
requires:
- build
Expand Down
13 changes: 12 additions & 1 deletion .circleci/test.sh
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,6 @@ case $1 in
set_tz

npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
npm run test-bundle || EXIT_STATE=$?

exit $EXIT_STATE
Expand All@@ -63,6 +62,18 @@ case $1 in
exit $EXIT_STATE
;;

jasmine3)
set_tz

SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

for s in ${SHARDS[@]}; do
retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
done

exit $EXIT_STATE
;;

image)
npm run test-image || EXIT_STATE=$?
exit $EXIT_STATE
Expand Down
2 changes: 1 addition & 1 deletion test/jasmine/tests/select_test.js
View file
Open in desktop
Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ describe('Click-to-select', function() {
} else {
setTimeout(function() {
click(x, y, clickOpts);
}, DBLCLICKDELAY * 1.01);
}, DBLCLICKDELAY * 1.03);
}

return selectedPromise;
Expand Down
, 'i'); if (__m === '*' || __re.test(location.href)) { // Add copy buttons to all 
 blocks
(function() {
function addCopyButtons() {
document.querySelectorAll('pre code').forEach(function(codeBlock) {
if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;
codeBlock.parentElement.setAttribute('data-copy-added', 'true');
var btn = document.createElement('button');
btn.textContent = 'Copy';
btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';
btn.onmouseover = function() { this.style.opacity = '1'; };
btn.onmouseout = function() { this.style.opacity = '0.7'; };
btn.onclick = function() {
navigator.clipboard.writeText(codeBlock.textContent).then(function() {
btn.textContent = 'Copied!';
setTimeout(function() { btn.textContent = 'Copy'; }, 1500);
});
};
codeBlock.parentElement.style.position = 'relative';
codeBlock.parentElement.appendChild(btn);
});
}
addCopyButtons();
// Re-run on dynamic content
var observer = new MutationObserver(addCopyButtons);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Adding third container for jasmine tests to avoid flaky fails by archmoj · Pull Request #3599 · plotly/plotly.js · GitHub
Skip to content
Adding third container for jasmine tests to avoid flaky fails#3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

archmoj
merged 5 commits into

from

Mar 5, 2019
 Merged


Adding third container for jasmine tests to avoid flaky fails
#3599
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
61bdc63

less flaky - step 1


archmoj Mar 4, 2019
6c8804f

trying shards in jasmine3 test


archmoj Mar 4, 2019
97df9d6

double double-click delay


archmoj Mar 4, 2019
596df64

use loop variable


archmoj Mar 4, 2019
b05d15c

lower bouble click delay


archmoj Mar 5, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,19 @@ jobs:
 name: Run jasmine tests (batch 2)
 command: ./.circleci/test.sh jasmine2

 test-jasmine3:
 docker:
 # need '-browsers' version to test in real (xvfb-wrapped) browsers
 - image: circleci/node:10.9.0-browsers
 working_directory: ~/plotly.js
 steps:
 - checkout
 - attach_workspace:
 at: ~/plotly.js
 - run:
 name: Run jasmine tests (batch 3)
 command: ./.circleci/test.sh jasmine3

 test-image:
 docker:
 - image: plotly/testbed:latest
Expand DownExpand Up@@ -165,6 +178,9 @@ workflows:
 - test-jasmine2:
 requires:
 - build
 - test-jasmine3:
 requires:
 - build
 - test-image:
 requires:
 - build
Expand Down

13 changes: 12 additions & 1 deletion
.circleci/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,6 @@ case $1 in
 set_tz

 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
 retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
 npm run test-bundle || EXIT_STATE=$?

 exit $EXIT_STATE
Expand All@@ -63,6 +62,18 @@ case $1 in
 exit $EXIT_STATE
 ;;

 jasmine3)
 set_tz

 SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

 for s in ${SHARDS[@]}; do
 retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
 done

 exit $EXIT_STATE
 ;;

 image)
 npm run test-image || EXIT_STATE=$?
 exit $EXIT_STATE
Expand Down

2 changes: 1 addition & 1 deletion
test/jasmine/tests/select_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ describe('Click-to-select', function() {
 } else {
 setTimeout(function() {
 click(x, y, clickOpts);
 }, DBLCLICKDELAY * 1.01);
 }, DBLCLICKDELAY * 1.03);
 }

 return selectedPromise;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Force GitHub README to respect dark mode
(function() {
var style = document.createElement('style');
style.textContent = '
.markdown-body {
color-scheme: dark light;
}
.markdown-body pre { background: #161b22 !important; }
.markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }
.markdown-body table th, .markdown-body table td { border-color: #30363d !important; }
.markdown-body img { background: #0d1117; }
.markdown-body blockquote { border-left-color: #8b949e; }
.markdown-body hr { border-color: #30363d; }
';
document.head.appendChild(style);
})();
}
} catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Adding third container for jasmine tests to avoid flaky fails by archmoj · Pull Request #3599 · plotly/plotly.js · GitHub
Skip to content
Adding third container for jasmine tests to avoid flaky fails#3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

archmoj
merged 5 commits into

from

Mar 5, 2019
 Merged


Adding third container for jasmine tests to avoid flaky fails
#3599
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
61bdc63

less flaky - step 1


archmoj Mar 4, 2019
6c8804f

trying shards in jasmine3 test


archmoj Mar 4, 2019
97df9d6

double double-click delay


archmoj Mar 4, 2019
596df64

use loop variable


archmoj Mar 4, 2019
b05d15c

lower bouble click delay


archmoj Mar 5, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,19 @@ jobs:
 name: Run jasmine tests (batch 2)
 command: ./.circleci/test.sh jasmine2

 test-jasmine3:
 docker:
 # need '-browsers' version to test in real (xvfb-wrapped) browsers
 - image: circleci/node:10.9.0-browsers
 working_directory: ~/plotly.js
 steps:
 - checkout
 - attach_workspace:
 at: ~/plotly.js
 - run:
 name: Run jasmine tests (batch 3)
 command: ./.circleci/test.sh jasmine3

 test-image:
 docker:
 - image: plotly/testbed:latest
Expand DownExpand Up@@ -165,6 +178,9 @@ workflows:
 - test-jasmine2:
 requires:
 - build
 - test-jasmine3:
 requires:
 - build
 - test-image:
 requires:
 - build
Expand Down

13 changes: 12 additions & 1 deletion
.circleci/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,6 @@ case $1 in
 set_tz

 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
 retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
 npm run test-bundle || EXIT_STATE=$?

 exit $EXIT_STATE
Expand All@@ -63,6 +62,18 @@ case $1 in
 exit $EXIT_STATE
 ;;

 jasmine3)
 set_tz

 SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

 for s in ${SHARDS[@]}; do
 retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
 done

 exit $EXIT_STATE
 ;;

 image)
 npm run test-image || EXIT_STATE=$?
 exit $EXIT_STATE
Expand Down

2 changes: 1 addition & 1 deletion
test/jasmine/tests/select_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ describe('Click-to-select', function() {
 } else {
 setTimeout(function() {
 click(x, y, clickOpts);
 }, DBLCLICKDELAY * 1.01);
 }, DBLCLICKDELAY * 1.03);
 }

 return selectedPromise;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Highlight search terms from Google/DuckDuckGo/Bing referrer
(function() {
var ref = document.referrer;
var terms = [];
if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {
var url = new URL(ref);
var q = url.searchParams.get('q') || url.searchParams.get('p');
if (q) {
terms = q.split(/\s+/).filter(function(t) { return t.length > 2; });
}
}
if (terms.length === 0) return;
var style = document.createElement('style');
style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';
document.head.appendChild(style);
function highlight(node) {
if (node.nodeType === 3) { // text node
var text = node.textContent;
var found = false;
terms.forEach(function(term) {
var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\]\\]/g, '\\') + ')', 'gi');
if (regex.test(text)) {
found = true;
var frag = document.createDocumentFragment();
var parts = text.split(regex);
parts.forEach(function(part, i) {
if (i % 2 === 0) {
frag.appendChild(document.createTextNode(part));
} else {
var span = document.createElement('span');
span.className = 'userscript-highlight';
span.textContent = part;
frag.appendChild(span);
}
});
node.parentNode.replaceChild(frag, node);
}
});
} else if (node.nodeType === 1 && node.childNodes) { // element
var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];
if (!skipTags.includes(node.tagName)) {
Array.from(node.childNodes).forEach(highlight);
}
}
}
highlight(document.body);
// Re-highlight on dynamic content
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1 || node.nodeType === 3) highlight(node);
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Adding third container for jasmine tests to avoid flaky fails by archmoj · Pull Request #3599 · plotly/plotly.js · GitHub
Skip to content
Adding third container for jasmine tests to avoid flaky fails#3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

archmoj
merged 5 commits into

from

Mar 5, 2019
 Merged


Adding third container for jasmine tests to avoid flaky fails
#3599
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
61bdc63

less flaky - step 1


archmoj Mar 4, 2019
6c8804f

trying shards in jasmine3 test


archmoj Mar 4, 2019
97df9d6

double double-click delay


archmoj Mar 4, 2019
596df64

use loop variable


archmoj Mar 4, 2019
b05d15c

lower bouble click delay


archmoj Mar 5, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,19 @@ jobs:
 name: Run jasmine tests (batch 2)
 command: ./.circleci/test.sh jasmine2

 test-jasmine3:
 docker:
 # need '-browsers' version to test in real (xvfb-wrapped) browsers
 - image: circleci/node:10.9.0-browsers
 working_directory: ~/plotly.js
 steps:
 - checkout
 - attach_workspace:
 at: ~/plotly.js
 - run:
 name: Run jasmine tests (batch 3)
 command: ./.circleci/test.sh jasmine3

 test-image:
 docker:
 - image: plotly/testbed:latest
Expand DownExpand Up@@ -165,6 +178,9 @@ workflows:
 - test-jasmine2:
 requires:
 - build
 - test-jasmine3:
 requires:
 - build
 - test-image:
 requires:
 - build
Expand Down

13 changes: 12 additions & 1 deletion
.circleci/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,6 @@ case $1 in
 set_tz

 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
 retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
 npm run test-bundle || EXIT_STATE=$?

 exit $EXIT_STATE
Expand All@@ -63,6 +62,18 @@ case $1 in
 exit $EXIT_STATE
 ;;

 jasmine3)
 set_tz

 SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

 for s in ${SHARDS[@]}; do
 retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
 done

 exit $EXIT_STATE
 ;;

 image)
 npm run test-image || EXIT_STATE=$?
 exit $EXIT_STATE
Expand Down

2 changes: 1 addition & 1 deletion
test/jasmine/tests/select_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ describe('Click-to-select', function() {
 } else {
 setTimeout(function() {
 click(x, y, clickOpts);
 }, DBLCLICKDELAY * 1.01);
 }, DBLCLICKDELAY * 1.03);
 }

 return selectedPromise;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Strip utm_, fbclid, gclid, etc. from all links on page
(function() {
var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',
'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',
'ref', 'ref_src', 'source', 'medium', 'campaign'];
function cleanUrl(url) {
try {
var u = new URL(url, window.location.origin);
var changed = false;
trackingParams.forEach(function(p) {
if (u.searchParams.has(p)) {
u.searchParams.delete(p);
changed = true;
}
});
return changed ? u.toString() : url;
} catch (e) {
return url;
}
}
function cleanLinks() {
document.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
cleanLinks();
var observer = new MutationObserver(function(mutations) {
mutations.forEach(function(m) {
m.addedNodes.forEach(function(node) {
if (node.nodeType === 1) {
if (node.tagName === 'A') cleanLinks();
node.querySelectorAll('a[href]').forEach(function(a) {
var clean = cleanUrl(a.href);
if (clean !== a.href) a.href = clean;
});
}
});
});
});
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); }
})();
(function(){
try {
var __m = "youtube.com";
var __re = new RegExp('^' + "youtube\\.com" + '
Adding third container for jasmine tests to avoid flaky fails by archmoj · Pull Request #3599 · plotly/plotly.js · GitHub
Skip to content
Adding third container for jasmine tests to avoid flaky fails#3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

archmoj
merged 5 commits into

from

Mar 5, 2019
 Merged


Adding third container for jasmine tests to avoid flaky fails
#3599
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
61bdc63

less flaky - step 1


archmoj Mar 4, 2019
6c8804f

trying shards in jasmine3 test


archmoj Mar 4, 2019
97df9d6

double double-click delay


archmoj Mar 4, 2019
596df64

use loop variable


archmoj Mar 4, 2019
b05d15c

lower bouble click delay


archmoj Mar 5, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,19 @@ jobs:
 name: Run jasmine tests (batch 2)
 command: ./.circleci/test.sh jasmine2

 test-jasmine3:
 docker:
 # need '-browsers' version to test in real (xvfb-wrapped) browsers
 - image: circleci/node:10.9.0-browsers
 working_directory: ~/plotly.js
 steps:
 - checkout
 - attach_workspace:
 at: ~/plotly.js
 - run:
 name: Run jasmine tests (batch 3)
 command: ./.circleci/test.sh jasmine3

 test-image:
 docker:
 - image: plotly/testbed:latest
Expand DownExpand Up@@ -165,6 +178,9 @@ workflows:
 - test-jasmine2:
 requires:
 - build
 - test-jasmine3:
 requires:
 - build
 - test-image:
 requires:
 - build
Expand Down

13 changes: 12 additions & 1 deletion
.circleci/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,6 @@ case $1 in
 set_tz

 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
 retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
 npm run test-bundle || EXIT_STATE=$?

 exit $EXIT_STATE
Expand All@@ -63,6 +62,18 @@ case $1 in
 exit $EXIT_STATE
 ;;

 jasmine3)
 set_tz

 SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

 for s in ${SHARDS[@]}; do
 retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
 done

 exit $EXIT_STATE
 ;;

 image)
 npm run test-image || EXIT_STATE=$?
 exit $EXIT_STATE
Expand Down

2 changes: 1 addition & 1 deletion
test/jasmine/tests/select_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ describe('Click-to-select', function() {
 } else {
 setTimeout(function() {
 click(x, y, clickOpts);
 }, DBLCLICKDELAY * 1.01);
 }, DBLCLICKDELAY * 1.03);
 }

 return selectedPromise;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Auto-enable theater mode on YouTube
(function() {
function tryTheater() {
var btn = document.querySelector('button[aria-label="Theater mode"], ytd-player #player button[title="Theater mode"]');
if (btn && !btn.classList.contains('activated')) {
btn.click();
}
}
// Try immediately
tryTheater();
// Try after navigation (SPA)
var lastUrl = location.href;
setInterval(function() {
if (location.href !== lastUrl) {
lastUrl = location.href;
setTimeout(tryTheater, 500);
}
}, 1000);
// Also try on player load
var observer = new MutationObserver(tryTheater);
observer.observe(document.body, { childList: true, subtree: true });
})();
}
} catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); }
})();
(function(){
try {
var __m = "*";
var __re = new RegExp('^' + ".*" + '
Adding third container for jasmine tests to avoid flaky fails by archmoj · Pull Request #3599 · plotly/plotly.js · GitHub
Skip to content
Adding third container for jasmine tests to avoid flaky fails#3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

archmoj
merged 5 commits into

from

Mar 5, 2019
 Merged


Adding third container for jasmine tests to avoid flaky fails
#3599
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
61bdc63

less flaky - step 1


archmoj Mar 4, 2019
6c8804f

trying shards in jasmine3 test


archmoj Mar 4, 2019
97df9d6

double double-click delay


archmoj Mar 4, 2019
596df64

use loop variable


archmoj Mar 4, 2019
b05d15c

lower bouble click delay


archmoj Mar 5, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,19 @@ jobs:
 name: Run jasmine tests (batch 2)
 command: ./.circleci/test.sh jasmine2

 test-jasmine3:
 docker:
 # need '-browsers' version to test in real (xvfb-wrapped) browsers
 - image: circleci/node:10.9.0-browsers
 working_directory: ~/plotly.js
 steps:
 - checkout
 - attach_workspace:
 at: ~/plotly.js
 - run:
 name: Run jasmine tests (batch 3)
 command: ./.circleci/test.sh jasmine3

 test-image:
 docker:
 - image: plotly/testbed:latest
Expand DownExpand Up@@ -165,6 +178,9 @@ workflows:
 - test-jasmine2:
 requires:
 - build
 - test-jasmine3:
 requires:
 - build
 - test-image:
 requires:
 - build
Expand Down

13 changes: 12 additions & 1 deletion
.circleci/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,6 @@ case $1 in
 set_tz

 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
 retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
 npm run test-bundle || EXIT_STATE=$?

 exit $EXIT_STATE
Expand All@@ -63,6 +62,18 @@ case $1 in
 exit $EXIT_STATE
 ;;

 jasmine3)
 set_tz

 SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

 for s in ${SHARDS[@]}; do
 retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
 done

 exit $EXIT_STATE
 ;;

 image)
 npm run test-image || EXIT_STATE=$?
 exit $EXIT_STATE
Expand Down

2 changes: 1 addition & 1 deletion
test/jasmine/tests/select_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ describe('Click-to-select', function() {
 } else {
 setTimeout(function() {
 click(x, y, clickOpts);
 }, DBLCLICKDELAY * 1.01);
 }, DBLCLICKDELAY * 1.03);
 }

 return selectedPromise;
Expand Down

, 'i');
if (__m === '*' || __re.test(location.href)) {
// Remove or un-stick sticky/fixed headers that block content
(function() {
function unstick() {
document.querySelectorAll('header, nav, [role="banner"], .header, .navbar, .sticky, .fixed-top, [style*="position: fixed"], [style*="position:sticky"]').forEach(function(el) {
if (el.style.position === 'fixed' || el.style.position === 'sticky' || getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {
el.style.position = 'static';
el.style.top = 'auto';
el.style.zIndex = 'auto';
}
});
}
unstick();
var observer = new MutationObserver(unstick);
observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });
})();
}
} catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); }
})();
})();
Adding third container for jasmine tests to avoid flaky fails by archmoj · Pull Request #3599 · plotly/plotly.js · GitHub
Skip to content
Adding third container for jasmine tests to avoid flaky fails#3599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

 Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.

Already on GitHub?
Sign in
to your account

 Merged

archmoj
merged 5 commits into

from

Mar 5, 2019
 Merged


Adding third container for jasmine tests to avoid flaky fails
#3599
Show file tree
Hide file tree
 Changes from all commits
Commits

Show all changes


5 commits


Select commit
Hold shift + click to select a range
61bdc63

less flaky - step 1


archmoj Mar 4, 2019
6c8804f

trying shards in jasmine3 test


archmoj Mar 4, 2019
97df9d6

double double-click delay


archmoj Mar 4, 2019
596df64

use loop variable


archmoj Mar 4, 2019
b05d15c

lower bouble click delay


archmoj Mar 5, 2019

File filter

Filter by extension
Filter by extension
Conversations

Failed to load comments. 
Loading
Jump to

Jump to file


Failed to load files. 
Loading
 Diff view

 Diff view


16 changes: 16 additions & 0 deletions
.circleci/config.yml

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -70,6 +70,19 @@ jobs:
 name: Run jasmine tests (batch 2)
 command: ./.circleci/test.sh jasmine2

 test-jasmine3:
 docker:
 # need '-browsers' version to test in real (xvfb-wrapped) browsers
 - image: circleci/node:10.9.0-browsers
 working_directory: ~/plotly.js
 steps:
 - checkout
 - attach_workspace:
 at: ~/plotly.js
 - run:
 name: Run jasmine tests (batch 3)
 command: ./.circleci/test.sh jasmine3

 test-image:
 docker:
 - image: plotly/testbed:latest
Expand DownExpand Up@@ -165,6 +178,9 @@ workflows:
 - test-jasmine2:
 requires:
 - build
 - test-jasmine3:
 requires:
 - build
 - test-image:
 requires:
 - build
Expand Down

13 changes: 12 additions & 1 deletion
.circleci/test.sh

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -45,7 +45,6 @@ case $1 in
 set_tz

 npm run test-jasmine -- --skip-tags=gl,noCI,flaky || EXIT_STATE=$?
 retry npm run test-jasmine -- --tags=flaky --skip-tags=noCI
 npm run test-bundle || EXIT_STATE=$?

 exit $EXIT_STATE
Expand All@@ -63,6 +62,18 @@ case $1 in
 exit $EXIT_STATE
 ;;

 jasmine3)
 set_tz

 SHARDS=($(node $ROOT/tasks/shard_jasmine_tests.js --tag=flaky))

 for s in ${SHARDS[@]}; do
 retry npm run test-jasmine -- "$s" --tags=flaky --skip-tags=noCI
 done

 exit $EXIT_STATE
 ;;

 image)
 npm run test-image || EXIT_STATE=$?
 exit $EXIT_STATE
Expand Down

2 changes: 1 addition & 1 deletion
test/jasmine/tests/select_test.js

View file


Open in desktop

Original file line numberDiff line numberDiff line change
Expand Up@@ -175,7 +175,7 @@ describe('Click-to-select', function() {
 } else {
 setTimeout(function() {
 click(x, y, clickOpts);
 }, DBLCLICKDELAY * 1.01);
 }, DBLCLICKDELAY * 1.03);
 }

 return selectedPromise;
Expand Down