Uh oh!
There was an error while loading. Please reload this page.
Fix scattergl mising points plot and react - #4323
Conversation
- bump regl-scatter2d 3.1.7 - bump regl-splom 1.0.8
| var x = []; | ||
| var y = []; | ||
| for(var i = 0; i < num; i++) { | ||
| x.push(Math.random()); |
There was a problem hiding this comment.
Random numbers are dangerous in tests. If you really need this to look like random numbers, you can use Lib.pseudoRandom() (preceded by Lib.seedPseudoRandom()) as a repeatable alternative.
There was a problem hiding this comment.
@alexcjohnson thanks for the review.
Good call! Addressed for scattergl_test and other jasmine tests in 902b084.
There was a problem hiding this comment.
Beautiful, thank you for extending that to the rest of the test suite!
alexcjohnson
left a comment
There was a problem hiding this comment.
Looks great, patch away! 💃
| if(opts.marker) { | ||
| opts.marker.snap = stash.tree || TOO_MANY_POINTS; | ||
| } | ||
| if(opts.marker) opts.marker.snap = len; |
There was a problem hiding this comment.
Ha - there is it!
That's the piece I was missing. Thank you very much @archmoj - this is probably the best bug fix for the library in 2019.
etpinard
commented
Nov 18, 2019
I'm curious @archmoj does the new mock |
Fix#2334, #3405 and #3751.
Bump
point cluster3.1.8,regl-scatter2d3.1.7 andregl-splom1.0.8 and update snap according to datalength.@plotly/plotly_js