Uh oh!
There was an error while loading. Please reload this page.
Align interactions when plot created inside scaled and/or translated elements using CSS transform - #5193
Conversation
archmoj
commented
Oct 21, 2020
Thanks very much @alexhartstone for submitting this PR. |
archmoj
commented
Oct 22, 2020
@alexhartstone FYI - I also added few more commits to that branch that may be of interest. |
archmoj
commented
Oct 22, 2020
@alexhartstone just to let you know. I am investing more time on the dev-branch today. I will let you when I was able to complete my journey. |
@alexhartstone please pick my commits from https://github.com/plotly/plotly.js/compare/pull-5193_ms or alternatively allow us as the maintainers access to push into your branch. Please find the instructions here https://github.com/plotly/plotly.js/blob/master/.github/PULL_REQUEST_TEMPLATE.md With all those fixes the transforms e.g. |
archmoj
commented
Nov 18, 2020
@alexhartstone I just noticed that there is a problem with the position of hover on |
archmoj
commented
Nov 18, 2020
@alexhartstone Also the |
archmoj
commented
Nov 18, 2020
@alexcjohnson This PR is now ready for review. |
archmoj
commented
Nov 18, 2020
Issues with So this looks ready to 💃 |
archmoj
commented
Nov 18, 2020
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
Co-authored-by: Alex Johnson <johnson.alex.c@gmail.com>
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Beautiful - nice work @archmoj and @alexhartstone! Fantastic tests.
💃 pending confirmation that mapbox works right in FF looks like you've confirmed 🎉
archmoj
commented
Nov 18, 2020
@alexhartstone please open a new issue describing why recomputing transform matrix on events is required in your particular application with a demo like this codepen. |
alexhartstone
commented
Nov 18, 2020
Awesome @archmoj@alexcjohnson thanks guys! |
nicolaskruchten
commented
Nov 19, 2020
Thank you so much for taking the initiative on this @alexhartstone ! |
nlevari
commented
Dec 14, 2020
@alexhartstone, Thanks you so much for this fix. I spent days trying to workaround, unscaling and rescaling. |

Fixes#888.
This is the first commit of a few fixes for interactions with plots that are broken due when css transform scaling is applied.
The general aim is to undo the transform matrices applied to these elements for the interactions.
TODOs:
panzoom&paninternary&polarscattermapboxhover&selectchoroplethmapboxhoverhoveronsankeytracehoveronparcatstracehover,selectanddrag-zoomtests forcartesiansubplotshover,selectanddrag-zoomtests forpolarsubplotshover,selectanddrag-zoomtests formapboxsubplots i.e.choroplethmapboxandscattermapboxhover,selectanddrag-zoomtests forgeosubplots e.g.choroplethhover,selectanddrag-zoomtests forternarysubplots