Uh oh!
There was an error while loading. Please reload this page.
5291: recalculation of dynamic CSS transforms on hover - #5302
Conversation
archmoj
left a comment
There was a problem hiding this comment.
Thanks very much for the follow up PR.
Please find my comments below.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
alexhartstone
commented
Nov 26, 2020
Currently changing tests slightly to check the changes work. Having some issues with the polar tests failing when they shouldn't, will investigate. |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
archmoj
commented
Nov 26, 2020
Here is a demo using the changes made by this branch. |
alexhartstone
commented
Nov 27, 2020
Fixing up syntax errors now - npm run test-syntax doesn't seem to be picking up a lot of my syntax errors, weirdly. I've installed eslint and that seems to get it |
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
archmoj
commented
Nov 27, 2020
Have you tested hover on |
archmoj
commented
Nov 27, 2020
Nevermind. |
…lc from gl3d, parcats and sankey
archmoj
commented
Nov 27, 2020
Thanks @alexhartstone |
Adds a conditional transform recalculation method to plot api, and calls it in interactions