Skip to content

Remove *src attributes - #7829

Merged
emilykl merged 9 commits into
v4.0from
remove-src-attrs
Jun 10, 2026
Merged

Remove *src attributes#7829
emilykl merged 9 commits into
v4.0from
remove-src-attrs

Conversation

@emilykl

Copy link
Copy Markdown
Contributor

Addresses #7623

Schema attributes ending in src existed only to work with Chart Studio features, so they are no longer necessary

This PR:

  • Removes all *src attributes and associated logic
  • Removes layout.hideSources attribute which was also only needed for Chart Studio
  • Updates tests accordingly (including deleting these removed attributes from image mocks)
  • Updates typegen script
  • Regenerates plot-schema.json and generated types

Copy link
Copy Markdown
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This second draftlog is for PR #7812, which we forgot to add a draftlog for at the time.

Comment threadsrc/plots/plots.js Outdated
Comment threadtest/jasmine/tests/plots_test.js Outdated
Comment threadtest/jasmine/tests/plots_test.js Outdated
Comment threaddraftlogs/7623_change.md Outdated
@emilykl
emilykl requested a review from camdecosterJune 9, 2026 19:16
Comment threaddraftlogs/7623_change.md Outdated
@emilykl
emilykl merged commit d01c5fe into v4.0Jun 10, 2026
83 checks passed
@emilykl
emilykl deleted the remove-src-attrs branch June 10, 2026 16:25
@emilyklemilykl mentioned this pull request Jun 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@emilykl@camdecoster@archmoj